RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 1193682 - throughput-performance profile triggers hdparm commands on hotplug events
Summary: throughput-performance profile triggers hdparm commands on hotplug events
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 7
Classification: Red Hat
Component: tuned
Version: 7.1
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: rc
: ---
Assignee: Jaroslav Škarvada
QA Contact: Tereza Cerna
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-02-17 21:29 UTC by Scott Dodson
Modified: 2019-02-12 16:28 UTC (History)
4 users (show)

Fixed In Version: tuned-2.5.1-3.el7
Doc Type: Bug Fix
Doc Text:
Cause: Previously hotplug events triggered by insertion of block devices could cause hdparm calls even if hdparm related settings aren't specified in Tuned profile. Consequence: APM and spindown settings of the newly attached rotary disks could be changed to non-requested values or related errors may be logged to Tuned log (e.g. if APM or spindown settings are not supported by the block device or hdparm package is not installed). Fix: The problem was that the hotplug event could initiate the code path for initialization of dynamic tuning even if the dynamic tuning was disabled. The code was fixed and now if the dynamic tuning is disabled the execution don't go the path for dynamic tuning. Result: Hdparm is now not called on hotplug events if dynamic tuning is disabled and hdparm related parameters are not set in the Tuned profile.
Clone Of:
Environment:
Last Closed: 2015-11-19 12:21:42 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2015:2375 0 normal SHIPPED_LIVE tuned bug fix and enhancement update 2015-11-19 10:51:42 UTC

Description Scott Dodson 2015-02-17 21:29:01 UTC
This is forked from discussion in https://bugzilla.redhat.com/show_bug.cgi?id=1190654#c6

The throughput-performance profile triggers hdparm commands on hotplug events for loop0 devices like those triggered when creating docker containers in RHEL 7.1. This is in tuned-2.4.1.

(In reply to Jaroslav Škarvada from comment #5)
> > > u'/sys/devices/system/cpu/cpu0/cpufreq/scaling_available_governors'
> > > 2015-02-09 18:21:24,073 INFO     tuned.plugins.plugin_cpu: ignoring governor
> > > 'performance' on cpu 'cpu0', it is not supported
> > > 2015-02-09 18:21:24,076 ERROR    tuned.utils.commands: Executing cpupower
> > > error: analyzing CPU 1:
> > > 2015-02-09 18:21:24,076 ERROR    tuned.plugins.plugin_cpu: could not get
> > > current governor on cpu 'cpu1'
> > > 2015-02-09 18:21:24,077 ERROR    tuned.utils.commands: Reading
> > > /sys/devices/system/cpu/cpu1/cpufreq/scaling_available_governors error:
> > > [Errno 2] No such file or directory:
> > > u'/sys/devices/system/cpu/cpu1/cpufreq/scaling_available_governors'
> > > 2015-02-09 18:21:24,077 INFO     tuned.plugins.plugin_cpu: ignoring governor
> > > 'performance' on cpu 'cpu1', it is not supported
> > > 2015-02-09 18:21:26,525 INFO     tuned.plugins.hotplug: device 'dm-2' added
> > > 2015-02-09 18:21:26,526 INFO     tuned.plugins.hotplug: instance disk:
> > > adding new device dm-2
> > > 2015-02-09 18:21:26,628 ERROR    tuned.utils.commands: Executing hdparm
> > > error: [Errno 2] No such file or directory
> > 
> > > 2015-02-09 18:21:26,630 INFO     tuned.plugins.hotplug: device 'loop1' added
> > > 2015-02-09 18:21:26,630 INFO     tuned.plugins.hotplug: instance disk:
> > > adding new device loop1
> > > 2015-02-09 18:21:26,637 ERROR    tuned.utils.commands: Executing hdparm
> > > error: [Errno 2] No such file or directory
> > > 2015-02-09 18:21:26,638 INFO     tuned.plugins.hotplug: device 'loop0' added
> > > 2015-02-09 18:21:26,638 INFO     tuned.plugins.hotplug: instance disk:
> > > adding new device loop0
> > > 2015-02-09 18:21:26,648 ERROR    tuned.utils.commands: Executing hdparm
> > > error: [Errno 2] No such file or directory
> > 
> > hdparm is going to be a bit of a challenge.  It's harmless, but if I
> > remember correctly, the hotplug plugin was meant to automatically apply
> > tunings to newly attached SAN luns.  I don't have a sense of if anyone is
> > using that feature in the field, but perhaps we could disable it for
> > openshift?  Not sure that's appropriate either...
> >
> It seems it applies disk tuning for newly attached device. Not sure why it
> calls hdparm. Hdparm is used only in disk_plugin to set APM and spindown. It
> shouldn't be touched if 'apm' or 'spindown' parameters are not set in the
> profile. Do you set these parameters?

No, we're based off of throughput-performance though.

https://github.com/openshift/origin/blob/master/tuned/openshift-node/tuned.conf

Comment 2 Jaroslav Škarvada 2015-06-16 13:09:15 UTC
Upstream commit fixing this problem:
https://git.fedorahosted.org/cgit/tuned.git/commit/?id=6c155396eecc0258ad2429e44656f1664872d9f6

Comment 6 errata-xmlrpc 2015-11-19 12:21:42 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2015-2375.html


Note You need to log in before you can comment on or make changes to this bug.