Bug 1198609 - Configure new user role dialog: faulty rendering due to javascript exception (missing "ActionGroup___DISK_LIVE_STORAGE_MIGRATION")
Summary: Configure new user role dialog: faulty rendering due to javascript exception ...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat Enterprise Virtualization Manager
Classification: Red Hat
Component: ovirt-engine
Version: 3.5.0
Hardware: Unspecified
OS: Unspecified
unspecified
urgent
Target Milestone: ovirt-3.6.0-rc
: 3.6.0
Assignee: Maor
QA Contact: Aharon Canan
URL:
Whiteboard:
Depends On:
Blocks: 1196099 1199812
TreeView+ depends on / blocked
 
Reported: 2015-03-04 13:53 UTC by Nisim Simsolo
Modified: 2016-03-10 12:06 UTC (History)
10 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
: 1199812 (view as bug list)
Environment:
Last Closed:
oVirt Team: Storage
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
new role screenshot (198.31 KB, image/png)
2015-03-04 13:56 UTC, Nisim Simsolo
no flags Details
screen-shot: javascript exception in 3.5 (200.73 KB, image/png)
2015-03-05 20:05 UTC, Einav Cohen
no flags Details
screen-shot: javascript warning in latest ovirt master (135.37 KB, image/png)
2015-03-05 20:06 UTC, Einav Cohen
no flags Details


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 38455 0 master MERGED core: adding missing action group Never

Description Nisim Simsolo 2015-03-04 13:53:41 UTC
Description of problem:
When trying to add new user role, the dialog box displays are missing and "new role" window cannot be closed.
In order to return to engine UI, browser refresh/reopen is needed.
This issue prevents administrator from creating new user role.

Version-Release number of selected component (if applicable):
rhevm-3.5.1-0.1.el6ev

How reproducible:
Consistently

Steps to Reproduce:
1. Open RHEVM administrator portal and navigate to: configure > roles > new
2. 
3.

Actual results:
Dialog box displays does not appear, so user roles cannot be created.
"new user" window cannot be closed.

Expected results:
Dialog box displays should appear and new user role should be configurable.

Additional info:
Screenshot attached.

Comment 1 Nisim Simsolo 2015-03-04 13:56:03 UTC
Created attachment 997852 [details]
new role screenshot

Comment 2 Einav Cohen 2015-03-05 20:05:34 UTC
Created attachment 998534 [details]
screen-shot: javascript exception in 3.5

Comment 3 Einav Cohen 2015-03-05 20:06:07 UTC
Created attachment 998535 [details]
screen-shot: javascript warning in latest ovirt master

Comment 4 Einav Cohen 2015-03-05 20:14:12 UTC
patch https://gerrit.ovirt.org/#/c/36597/ added a new Action-Group (DISK_LIVE_STORAGE_MIGRATION) without adding a matching entry ("ActionGroup___DISK_LIVE_STORAGE_MIGRATION") to LocalizedEnums.
this causes the javascript exception seen in attachment 998534 [details], which leads to a faulty rendering of the New Role dialog. 

BTW, in ~latest ovirt master, there is a javascript warning (see attachment 998535 [details]) rather than a javascript error (not sure why), and the dialog is rendered successfully.

Comment 5 Maor 2015-03-07 23:02:14 UTC
(In reply to Einav Cohen from comment #4)
> patch https://gerrit.ovirt.org/#/c/36597/ added a new Action-Group
> (DISK_LIVE_STORAGE_MIGRATION) without adding a matching entry
> ("ActionGroup___DISK_LIVE_STORAGE_MIGRATION") to LocalizedEnums.
> this causes the javascript exception seen in attachment 998534 [details],
> which leads to a faulty rendering of the New Role dialog. 
> 
> BTW, in ~latest ovirt master, there is a javascript warning (see attachment
> 998535 [details]) rather than a javascript error (not sure why), and the
> dialog is rendered successfully.

It looks like in upstream we only use keys instead of values, while in branch 3.5 we do translate those keys.

Comment 6 Maor 2015-03-07 23:14:30 UTC
I've added a separate bug on that issue at https://bugzilla.redhat.com/1199753

Comment 8 lkuchlan 2015-04-26 10:56:21 UTC
Tested using ovirt-engine-3.6.0-0.0.master.20150412172306.git55ba764

Comment 10 Allon Mureinik 2016-03-10 10:46:45 UTC
RHEV 3.6.0 has been released, setting status to CLOSED CURRENTRELEASE

Comment 11 Allon Mureinik 2016-03-10 10:49:42 UTC
RHEV 3.6.0 has been released, setting status to CLOSED CURRENTRELEASE

Comment 12 Allon Mureinik 2016-03-10 12:06:13 UTC
RHEV 3.6.0 has been released, setting status to CLOSED CURRENTRELEASE


Note You need to log in before you can comment on or make changes to this bug.