Description of problem: ============================== Config options in the fusor installer should have validation. Fields currently accept any and everything Version-Release number of selected component (if applicable): =============================================================== RHCI_Sat6_1_Beta_1_compose_20150210.0___2015_02_20_1509.iso How reproducible: =============== 100% Steps to Reproduce: 1. Install RHEL with the ISO 2. Reboot 3. Allow fusor-installer to start 4. Change timezone to empty value 5. Change IP address to 'A' Actual results: ====================== Bad values accepted Expected results: ====================== Bad values should not be accepted
*** Bug 1247404 has been marked as a duplicate of this bug. ***
Still occurs in tech preview rc-1
Still occurs in TP2 RC7: RHCI-6.0-RHEL-7-20160204.0-RHCI-x86_64-dvd1.iso fusor-installer will throw an error with a traceback when proceeding with empty vaules: /usr/share/ruby/ipaddr.rb:475:in `initialize': address family must be specified (IPAddr::AddressFamilyError) from /usr/share/katello-installer/hooks/lib/provisioning_wizard.rb:190:in `new' from /usr/share/katello-installer/hooks/lib/provisioning_wizard.rb:190:in `validate_own_gateway' from /usr/share/katello-installer/hooks/lib/base_wizard.rb:63:in `block in validate' from /usr/share/katello-installer/hooks/lib/base_wizard.rb:61:in `map' from /usr/share/katello-installer/hooks/lib/base_wizard.rb:61:in `validate' from /usr/share/katello-installer/hooks/lib/base_wizard.rb:38:in `start' from /usr/share/katello-installer/hooks/lib/provisioning_wizard.rb:52:in `start' from /usr/share/katello-installer/hooks/pre_validations/10-gather_and_set_fusor_values.rb:5:in `block (4 levels) in load' from /usr/share/gems/gems/kafo-0.6.5.9/lib/kafo/hooking.rb:32:in `instance_eval' from /usr/share/gems/gems/kafo-0.6.5.9/lib/kafo/hooking.rb:32:in `block (4 levels) in load' from /usr/share/gems/gems/kafo-0.6.5.9/lib/kafo/hook_context.rb:13:in `instance_exec' from /usr/share/gems/gems/kafo-0.6.5.9/lib/kafo/hook_context.rb:13:in `execute' from /usr/share/gems/gems/kafo-0.6.5.9/lib/kafo/hooking.rb:49:in `block in execute' from /usr/share/gems/gems/kafo-0.6.5.9/lib/kafo/hooking.rb:47:in `each' from /usr/share/gems/gems/kafo-0.6.5.9/lib/kafo/hooking.rb:47:in `execute' from /usr/share/gems/gems/kafo-0.6.5.9/lib/kafo/kafo_configure.rb:92:in `execute' from /usr/share/gems/gems/clamp-0.6.2/lib/clamp/command.rb:67:in `run' from /usr/share/gems/gems/clamp-0.6.2/lib/clamp/command.rb:125:in `run' from /usr/share/gems/gems/kafo-0.6.5.9/lib/kafo/kafo_configure.rb:116:in `run' from /usr/sbin/fusor-installer:63:in `<main>'
Still occurs in TP RC8
Stil occurs in TP3_RC1
What is still occurring? What values are you leaving bad/empty and able to proceed with?
I followed Dave's steps in https://bugzilla.redhat.com/show_bug.cgi?id=1198648#c0
Unable to proceed because of following errors: NTP sync host must be specified NTP host cannot be blank anymore. This is related to the IP address being an invalid ip because the hostname and ip checks are rolled together. Please give this a try (full path of file on system is /usr/share/katello-installer/hooks/lib/provisioning_wizard.rb) if you have some time to verify better behavior. https://github.com/fusor/fusor-installer/pull/53/files
Addressed in TP3 RC3
Created attachment 1149457 [details] Screenshot showing the invalid IP address and blank NTP host
Created attachment 1149459 [details] stack trace that appears after starting the installer with invalid inputs
Tested with TP3 RC4. This issue is still present. Following the reproduction steps in the description, I entered the IP address as "A" and left the NTP server blank. I entered "1" to proceed with the installation. Then a stack trace prints out and the installer exits. The attached screenshots show the values entered and the resulting stack trace.
I see, it's the combined bad/empty input. https://github.com/fusor/fusor-installer/pull/56/files
Built in QCI-1.0-RHEL-7-20160422.t.0-QCI-x86_64-dvd1.iso
Verified as working in TP3_RC5 I followed the reproduction steps in the description and once I tried to start the installation, I received a message and was returned to the settings screen to correct my errors. The message was: Unable to proceed because of following errors: IP address is invalid You must specify a netmask Network address - Invalid IP address DHCP Gateway - Invalid IP address Time zone is not a valid IANA time zone identifier