Bug 1198866 - RFE: Include a sub-package for the -accelerate module?
Summary: RFE: Include a sub-package for the -accelerate module?
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: PyOpenGL
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: François Cami
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1205694
TreeView+ depends on / blocked
 
Reported: 2015-03-05 00:27 UTC by Jonathan Underwood
Modified: 2021-12-16 05:07 UTC (History)
2 users (show)

Fixed In Version: PyOpenGL-3.1.0-2.fc21
Clone Of:
Environment:
Last Closed: 2015-05-27 21:29:46 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
Patch to add accelerate module (4.02 KB, patch)
2015-04-01 14:42 UTC, Jonathan Underwood
no flags Details | Diff
Patch to add accelerate module into main packages (4.07 KB, patch)
2015-04-03 12:22 UTC, Jonathan Underwood
no flags Details | Diff
Patch to add accelerate module into main packages (3.94 KB, patch)
2015-04-03 13:38 UTC, Jonathan Underwood
no flags Details | Diff

Description Jonathan Underwood 2015-03-05 00:27:45 UTC
Description of problem:
There is an add-on for pyopengl which accelerates some opengl instructions using cython: 

https://pypi.python.org/pypi/PyOpenGL-accelerate

Releases of this seem to be lock-step versioned with pyopengl (i.e. a specific version of pyopengl-accelerate will only work with the corresponding pyopengl). It would be good to have this packaged for Fedora - xpra which I am currenly trying to get reviewed and included in Fedora makes use of it. Because of the version locking to pyopengl, I think it would make most sense to build it in the same spec file, and split it off as an (arch'ed) submodule. 

What do you think?

Comment 1 Christopher Meng 2015-04-01 04:01:50 UTC
I think it's acceptable since they are from the same upstream.

Comment 2 Jonathan Underwood 2015-04-01 09:48:49 UTC
OK, great, thanks very much.

Comment 3 Jonathan Underwood 2015-04-01 10:13:54 UTC
Is it helpful to work on a patch for this, or are you already working on it?

Comment 4 Christopher Meng 2015-04-01 11:11:11 UTC
(In reply to Jonathan Underwood from comment #3)
> Is it helpful to work on a patch for this, or are you already working on it?

You can provide a patch since I haven't started working on this, I plan to move to 3.1.1a1.

Comment 5 Jonathan Underwood 2015-04-01 13:47:00 UTC
Hmmm.. OK I worked on this, but unfortunately, as far as I can see, it's actually not possible to have the main package be noarch, and an arch dependent sub-package (the opposite is possible, of course). Have I missed something?

Comment 6 Jonathan Underwood 2015-04-01 14:42:30 UTC
Created attachment 1009687 [details]
Patch to add accelerate module

Comment 7 Jonathan Underwood 2015-04-01 14:43:09 UTC
That's what the patch looks like adding the module to the package and removing noarch...

Comment 8 Jonathan Underwood 2015-04-01 14:47:26 UTC
If we went the route of making the package arch dependent, it might actually make sense to include the -accelerate module in the main package rather than splitting off into a sub-packages.

Comment 9 Jonathan Underwood 2015-04-01 15:40:18 UTC
Ah, of course, that patch is not multilib compatible - I missed out all the %{isa} stuff that would be needed. Before I do any further work, can you let me know if you're happy with:

1) Having the packages move to arch dependent (actually I guess the Tk sub-packages could remain noarch).

2) Having the accelerate modules in the main packages rather than sub-packages.

Comment 10 Jonathan Underwood 2015-04-03 12:22:59 UTC
Created attachment 1010615 [details]
Patch to add accelerate module into main packages

This patch adds the accelerate module, but doesn't split it out into separate sub-packages as there doesn't seem to be much point doing so. The main packages are now noarch, and the -Tk subpackages are noarch sub-packages.

Comment 11 Jonathan Underwood 2015-04-03 13:38:42 UTC
Created attachment 1010631 [details]
Patch to add accelerate module into main packages

As previously, but with the extraneous %_{isa} bits in the TK noarch packages.

Comment 12 Jonathan Underwood 2015-04-03 14:50:13 UTC
(In reply to Jonathan Underwood from comment #11)
> Created attachment 1010631 [details]
> Patch to add accelerate module into main packages
> 
> As previously, but with the extraneous %_{isa} bits in the TK noarch
> packages.

*without* the the extraneous %_{isa} bits, I mean.

Comment 13 Jonathan Underwood 2015-04-28 13:06:39 UTC
Hi Christopher - any thoughts on this?

Comment 14 Jonathan Underwood 2015-05-08 14:53:43 UTC
Ping

Comment 15 Jonathan Underwood 2015-05-27 18:51:46 UTC
Hi Christopher - would be great to get some movement on this.

Comment 16 François Cami 2015-05-27 19:00:01 UTC
I'll handle it.

Comment 17 François Cami 2015-05-27 21:29:46 UTC
Jonathan, I've reviewed and committed your latest patch.

PyOpenGL is currently building for rawhide:
http://koji.fedoraproject.org/koji/taskinfo?taskID=9858838

@Christopher: I will merge the changes into F22, and possibly even F21, soonish, if you have no objection.

Comment 18 Jonathan Underwood 2015-05-27 21:35:53 UTC
Thanks very much Francois.

It would be great to get packages pushed for F22 and F21 too. Could I ask you to add this BZ to the update, so i see when the updates are pushed - that way I can start Require'ing the accelerate module in the xpra packages.

Comment 19 François Cami 2015-05-27 21:58:45 UTC
My pleasure.

I've merged & pushed the changes into F22+F21 and create updates when the builds are done.

Comment 20 Fedora Update System 2015-05-27 22:10:43 UTC
PyOpenGL-3.1.0-2.fc22 has been submitted as an update for Fedora 22.
https://admin.fedoraproject.org/updates/PyOpenGL-3.1.0-2.fc22

Comment 21 Fedora Update System 2015-05-27 22:12:18 UTC
PyOpenGL-3.1.0-2.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/PyOpenGL-3.1.0-2.fc21

Comment 22 François Cami 2015-05-27 22:13:53 UTC
As requested :)

Comment 23 Jonathan Underwood 2015-05-28 09:39:02 UTC
Great, thanks very much for this Francois.

Comment 24 Jonathan Underwood 2015-06-27 14:47:49 UTC
Please can you psh these updates to stable? 

Also, I've applied to co-maintain this package in the pkgdb - I'd be grateful if you could approve.

Thanks.

Comment 25 François Cami 2015-06-27 20:23:23 UTC
Pushed.

As for co-maintainship, +1 from me but that's Christopher's call.

Comment 26 Jonathan Underwood 2015-06-27 21:14:42 UTC
Unfortunately Christopher seems not to be responding presently - no Fedora activity since March 24th.

Comment 27 Fedora Update System 2015-06-29 23:57:59 UTC
PyOpenGL-3.1.0-2.fc22 has been pushed to the Fedora 22 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 28 Fedora Update System 2015-06-29 23:59:06 UTC
PyOpenGL-3.1.0-2.fc21 has been pushed to the Fedora 21 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.