Bugzilla (bugzilla.redhat.com) will be under maintenance for infrastructure upgrades and will not be unavailable on July 31st between 12:30 AM - 05:30 AM UTC. We appreciate your understanding and patience. You can follow status.redhat.com for details.
Bug 1200498 - The output of rhq:audit is changed - Date is added to the "info"
Summary: The output of rhq:audit is changed - Date is added to the "info"
Status: ON_QA
Alias: None
Product: RHQ Project
Classification: Other
Component: Provisioning
Version: 4.12
Hardware: Unspecified
OS: Unspecified
Target Milestone: ---
: RHQ 4.14
Assignee: Nobody
QA Contact: Mike Foley
Depends On:
Blocks: 1200493
TreeView+ depends on / blocked
Reported: 2015-03-10 16:47 UTC by bkramer
Modified: 2020-04-27 01:29 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Last Closed:

Attachments (Terms of Use)
screen shot (112.78 KB, image/png)
2015-03-10 16:47 UTC, bkramer
no flags Details
example of the bundle (9.64 KB, application/zip)
2015-03-10 16:47 UTC, bkramer
no flags Details

Description bkramer 2015-03-10 16:47:19 UTC
Created attachment 1000065 [details]
screen shot

Description of problem:
In the bundles recipes events are logged like this:

<rhq:audit action="CONF_ITEM" info="PREINSTALL" message="My message - preinstall"></rhq:audit>			

In RHQ 4.9 the 'info' field has actual value as defined above (info=PREINSTALL).

In RHQ 4.12 a date is added at the end of info so info=PREINSTALLTue Mar 10 16:16:52 GMT 2015

Version-Release number of selected component (if applicable):
RHQ 4.12

How reproducible:

Steps to Reproduce:
1. Install RHQ 4.12
2. Create a test group that contains "platform" resources (for instance);
3. Navigate to Bundles and upload a bundle whose recipe contains:
    <rhq:audit action="CONF_ITEM" info="PREINSTALL" message="My message - preinstall"></rhq:audit>
4. Deploy newly uploaded bundle to the resource group (created in step 2)  and define a deployment directory;
5. Navigate to bundle deployment and double click on status to open deployment history
6. Find "CONF_ITEM" action and check it's info

Actual results:
Info: PREINSTALLTue Mar 10 16:16:52 GMT 2015

Expected results:

Additional info:
Added a screen shot that shows an issue and bundle example.

Comment 1 bkramer 2015-03-10 16:47:55 UTC
Created attachment 1000066 [details]
example of the bundle

Comment 2 Lukas Krejci 2015-03-10 17:29:55 UTC
This was accidentally introduced by BZ 1050014.

The changes for that BZ introduced what should have been a more optimal use of string builder to compose the message but actually caused its corruption due to incorrectly parenthesized statement.

The behavior prior to BZ 1050014 was to output the info or, if info was not set, to output "Timestamp: <current-time-and-date>" (where current-time-and-date was replaced by the actual current time and date at that instant).

After the accidental change the output was changed to info, or if info was not set, to "Timestamp: ". In both cases followed by the current time and date.

This is an unfortunate regression that splipped by QE.

Comment 3 Lukas Krejci 2015-03-10 17:40:20 UTC
commit 4c30284446bd9af845de82961479170f43964451
Author: Lukas Krejci <lkrejci@redhat.com>
Date:   Tue Mar 10 18:38:36 2015 +0100

    [BZ 1200498] Restore the format of ant bundle audit log message

Note You need to log in before you can comment on or make changes to this bug.