Spec URL: https://chandankumar.fedorapeople.org/python-wrapt.spec SRPM URL: https://chandankumar.fedorapeople.org/python-wrapt-1.10.2-1.fc21.src.rpm Description: The aim of the **wrapt** module is to provide a transparent object proxy for Python, which can be used as the basis for the construction of function wrappers and decorator functions. Fedora Account System Username: chandankumar koji-build: http://koji.fedoraproject.org/koji/taskinfo?taskID=9205396
Hi Chandan, We have this process http://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group to get sponsored into the packager group. Can you either submit few more packages and/or some full detailed package reviews? This is needed to make sure package submitter understands the rpm packaging well and follows the fedora packaging guidelines. Please go through the following links 1) http://fedoraproject.org/wiki/Package_Review_Process 2) https://fedoraproject.org/wiki/PackagingGuidelines 3) To find the packages already submitted for review, check http://fedoraproject.org/PackageReviewStatus/ 4) http://fedoraproject.org/wiki/Packaging:ReviewGuidelines and http://fedoraproject.org/wiki/Package_Review_Process#Reviewer is useful while doing package reviews. 5) https://fedorahosted.org/FedoraReview/ this is fedora-review tool to help review packages in fedora. You need to use this and do un-official package reviews of packages submitted by other contributors. While doing so mention "This is un-official review of the package." at top of your review comment. Good to review packages listed in http://fedoraproject.org/PackageReviewStatus/NEW.html When you do full package review of some packages, provide that review comment link here so that I can look how you have reviewed those packages. If you got any questions please ask :)
Review: + mock build is successful for f23 + rpmlint output on rpms gave 2 packages and 0 specfiles checked; 0 errors, 0 warnings. + License "BSD" is valid and included in LICENSE file. + rest looks following packaging guidelines Suggestions: 1) some cosmetic change in %description is required, change **wrapt** to just wrapt 2) We have now %license macro to use to mark license files. So, you should use it as %license LICENSE 3) You can add README as %doc files. 4) I will suggest to use Source URL as Source0: https://github.com/GrahamDumpleton/%{name}/archive/%{version}.tar.gz The advantage of using github tarball instead of pypi is that we get the documentation files. Now when you change the tarball to github, you need to add subpackage -doc that will install documentation files. Then in %install you should add pushd docs sphinx-build -b html -d build/doctrees . build/html popd 5) bump the release tag, add what changes you did in changelog. Submit a new srpm and spec file links. You may also want to contact upstream to check if wrapt library is python3 compatible or not.
Hey Parag, Thanks for the review. Here is the updated SPEC: https://chandankumar.fedorapeople.org/python-wrapt.spec SRPM: https://chandankumar.fedorapeople.org/python-wrapt-1.10.4-2.fc21.src.rpm and Koji Build: http://koji.fedoraproject.org/koji/taskinfo?taskID=9309000 Thanks, Chandan Kumar
Hello Parag, Thanks for the review. After fixing the docs in spec file, Here is the updated SPEC:https://chandankumar.fedorapeople.org/python-wrapt.spec SRPM: https://chandankumar.fedorapeople.org/python-wrapt-1.10.4-3.fc21.src.rpm and Koji Build: http://koji.fedoraproject.org/koji/taskinfo?taskID=9318115 Thanks, Chandan Kumar
Hello Parag, Added doc files for subpackages, Here is the updated files SPEC: https://chandankumar.fedorapeople.org/python-wrapt.spec SRPM: https://chandankumar.fedorapeople.org/python-wrapt-1.10.4-4.fc21.src.rpm and Koji Build: http://koji.fedoraproject.org/koji/taskinfo?taskID=9318669 Thanks, Chandan Kumar
Looks good now. APPROVED.
New Package SCM Request ======================= Package Name: python-wrapt Short Description: A Python module for decorators, wrappers and monkey patching Upstream URL: https://github.com/GrahamDumpleton/wrapt Owners: chandankumar Branches: f22 InitialCC: apevec
Git done (by process-git-requests).
python-wrapt-1.10.4-4.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/python-wrapt-1.10.4-4.fc22
python-wrapt-1.10.4-4.fc22 has been pushed to the Fedora 22 testing repository.
python-wrapt-1.10.4-5.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/python-wrapt-1.10.4-5.fc22
python-wrapt-1.10.4-5.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report.