Fedora Account System
Red Hat Associate
Red Hat Customer
Spec URL: http://msimacek.fedorapeople.org/review/takari-plugin-testing/takari-plugin-testing.spec SRPM URL: http://msimacek.fedorapeople.org/review/takari-plugin-testing/takari-plugin-testing-2.1.0-1.fc21.src.rpm Description: Small, cohesive, one-stop library for developing unit and integration tests for Maven plugins. Provides alternative to, and arguably supersedes, maven-plugin-testing-harness and maven-verifier. Fedora Account System Username: msimacek
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package installs properly. Note: Installation errors (see attachment) See: https://fedoraproject.org/wiki/Packaging:Guidelines IGNORE, manual review - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. Note: Cannot find epl-v10.html in rpm(s) See: http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text ===== MUST items ===== Generic: [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Apache (v2.0)", "Unknown or generated". 21 files have unknown license. Detailed output of licensecheck in /home/gil/1201270-takari-plugin- testing/review-takari-plugin-testing/licensecheck.txt ASL 2.0 //some of the code was originally copied from org.apache.maven.plugin.testing.AbstractMojoTestCase and org.apache.maven.plugin.testing.MojoRule takari-plugin-testing-project-takari-plugin-testing-2.1.0/takari-plugin-testing/src/main/java/io/takari/maven/testing/Maven30xRuntime.java // some of the code was originally copied from org.apache.maven.plugin.testing.resources.TestResources takari-plugin-testing-project-takari-plugin-testing-2.1.0/takari-plugin-testing/src/main/java/io/takari/maven/testing/TestResources.java takari-plugin-testing-project-takari-plugin-testing-2.1.0/takari-plugin-testing/src/main/java/io/takari/maven/testing/executor/Embedded3xLauncher.java takari-plugin-testing-project-takari-plugin-testing-2.1.0/takari-plugin-testing/src/main/java/io/takari/maven/testing/executor/ForkedLauncher.java takari-plugin-testing-project-takari-plugin-testing-2.1.0/takari-plugin-testing/src/main/java/io/takari/maven/testing/executor/LauncherException.java takari-plugin-testing-project-takari-plugin-testing-2.1.0/takari-plugin-testing/src/main/java/io/takari/maven/testing/executor/MavenLauncher.java [?]: License file installed when any subpackage combination is installed. [-]: Package requires other packages for directories it uses. Note: No known owner of /usr/share/maven-metadata, /usr/share/licenses [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/licenses, /usr/share /maven-metadata [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. Note: Using prebuilt rpms. [?]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Java: [x]: Bundled jar/class files should be removed before build [x]: Packages have proper BuildRequires/Requires on jpackage-utils Note: Maven packages do not need to (Build)Require jpackage-utils. It is pulled in by maven-local [x]: Javadoc documentation files are generated and included in -javadoc subpackage [x]: Javadoc subpackages should not have Requires: jpackage-utils [x]: Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink) Maven: [x]: If package contains pom.xml files install it (including depmaps) even when building with ant [x]: POM files have correct Maven mapping [x]: Maven packages should use new style packaging [x]: Old add_to_maven_depmap macro is not being used [x]: Packages DO NOT have Requires(post) and Requires(postun) on jpackage- utils for %update_maven_depmap macro [x]: Package DOES NOT use %update_maven_depmap in %post/%postun [x]: Packages use %{_mavenpomdir} instead of %{_datadir}/maven2/poms ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [!]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in takari- plugin-testing-javadoc [x]: Package functions as described. [x]: Latest version is packaged. [!]: Package does not include license text files separate from upstream. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. Java: [x]: Package uses upstream build method (ant/maven/etc.) [x]: Packages are noarch unless they use JNI ===== EXTRA items ===== Generic: [!]: Rpmlint is run on all installed packages. Note: Mock build failed See: http://fedoraproject.org/wiki/Packaging/Guidelines#rpmlint [x]: Spec file according to URL is the same as in SRPM. Installation errors ------------------- INFO: mock.py version 1.2.7 starting (python version = 2.7.5)... Start: init plugins INFO: selinux enabled Finish: init plugins Start: run Start: chroot init INFO: calling preinit hooks INFO: enabled root cache INFO: enabled yum cache Start: cleaning yum metadata Finish: cleaning yum metadata INFO: enabled ccache Mock Version: 1.2.7 INFO: Mock Version: 1.2.7 Finish: chroot init INFO: installing package(s): /home/gil/1201270-takari-plugin-testing/takari-plugin-testing-2.1.0-1.fc23.noarch.rpm /home/gil/1201270-takari-plugin-testing/takari-plugin-testing-javadoc-2.1.0-1.fc23.noarch.rpm ERROR: Command failed. See logs for output. # /usr/bin/dnf --installroot /var/lib/mock/fedora-rawhide-i386/root/ --releasever 23 install /home/gil/1201270-takari-plugin-testing/takari-plugin-testing-2.1.0-1.fc23.noarch.rpm /home/gil/1201270-takari-plugin-testing/takari-plugin-testing-javadoc-2.1.0-1.fc23.noarch.rpm --setopt=tsflags=nocontexts Rpmlint ------- Checking: takari-plugin-testing-2.1.0-1.fc23.noarch.rpm takari-plugin-testing-javadoc-2.1.0-1.fc23.noarch.rpm takari-plugin-testing-2.1.0-1.fc23.src.rpm takari-plugin-testing.noarch: W: spelling-error %description -l en_US verifier -> versifier, verifies, verified takari-plugin-testing.src: W: spelling-error %description -l en_US verifier -> versifier, verifies, verified 3 packages and 0 specfiles checked; 0 errors, 2 warnings. Requires -------- takari-plugin-testing-javadoc (rpmlib, GLIBC filtered): jpackage-utils takari-plugin-testing (rpmlib, GLIBC filtered): java-headless jpackage-utils mvn(io.takari.m2e.workspace:org.eclipse.m2e.workspace.cli) mvn(junit:junit) mvn(org.apache.commons:commons-compress) mvn(org.apache.commons:commons-exec) mvn(org.codehaus.plexus:plexus-classworlds) mvn(org.codehaus.plexus:plexus-utils) Provides -------- takari-plugin-testing-javadoc: takari-plugin-testing-javadoc takari-plugin-testing: mvn(io.takari.maven.plugins:takari-plugin-integration-testing:pom:) mvn(io.takari.maven.plugins:takari-plugin-testing) mvn(io.takari.maven.plugins:takari-plugin-testing-project:pom:) mvn(io.takari.maven.plugins:takari-plugin-testing:pom:) takari-plugin-testing Source checksums ---------------- https://github.com/takari/takari-plugin-testing/archive/takari-plugin-testing-2.1.0.tar.gz : CHECKSUM(SHA256) this package : a5fb316e9bf77da6e4037f0e14fd27e98dd48f4aba5b0cf17b88402953abcfd9 CHECKSUM(SHA256) upstream package : a5fb316e9bf77da6e4037f0e14fd27e98dd48f4aba5b0cf17b88402953abcfd9 http://www.eclipse.org/legal/epl-v10.html : CHECKSUM(SHA256) this package : a40741b59364cc49449255e9b9bfe1fcfe6a2e7ab4d37ca89db3bacbfb14e9d2 CHECKSUM(SHA256) upstream package : a40741b59364cc49449255e9b9bfe1fcfe6a2e7ab4d37ca89db3bacbfb14e9d2 Generated by fedora-review 0.5.2 (63c24cb) last change: 2014-07-14 Command line :/usr/bin/fedora-review -vpn takari-plugin-testing -m fedora-rawhide-i386 Buildroot used: fedora-rawhide-i386 Active plugins: Generic, Shell-api, Java Disabled plugins: C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG
ISSUES: [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Apache (v2.0)", "Unknown or generated". 21 files have unknown license. Detailed output of licensecheck in /home/gil/1201270-takari-plugin- testing/review-takari-plugin-testing/licensecheck.txt ASL 2.0 takari-plugin-testing-project-takari-plugin-testing-2.1.0/takari-plugin-testing/src/main/java/io/takari/maven/testing/Maven30xRuntime.java takari-plugin-testing-project-takari-plugin-testing-2.1.0/takari-plugin-testing/src/main/java/io/takari/maven/testing/TestResources.java takari-plugin-testing-project-takari-plugin-testing-2.1.0/takari-plugin-testing/src/main/java/io/takari/maven/testing/executor/Embedded3xLauncher.java takari-plugin-testing-project-takari-plugin-testing-2.1.0/takari-plugin-testing/src/main/java/io/takari/maven/testing/executor/ForkedLauncher.java takari-plugin-testing-project-takari-plugin-testing-2.1.0/takari-plugin-testing/src/main/java/io/takari/maven/testing/executor/LauncherException.java takari-plugin-testing-project-takari-plugin-testing-2.1.0/takari-plugin-testing/src/main/java/io/takari/maven/testing/executor/MavenLauncher.java [?]: Package contains no bundled libraries without FPC exception. maven-plugin-testing-harness // some of the code was originally copied from org.apache.maven.plugin.testing.resources.TestResources //some of the code was originally copied from org.apache.maven.plugin.testing.AbstractMojoTestCase and org.apache.maven.plugin.testing.MojoRule takari-plugin-testing-project-takari-plugin-testing-2.1.0/takari-plugin-testing/src/main/java/io/takari/maven/testing/Maven30xRuntime.java takari-plugin-testing-project-takari-plugin-testing-2.1.0/takari-plugin-testing/src/main/java/io/takari/maven/testing/TestResources.java
(In reply to gil cattaneo from comment #2) > ISSUES: > > [ ]: License field in the package spec file matches the actual license. > Note: Checking patched sources after %prep for licenses. Licenses found: > "Apache (v2.0)", "Unknown or generated". 21 files have unknown license. > Detailed output of licensecheck in /home/gil/1201270-takari-plugin- > testing/review-takari-plugin-testing/licensecheck.txt > ASL 2.0 > takari-plugin-testing-project-takari-plugin-testing-2.1.0/takari-plugin- > testing/src/main/java/io/takari/maven/testing/Maven30xRuntime.java > takari-plugin-testing-project-takari-plugin-testing-2.1.0/takari-plugin- > testing/src/main/java/io/takari/maven/testing/TestResources.java > takari-plugin-testing-project-takari-plugin-testing-2.1.0/takari-plugin- > testing/src/main/java/io/takari/maven/testing/executor/Embedded3xLauncher. > java > takari-plugin-testing-project-takari-plugin-testing-2.1.0/takari-plugin- > testing/src/main/java/io/takari/maven/testing/executor/ForkedLauncher.java > takari-plugin-testing-project-takari-plugin-testing-2.1.0/takari-plugin- > testing/src/main/java/io/takari/maven/testing/executor/LauncherException.java > takari-plugin-testing-project-takari-plugin-testing-2.1.0/takari-plugin- > testing/src/main/java/io/takari/maven/testing/executor/MavenLauncher.java Included ASL 2.0 license and set the license tag to 'EPL and ASL 2.0'. The license is included as additional source because the upstream is known to refuse including license in the source tree. (Same upstream as commented by Mikolaj in https://bugzilla.redhat.com/show_bug.cgi?id=1200768#c4) Spec URL: https://msimacek.fedorapeople.org/takari-plugin-testing.spec SRPM URL: https://msimacek.fedorapeople.org/takari-plugin-testing-2.1.0-2.fc21.src.rpm > > [?]: Package contains no bundled libraries without FPC exception. > maven-plugin-testing-harness > // some of the code was originally copied from > org.apache.maven.plugin.testing.resources.TestResources > //some of the code was originally copied from > org.apache.maven.plugin.testing.AbstractMojoTestCase and > org.apache.maven.plugin.testing.MojoRule > > takari-plugin-testing-project-takari-plugin-testing-2.1.0/takari-plugin- > testing/src/main/java/io/takari/maven/testing/Maven30xRuntime.java > takari-plugin-testing-project-takari-plugin-testing-2.1.0/takari-plugin- > testing/src/main/java/io/takari/maven/testing/TestResources.java takari-plugin-testing is a fork of maven-plugin-testing-harness that extends it's functionality and is supposed to replace it in the future. Both projects have the same upstream. I wouldn't consider it bundling.
APPROVED
Thank you for the review. New Package SCM Request ======================= Package Name: takari-plugin-testing Short Description: Maven plugin testing library Upstream URL: http://takari.io/ Owners: msimacek mizdebsk msrb Branches: f22 InitialCC: java-sig
Git done (by process-git-requests).
takari-plugin-testing-2.1.0-2.fc23 is now available in rawhide.