Bug 1202311 - Present Rx/TX counter with coma separator between thousands on RHV 4.2
Summary: Present Rx/TX counter with coma separator between thousands on RHV 4.2
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: BLL.Network
Version: 3.6.0
Hardware: x86_64
OS: Linux
low
medium
Target Milestone: ovirt-4.2.0
: 4.2.0
Assignee: Ales Musil
QA Contact: Michael Burman
URL:
Whiteboard:
Depends On: Cumulative_RX_TX_Statistics_VDSM_Engine
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-03-16 11:35 UTC by Martin Pavlik
Modified: 2019-04-28 14:00 UTC (History)
11 users (show)

Fixed In Version:
Doc Type: Enhancement
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-02-12 10:12:35 UTC
oVirt Team: Network
Embargoed:
rule-engine: ovirt-4.2+
rule-engine: blocker+
ylavi: planning_ack+
rule-engine: devel_ack+
myakove: testing_ack+


Attachments (Terms of Use)
screenshot1 (65.36 KB, image/png)
2015-03-16 11:35 UTC, Martin Pavlik
no flags Details


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 82967 0 master MERGED webadmin: Add better formatting for Rx and Tx values 2017-10-20 15:46:58 UTC

Description Martin Pavlik 2015-03-16 11:35:38 UTC
Created attachment 1002211 [details]
screenshot1

Description of problem:

It would be nice to have interface Rx/Tx counters displayed in more human readable fashion. It is a inconvenient to read for example 90TB displayed in bytes. It would be nice to have intelligent switching of units. For example when total traffic on interface reaches 1,000,000 bytes to switch unit to MB etc...


Actual results:
RX/TX counters displayed in Bytes

Expected results:
Intelligent switching of Rx/Tx units based on how big is the displayed number

Additional info:

Comment 1 Lior Vernia 2015-03-16 12:03:33 UTC
I contemplated this while implementing but wasn't sure this was the right thing to do. My main issue was as follows: one of the customer tickets on the original BZ needed a way to see if an interface is even wired properly, which could easily be seen by increasing total RX/TX statistics. If we display them "intelligently", however, small increments will no longer be visible.

One thing I can think about that will allow for both is a button users could toggle and choose between "precise" or "human-readable" format. I don't know where this button should be located and how it should be designed.

There might be other possible solutions, tagging with "UserExperience".

Assuming we do find a plausible solution, I think this would be an easy win and something we'd want to implement with high priority.

Comment 2 Martin Pavlik 2015-03-16 13:48:28 UTC
How about "tooltip"? Display the units in human readable format and on mouse hover it would display the precise value in bytes?

Comment 3 Lior Vernia 2015-03-16 14:04:08 UTC
With a tooltip there'd be the issue of discoverability - would users guess that they could see the exact value by hovering?

Comment 5 Liz 2015-04-10 20:42:09 UTC
@Lior, I think your suggestion of a toggle is a great direction for this request. It's not overwhelming with respect to visual additions. How about the use of radio buttons to toggle between the views? I was also thinking a lot about terminology and something I've come up with that I wanted to get your thoughts on was "Rounded Units" vs. "Granular Units". Let me know what you think!

Thanks,
Liz

Comment 6 Lior Vernia 2015-04-13 17:24:33 UTC
I would name the "Rounded Units" "Human-readable" instead - I think that's what people are used to from Linux utilities.

"Granular" might be replaced by a simpler word - "Exact" maybe?

I'm also not sure about where to place this radio button - top right corner of the subtab?

Comment 7 Liz 2015-04-14 20:08:10 UTC
@Lior - If these terms are well known to users then I would say we should stick with them. Whatever would make it easier to understand! Your suggested placement makes sense. I think the toggle should remain close to the table rather than be associated with the page. Just mentioning this incase we add any fields on top of the table in the future.

Thanks,
Liz

Comment 8 Barak 2015-06-11 12:20:09 UTC
this bug Wasn't picked up in the weekathon , moving to 4.0

Comment 9 Dan Kenigsberg 2017-10-10 18:03:37 UTC
The least-significant digits should not be hidden, as they are the only ones which change between screen refreshes.

To improve readability I suggest to use thousand separator (in en_US it is the coma character, but IIRC in Czech it is the dot).

Comment 10 Red Hat Bugzilla Rules Engine 2017-10-10 18:03:45 UTC
This request has been proposed for two releases. This is invalid flag usage. The ovirt-future release flag has been cleared. If you wish to change the release flag, you must clear one release flag and then set the other release flag to ?.

Comment 11 Greg Sheremeta 2017-10-19 14:02:34 UTC
(In reply to Dan Kenigsberg from comment #9)
> To improve readability I suggest to use thousand separator (in en_US it is
> the coma character, but IIRC in Czech it is the dot).

You probably want to use http://www.gwtproject.org/javadoc/latest/com/google/gwt/i18n/client/NumberFormat.html#getDecimalFormat--

Comment 12 Michael Burman 2018-02-08 09:50:26 UTC
From my point of view, this is not a RFE, it is a bug fix.
On older versions such as - 3.6/4.0/4.1 we always had the coma separator between thousands, this is not something new. 

The original request was to implement shorten numbers to MB/GB/TB and such.

The coma separator between thousands was missing only when the new 4.2 UI was introduced and this bug fixing this glitch.

Verified on - 4.2.1.6-0.1.el7

Comment 13 Red Hat Bugzilla Rules Engine 2018-02-08 09:50:35 UTC
This bug report has Keywords: Regression or TestBlocker.
Since no regressions or test blockers are allowed between releases, it is also being identified as a blocker for this release. Please resolve ASAP.

Comment 14 Sandro Bonazzola 2018-02-12 10:12:35 UTC
This bugzilla is included in oVirt 4.2.0 release, published on Dec 20th 2017.

Since the problem described in this bug report should be
resolved in oVirt 4.2.0 release, published on Dec 20th 2017, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.


Note You need to log in before you can comment on or make changes to this bug.