Spec URL: https://raw.githubusercontent.com/hroncok/SPECS/master/python-cligj.spec SRPM URL: https://churchyard.fedorapeople.org/SRPMS/python-cligj-0.1.0-1.fc21.src.rpm Description: Common arguments and options for GeoJSON processing commands, using Click. Fedora Account System Username: churchyard
Hi, some preliminary remarks : - build fails in mock due to: ImportError: No module named setuptools. Please add setuptools as BR - upstream provides the license text (sadly not in the tarballs), please add it to your source: https://raw.githubusercontent.com/mapbox/cligj/master/LICENSE - Please add a / where needed in the %files section. See https://fedoraproject.org/wiki/Packaging:Python#Files_to_include
Spec URL: https://raw.githubusercontent.com/hroncok/SPECS/master/python-cligj.spec SRPM URL: https://churchyard.fedorapeople.org/SRPMS/python-cligj-0.1.0-1.fc21.src.rpm (In reply to Julien Enselme from comment #1) > Hi, > > some preliminary remarks : > > - build fails in mock due to: ImportError: No module named setuptools. > Please add setuptools as BR Done. > - upstream provides the license text (sadly not in the tarballs), please add > it to your source: > https://raw.githubusercontent.com/mapbox/cligj/master/LICENSE Done, with url containing version/tag > - Please add a / where needed in the %files section. See > https://fedoraproject.org/wiki/Packaging:Python#Files_to_include I've read that and I don't understand why would I need to add /, could you please explain it to me or qute the exact sentence form the guidelines you are referring to? Thanks for the hints.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [X]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [X]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 4 files have unknown license. Detailed output of licensecheck in /tmp/1203700-python-cligj/licensecheck.txt [X]: License file installed when any subpackage combination is installed. [X]: Package contains no bundled libraries without FPC exception. [X]: Changelog in prescribed format. [X]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [X]: Package uses nothing in %doc for runtime. [X]: Package consistently uses macros (instead of hard-coded directory names). [X]: Package is named according to the Package Naming Guidelines. [X]: Package does not generate any conflict. [X]: Package obeys FHS, except libexecdir and /usr/target. [X]: If the package is a rename of another package, proper Obsoletes and Provides are present. [X]: Requires correct, justified where necessary. [X]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [X]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 2 files. [-]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [X]: Python eggs must not download any dependencies during the build process. [X]: A package which is used by another package via an egg interface should provide egg info. [X]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [X]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [X]: Final provides and requires are sane (see attachments). [X]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python3-cligj [X]: Package functions as described. [X]: Latest version is packaged. [X]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [X]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [X]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python-cligj-0.1.0-1.fc21.noarch.rpm python3-cligj-0.1.0-1.fc21.noarch.rpm python-cligj-0.1.0-1.fc21.src.rpm python-cligj.noarch: W: spelling-error Summary(en_US) params -> paras, prams, para's python3-cligj.noarch: W: spelling-error Summary(en_US) params -> paras, prams, para's python-cligj.src: W: spelling-error Summary(en_US) params -> paras, prams, para's 3 packages and 0 specfiles checked; 0 errors, 3 warnings. Rpmlint (installed packages) ---------------------------- python-cligj.noarch: W: spelling-error Summary(en_US) params -> paras, prams, para's python3-cligj.noarch: W: spelling-error Summary(en_US) params -> paras, prams, para's 2 packages and 0 specfiles checked; 0 errors, 2 warnings. Requires -------- python-cligj (rpmlib, GLIBC filtered): python(abi) python-click python3-cligj (rpmlib, GLIBC filtered): python(abi) python3-click Provides -------- python-cligj: python-cligj python3-cligj: python3-cligj Source checksums ---------------- https://pypi.python.org/packages/source/c/cligj/cligj-0.1.0.tar.gz : CHECKSUM(SHA256) this package : b2a8fe0a5c273a5ea58540be6fc8823c44aa7b01b6c76a87f62ff15c41daebd5 CHECKSUM(SHA256) upstream package : b2a8fe0a5c273a5ea58540be6fc8823c44aa7b01b6c76a87f62ff15c41daebd5 https://raw.githubusercontent.com/mapbox/cligj/0.1.0/LICENSE : CHECKSUM(SHA256) this package : 5902d716544ddf9a34849b345c391abaf7c21ca16ed22706d6ac2f5503712594 CHECKSUM(SHA256) upstream package : 5902d716544ddf9a34849b345c391abaf7c21ca16ed22706d6ac2f5503712594 Generated by fedora-review 0.5.3 (bcf15e3) last change: 2015-05-04 Command line :/usr/bin/fedora-review -b 1203700 Buildroot used: fedora-21-x86_64 Active plugins: Python, Generic, Shell-api Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6 According to https://fedoraproject.org/wiki/Packaging:Python#Files_to_include you can use: %files %{python2_sitelib}/foo/ or %files %dir %{python2_sitelib}/foo (to add the directory but not the files it contains) %{python2_sitelib}/foo/*
(In reply to Julien Enselme from comment #3) > According to > https://fedoraproject.org/wiki/Packaging:Python#Files_to_include you can use: > %files > %{python2_sitelib}/foo/ > > or > > %files > %dir %{python2_sitelib}/foo (to add the directory but not the files it > contains) > %{python2_sitelib}/foo/* Could you please point me to an exact location where this is written? I cannot see such rule. The link you've provided is too generic, please quote the sentence that says this is a thing.
I'm pretty sure the trailing slash is just a convention (one that I use as well) and not strictly a requirement. It does allow rpm to complain if the item is no longer a directory for whatever reason, and I do think it helps with clarity.
My example comes from the next section: https://fedoraproject.org/wiki/Packaging:Python#Byte_compiling (sorry). I did some digging and it appears that I was wrong. In your spec, for instance, you use %{python2_sitelib}/%{pypi_name} to add the /usr/lib/python2.7/site-packages/cligj directory. I always thought reading that document https://fedoraproject.org/wiki/How_to_create_an_RPM_package#.25files_basics and more specifically : " To include a single directory: %{_datadir}/%{name}/ " that the trailing / was compulsory when adding a directory. If it was omitted I guessed something bad would happend. But according to http://www.rpm.org/max-rpm/s1-rpm-inside-files-list-directives.html (see the 'The %dir Directive' section) that the directory and its content gets correctly added. I was also not able to find anything that would indicate that %{python2_sitelib}/%{pypi_name} is wrong. I still thinks that the trailing / makes the SPEC clearer (but that just me). Sorry to have bothered you with something wrong (at least I have learned something). Approved! @Orion: indeed. I was typing my reply when you submitted yours.
Thanks for the review. What Orion said makes sense.
New Package SCM Request ======================= Package Name: python-cligj Short Description: Click params for GeoJSON CLI Upstream URL: https://github.com/mapbox/cligj Owners: churchyard Branches: f21 f22
Git done (by process-git-requests).
python-cligj-0.1.0-1.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/python-cligj-0.1.0-1.fc22
python-cligj-0.1.0-1.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/python-cligj-0.1.0-1.fc21
python-cligj-0.1.0-1.fc22 has been pushed to the Fedora 22 testing repository.
python-cligj-0.1.0-1.fc21 has been pushed to the Fedora 21 stable repository.
python-cligj-0.1.0-1.fc22 has been pushed to the Fedora 22 stable repository.