Spec URL: https://raw.githubusercontent.com/hroncok/SPECS/master/python-Fiona.spec SRPM URL: https://churchyard.fedorapeople.org/SRPMS/python-Fiona-1.5.0-1.fc21.src.rpm Description: Fiona is OGR's neat, nimble, no-nonsense API for Python programmers. Fedora Account System Username: churchyard
Build in mock fails during tests because of "ImportError: No module named six". The six module is required according to https://github.com/Toblerity/Fiona/blob/master/setup.py#L129. Can you please add it as BuildRequire and Require.
Spec URL: https://raw.githubusercontent.com/hroncok/SPECS/master/python-Fiona.spec SRPM URL: https://churchyard.fedorapeople.org/SRPMS/python-Fiona-1.5.0-1.fc21.src.rpm Done, also added pytest and ogrinfo binary. I've tried a rawhide mock build after the change and it works.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Permissions on files are set properly. Note: See rpmlint output See: http://fedoraproject.org/wiki/Packaging/Guidelines#FilePermissions - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. Note: License file LICENSE.txt is marked as %doc instead of %license See: http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text ===== MUST items ===== C/C++: [X]: Package does not contain kernel modules. [X]: Package contains no static executables. [X]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [X]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [X]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 92 files have unknown license. Detailed output of licensecheck in /tmp/1203761-python-Fiona/licensecheck.txt [X]: License file installed when any subpackage combination is installed. [X]: %build honors applicable compiler flags or justifies otherwise. [X]: Package contains no bundled libraries without FPC exception. [X]: Changelog in prescribed format. [X]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [X]: Package uses nothing in %doc for runtime. [X]: Package consistently uses macros (instead of hard-coded directory names). [X]: Package is named according to the Package Naming Guidelines. [X]: Package does not generate any conflict. [X]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [X]: Requires correct, justified where necessary. [X]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [-]: Useful -debuginfo package or justification otherwise. [X]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 184320 bytes in 18 files. [X]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [X]: Python eggs must not download any dependencies during the build process. [X]: A package which is used by another package via an egg interface should provide egg info. [X]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [X]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [X]: Final provides and requires are sane (see attachments). [ ]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python3-Fiona [X]: Package functions as described. [!]: Latest version is packaged. [X]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [X]: Package should compile and build into binary rpms on all supported architectures. [X]: %check is present and all tests pass. [X]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python-Fiona-1.5.0-1.fc21.x86_64.rpm python3-Fiona-1.5.0-1.fc21.x86_64.rpm python-Fiona-1.5.0-1.fc21.src.rpm python-Fiona.x86_64: E: non-standard-executable-perm /usr/lib64/python2.7/site-packages/fiona/_drivers.so 0775L python-Fiona.x86_64: E: non-standard-executable-perm /usr/lib64/python2.7/site-packages/fiona/ogrext.so 0775L python-Fiona.x86_64: E: non-standard-executable-perm /usr/lib64/python2.7/site-packages/fiona/_err.so 0775L python-Fiona.x86_64: E: non-standard-executable-perm /usr/lib64/python2.7/site-packages/fiona/_transform.so 0775L python-Fiona.x86_64: E: non-standard-executable-perm /usr/lib64/python2.7/site-packages/fiona/_geometry.so 0775L python3-Fiona.x86_64: E: non-standard-executable-perm /usr/lib64/python3.4/site-packages/fiona/ogrext.cpython-34m.so 0775L python3-Fiona.x86_64: E: non-standard-executable-perm /usr/lib64/python3.4/site-packages/fiona/_geometry.cpython-34m.so 0775L python3-Fiona.x86_64: E: non-standard-executable-perm /usr/lib64/python3.4/site-packages/fiona/_err.cpython-34m.so 0775L python3-Fiona.x86_64: E: non-standard-executable-perm /usr/lib64/python3.4/site-packages/fiona/_drivers.cpython-34m.so 0775L python3-Fiona.x86_64: E: non-standard-executable-perm /usr/lib64/python3.4/site-packages/fiona/_transform.cpython-34m.so 0775L python3-Fiona.x86_64: W: no-manual-page-for-binary fio 3 packages and 0 specfiles checked; 10 errors, 1 warnings. Rpmlint (debuginfo) ------------------- Checking: python-Fiona-debuginfo-1.5.0-1.fc21.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- python-Fiona.x86_64: E: non-standard-executable-perm /usr/lib64/python2.7/site-packages/fiona/_drivers.so 0775L python-Fiona.x86_64: E: non-standard-executable-perm /usr/lib64/python2.7/site-packages/fiona/ogrext.so 0775L python-Fiona.x86_64: E: non-standard-executable-perm /usr/lib64/python2.7/site-packages/fiona/_err.so 0775L python-Fiona.x86_64: E: non-standard-executable-perm /usr/lib64/python2.7/site-packages/fiona/_transform.so 0775L python-Fiona.x86_64: E: non-standard-executable-perm /usr/lib64/python2.7/site-packages/fiona/_geometry.so 0775L python3-Fiona.x86_64: E: non-standard-executable-perm /usr/lib64/python3.4/site-packages/fiona/ogrext.cpython-34m.so 0775L python3-Fiona.x86_64: E: non-standard-executable-perm /usr/lib64/python3.4/site-packages/fiona/_geometry.cpython-34m.so 0775L python3-Fiona.x86_64: E: non-standard-executable-perm /usr/lib64/python3.4/site-packages/fiona/_err.cpython-34m.so 0775L python3-Fiona.x86_64: E: non-standard-executable-perm /usr/lib64/python3.4/site-packages/fiona/_drivers.cpython-34m.so 0775L python3-Fiona.x86_64: E: non-standard-executable-perm /usr/lib64/python3.4/site-packages/fiona/_transform.cpython-34m.so 0775L python3-Fiona.x86_64: W: no-manual-page-for-binary fio 3 packages and 0 specfiles checked; 10 errors, 1 warnings. Requires -------- python-Fiona (rpmlib, GLIBC filtered): libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgdal.so.1()(64bit) libm.so.6()(64bit) libpthread.so.0()(64bit) libpython2.7.so.1.0()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) python(abi) python-cligj python-six rtld(GNU_HASH) python3-Fiona (rpmlib, GLIBC filtered): /usr/bin/python3 libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgdal.so.1()(64bit) libm.so.6()(64bit) libpthread.so.0()(64bit) libpython3.4m.so.1.0()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) python(abi) python3-cligj python3-six rtld(GNU_HASH) Provides -------- python-Fiona: python-Fiona python-Fiona(x86-64) python-fiona(x86-64) python3-Fiona: python3-Fiona python3-Fiona(x86-64) python3-fiona(x86-64) Unversioned so-files -------------------- python-Fiona: /usr/lib64/python2.7/site-packages/fiona/_drivers.so python-Fiona: /usr/lib64/python2.7/site-packages/fiona/_err.so python-Fiona: /usr/lib64/python2.7/site-packages/fiona/_geometry.so python-Fiona: /usr/lib64/python2.7/site-packages/fiona/_transform.so python-Fiona: /usr/lib64/python2.7/site-packages/fiona/ogrext.so python3-Fiona: /usr/lib64/python3.4/site-packages/fiona/_drivers.cpython-34m.so python3-Fiona: /usr/lib64/python3.4/site-packages/fiona/_err.cpython-34m.so python3-Fiona: /usr/lib64/python3.4/site-packages/fiona/_geometry.cpython-34m.so python3-Fiona: /usr/lib64/python3.4/site-packages/fiona/_transform.cpython-34m.so python3-Fiona: /usr/lib64/python3.4/site-packages/fiona/ogrext.cpython-34m.so Source checksums ---------------- https://pypi.python.org/packages/source/F/Fiona/Fiona-1.5.0.tar.gz : CHECKSUM(SHA256) this package : 600540bc2dc5fed258f64090cde48a552f377feee39974a18224441e5b3aa23f CHECKSUM(SHA256) upstream package : 600540bc2dc5fed258f64090cde48a552f377feee39974a18224441e5b3aa23f https://github.com/Toblerity/Fiona/archive/1.5.0.tar.gz : CHECKSUM(SHA256) this package : b896c6a710853719e5f5e5a0ac50f6574b2e305ca3bbb3b9174b739ec2f18bf1 CHECKSUM(SHA256) upstream package : b896c6a710853719e5f5e5a0ac50f6574b2e305ca3bbb3b9174b739ec2f18bf1 Generated by fedora-review 0.5.3 (bcf15e3) last change: 2015-05-04 Command line :/usr/bin/fedora-review -b 1203761 Buildroot used: fedora-21-x86_64 Active plugins: Python, Generic, Shell-api, C/C++ Disabled plugins: Java, SugarActivity, fonts, Haskell, Ocaml, Perl, R, PHP, Ruby Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6 - Please update to 1.5.1: https://pypi.python.org/pypi/Fiona/1.5.1 - Use the %license macro to include the license: https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/LicensingGuidelines#License_Text - Fix persimissions
Spec URL: https://raw.githubusercontent.com/hroncok/SPECS/master/python-Fiona.spec SRPM URL: https://churchyard.fedorapeople.org/SRPMS/python-Fiona-1.5.1-1.fc21.src.rpm Fixed.
Looks good. Approved!
New Package SCM Request ======================= Package Name: python-Fiona Short Description: Fiona reads and writes spatial data files Upstream URL: http://github.com/Toblerity/Fiona Owners: churchyard Branches: f21 f22 InitialCC: python-sig
Thanks Julien, feel free to assign any review directly to me.
Git done (by process-git-requests).
python-Fiona-1.5.1-1.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/python-Fiona-1.5.1-1.fc22
python-Fiona-1.5.1-1.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/python-Fiona-1.5.1-1.fc21
python-Fiona-1.5.1-1.fc22 has been pushed to the Fedora 22 testing repository.
python-Fiona-1.5.1-1.fc22 has been pushed to the Fedora 22 stable repository.
python-Fiona-1.5.1-1.fc21 has been pushed to the Fedora 21 stable repository.