Description of problem: Trash translator is just above posix.If it is on and unlink happens, then trash translator redirect unlink call to rename. So the CTR will record wrong information about the file, i.e trash translator should update CTR the file has been removed Version-Release number of selected component (if applicable): mainline How reproducible: Everytime Steps to Reproduce: 1. 2. 3. Actual results: Expected results: Additional info:
Also , CTR does not require to track contents of trash-directory
REVIEW: http://review.gluster.org/9989 (features/trash : Notify CTR translator if an unlink happens to a file) posted (#1) for review on master by jiffin tony Thottan (jthottan)
REVIEW: http://review.gluster.org/9989 (features/trash : Notify CTR translator if an unlink happens to a file) posted (#2) for review on master by Joseph Fernandes (josferna)
REVIEW: http://review.gluster.org/9989 (features/trash : Notify CTR translator if an unlink happens to a file) posted (#3) for review on master by Joseph Fernandes (josferna)
REVIEW: http://review.gluster.org/9989 (features/trash : Notify CTR translator if an unlink happens to a file) posted (#4) for review on master by Joseph Fernandes (josferna)
REVIEW: http://review.gluster.org/9989 (features/trash : Notify CTR translator if an unlink happens to a file) posted (#5) for review on master by Anoop C S (achiraya)
REVIEW: http://review.gluster.org/9989 (features/trash : Notify CTR translator if an unlink happens to a file) posted (#6) for review on master by jiffin tony Thottan (jthottan)
REVIEW: http://review.gluster.org/9989 (features/trash : Notify CTR translator if an unlink happens to a file) posted (#7) for review on master by jiffin tony Thottan (jthottan)
REVIEW: http://review.gluster.org/9989 (features/trash : Notify CTR translator if an unlink happens to a file) posted (#8) for review on master by jiffin tony Thottan (jthottan)
REVIEW: http://review.gluster.org/9989 (features/trash : Notify CTR translator if an unlink happens to a file) posted (#9) for review on master by jiffin tony Thottan (jthottan)
REVIEW: http://review.gluster.org/9989 (features/trash : Notify CTR translator if an unlink happens to a file) posted (#10) for review on master by jiffin tony Thottan (jthottan)
REVIEW: http://review.gluster.org/9989 (features/trash : Notify CTR translator if an unlink happens to a file) posted (#11) for review on master by Anoop C S (achiraya)
REVIEW: http://review.gluster.org/9989 (features/trash : Notify CTR translator if an unlink happens to a file) posted (#12) for review on master by Anoop C S (achiraya)
COMMIT: http://review.gluster.org/9989 committed in master by Vijay Bellur (vbellur) ------ commit b72bc58ecc108a2fddbdb6f606cd86a57ca5a68f Author: Jiffin Tony Thottan <jthottan> Date: Wed Mar 25 15:04:19 2015 +0530 features/trash : Notify CTR translator if an unlink happens to a file This implementation is same as the posix_unlink_cbk() where CTR sends a request during a unlink to send the number of links to the inode and posix obliges sending it using the unwind xdata dict. For Trash xlator a unlink is stat + mkdir(if parent is not present) + rename. And hence this is handled in trash_unlink_rename_cbk(). Change-Id: I402e83567b88e3c9fe171379693c82937af567f9 BUG: 1205545 Signed-off-by: Jiffin Tony Thottan <jthottan> Signed-off-by: Joseph Fernandes <josferna> Signed-off-by: Anoop C S <achiraya> Reviewed-on: http://review.gluster.org/9989 Tested-by: NetBSD Build System Tested-by: Joseph Fernandes Reviewed-by: Joseph Fernandes Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Niels de Vos <ndevos> Reviewed-by: Vijay Bellur <vbellur>
This change should not be in "ON_QA", the patch posted for this bug is only available in the master branch and not in a release yet. Bug 1218032 was used for backporting, and that bug is now CLOSED because the fix is in a released version.
Fix for this BZ is already present in a GlusterFS release. You can find clone of this BZ, fixed in a GlusterFS release and closed. Hence closing this mainline BZ as well.