+++ This bug was initially created as a clone of Bug #1205545 +++ Description of problem: Trash translator is just above posix.If it is on and unlink happens, then trash translator redirect unlink call to rename. So the CTR will record wrong information about the file, i.e trash translator should update CTR the file has been removed Version-Release number of selected component (if applicable): mainline How reproducible: Everytime Steps to Reproduce: 1. 2. 3. Actual results: Expected results: Additional info: --- Additional comment from Jiffin on 2015-03-25 05:14:39 EDT --- Also , CTR does not require to track contents of trash-directory --- Additional comment from Anand Avati on 2015-03-25 05:40:32 EDT --- REVIEW: http://review.gluster.org/9989 (features/trash : Notify CTR translator if an unlink happens to a file) posted (#1) for review on master by jiffin tony Thottan (jthottan) --- Additional comment from Anand Avati on 2015-03-26 05:07:17 EDT --- REVIEW: http://review.gluster.org/9989 (features/trash : Notify CTR translator if an unlink happens to a file) posted (#2) for review on master by Joseph Fernandes (josferna) --- Additional comment from Anand Avati on 2015-03-26 05:09:55 EDT --- REVIEW: http://review.gluster.org/9989 (features/trash : Notify CTR translator if an unlink happens to a file) posted (#3) for review on master by Joseph Fernandes (josferna) --- Additional comment from Anand Avati on 2015-03-26 11:00:19 EDT --- REVIEW: http://review.gluster.org/9989 (features/trash : Notify CTR translator if an unlink happens to a file) posted (#4) for review on master by Joseph Fernandes (josferna) --- Additional comment from Anand Avati on 2015-03-28 03:33:49 EDT --- REVIEW: http://review.gluster.org/9989 (features/trash : Notify CTR translator if an unlink happens to a file) posted (#5) for review on master by Anoop C S (achiraya) --- Additional comment from Anand Avati on 2015-04-06 02:49:20 EDT --- REVIEW: http://review.gluster.org/9989 (features/trash : Notify CTR translator if an unlink happens to a file) posted (#6) for review on master by jiffin tony Thottan (jthottan) --- Additional comment from Anand Avati on 2015-04-06 04:37:31 EDT --- REVIEW: http://review.gluster.org/9989 (features/trash : Notify CTR translator if an unlink happens to a file) posted (#7) for review on master by jiffin tony Thottan (jthottan) --- Additional comment from Anand Avati on 2015-04-06 06:46:58 EDT --- REVIEW: http://review.gluster.org/9989 (features/trash : Notify CTR translator if an unlink happens to a file) posted (#8) for review on master by jiffin tony Thottan (jthottan) --- Additional comment from Anand Avati on 2015-04-07 00:37:34 EDT --- REVIEW: http://review.gluster.org/9989 (features/trash : Notify CTR translator if an unlink happens to a file) posted (#9) for review on master by jiffin tony Thottan (jthottan) --- Additional comment from Anand Avati on 2015-04-07 07:14:29 EDT --- REVIEW: http://review.gluster.org/9989 (features/trash : Notify CTR translator if an unlink happens to a file) posted (#10) for review on master by jiffin tony Thottan (jthottan) --- Additional comment from Anand Avati on 2015-04-23 05:13:04 EDT --- REVIEW: http://review.gluster.org/9989 (features/trash : Notify CTR translator if an unlink happens to a file) posted (#11) for review on master by Anoop C S (achiraya) --- Additional comment from Anand Avati on 2015-04-23 05:28:46 EDT --- REVIEW: http://review.gluster.org/9989 (features/trash : Notify CTR translator if an unlink happens to a file) posted (#12) for review on master by Anoop C S (achiraya) --- Additional comment from Anand Avati on 2015-04-24 14:07:28 EDT --- COMMIT: http://review.gluster.org/9989 committed in master by Vijay Bellur (vbellur) ------ commit b72bc58ecc108a2fddbdb6f606cd86a57ca5a68f Author: Jiffin Tony Thottan <jthottan> Date: Wed Mar 25 15:04:19 2015 +0530 features/trash : Notify CTR translator if an unlink happens to a file This implementation is same as the posix_unlink_cbk() where CTR sends a request during a unlink to send the number of links to the inode and posix obliges sending it using the unwind xdata dict. For Trash xlator a unlink is stat + mkdir(if parent is not present) + rename. And hence this is handled in trash_unlink_rename_cbk(). Change-Id: I402e83567b88e3c9fe171379693c82937af567f9 BUG: 1205545 Signed-off-by: Jiffin Tony Thottan <jthottan> Signed-off-by: Joseph Fernandes <josferna> Signed-off-by: Anoop C S <achiraya> Reviewed-on: http://review.gluster.org/9989 Tested-by: NetBSD Build System Tested-by: Joseph Fernandes Reviewed-by: Joseph Fernandes Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Niels de Vos <ndevos> Reviewed-by: Vijay Bellur <vbellur>
REVIEW: http://review.gluster.org/10513 (features/trash : Notify CTR translator if an unlink happens to a file) posted (#1) for review on release-3.7 by Anoop C S (achiraya)
COMMIT: http://review.gluster.org/10513 committed in release-3.7 by Vijay Bellur (vbellur) ------ commit c85b7c2c0c7b8b9e576ebd20e7446b9051c733e4 Author: Jiffin Tony Thottan <jthottan> Date: Wed Mar 25 15:04:19 2015 +0530 features/trash : Notify CTR translator if an unlink happens to a file Backport of http://review.gluster.org/#/c/9989/ This implementation is same as the posix_unlink_cbk() where CTR sends a request during a unlink to send the number of links to the inode and posix obliges sending it using the unwind xdata dict. For Trash xlator a unlink is stat + mkdir(if parent is not present) + rename. And hence this is handled in trash_unlink_rename_cbk(). Change-Id: I402e83567b88e3c9fe171379693c82937af567f9 BUG: 1218032 Signed-off-by: Jiffin Tony Thottan <jthottan> Signed-off-by: Joseph Fernandes <josferna> Signed-off-by: Anoop C S <achiraya> Reviewed-on: http://review.gluster.org/10513 Reviewed-by: Joseph Fernandes Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Dan Lambright <dlambrig> Reviewed-by: Vijay Bellur <vbellur>
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report. glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution. [1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939 [2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user