Bug 1208348 - Build with OpenDBX support. Support for datasets in SQL databases are essential.
Summary: Build with OpenDBX support. Support for datasets in SQL databases are essential.
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora EPEL
Classification: Fedora
Component: opendkim
Version: epel7
Hardware: Unspecified
OS: Linux
unspecified
unspecified
Target Milestone: ---
Assignee: Steve Jenkins
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-04-02 03:51 UTC by George Notaras
Modified: 2015-05-14 01:21 UTC (History)
2 users (show)

Fixed In Version: opendkim-2.10.1-13.el7
Clone Of:
Environment:
Last Closed: 2015-04-18 09:32:13 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
Diff file to allow opendbx spec file to build for EL5, EL6, and EL7 (3.06 KB, patch)
2015-04-02 23:53 UTC, Steve Jenkins
no flags Details | Diff

Description George Notaras 2015-04-02 03:51:07 UTC
Description of problem:

The current build does not support datasets stored in SQL databases.

Please configure with the '--with-odbx' switch.

This requires the existence of the opendbx package, which is not available. However, a source RPM exists in Fedora Rawhide, which can be recompiled for EPEL.

I have successfully rebuilt the fedora rawhide packages of opendbx-1.4.6-3 and opendkim-2.10.1-7 (using the --with-odbx switch) for CentOS 7.

Thisis the output of opendkim -V:

~]$ opendkim -V
opendkim: OpenDKIM Filter v2.10.1
        Compiled with OpenSSL 1.0.1e-fips 11 Feb 2013
        SMFI_VERSION 0x1000001
        libmilter version 1.0.1
        Supported signing algorithms:
                rsa-sha1
                rsa-sha256
        Supported canonicalization algorithms:
                relaxed
                simple
        Active code options:
                USE_DB
                USE_ODBX
        libopendkim 2.10.1:


Additional info:

Please add the much needed support for OpenDBX.

Comment 1 Steve Jenkins 2015-04-02 04:33:42 UTC
Hi, George. Great suggestion.

Looks like opendbx is currently approved for F20, F21, F22, and EL6:

https://admin.fedoraproject.org/pkgdb/package/opendbx/

However it doesn't look like it's been built for EL6. Looks like the last time the maintainer submitted a build was 2012:

http://koji.fedoraproject.org/koji/packageinfo?packageID=12727

I'd prefer to keep OpenDKIM versions in sync for all platforms that haven't reached EOL, so I'm going to add Martin Priesler (the opendbx maintainer) to this bug in the hopes that he might consider also building it for EL5, EL6, and EL7.

I tried some scratch builds with the current SPEC file. EL7 worked, but both EL6 and EL5 choked:

EL5: http://koji.fedoraproject.org/koji/taskinfo?taskID=9397365

EL6: http://koji.fedoraproject.org/koji/taskinfo?taskID=9397377

EL7: http://koji.fedoraproject.org/koji/taskinfo?taskID=9397369

I haven't gone digging yet to see what's causing the failure.

If Martin's not inclined to update them, I'm not sure of the correct procedure to find someone else to do it. But I agree it's definitely something that should be done, and I'm happy to help however possible.

Comment 2 George Notaras 2015-04-02 05:05:14 UTC
Hello Steve and thanks for your quick reply. I will currently use my own builds. Let's hope Martin is interested in looking into this report.

Comment 3 Steve Jenkins 2015-04-02 18:41:58 UTC
It's a small victory, but I've re-packaged including --with-opendbx for all the Fedora builds as of 2.10.1-9:

http://pkgs.fedoraproject.org/cgit/opendkim.git/commit/?id=b30456a57b0abb19d5f120a283f4ff92831ad12d

If we can get opendbx available in the EPEL repos, I'll come back and include it for all builds.

Also taking a peek today to see if I can tinker with the opendbx.spec file enough to get a mockbuild of opendbx working for EL5 and El6. I'll update here as I make progress.

Comment 4 Steve Jenkins 2015-04-02 18:53:39 UTC
OK - so getting it to build on EL6 was as simple as just adding a missing "Group: Development/Libraries" for the package and sub-packages.

EL6: http://koji.fedoraproject.org/koji/taskinfo?taskID=9401099

EL5 initially snagged on a missing build requirement, so I added ncurses-devel as a BuildRequires. That got me farther:

EL5: https://kojipkgs.fedoraproject.org//work/tasks/1132/9401132/build.log

Seeing a lot of I/O error stuff in that build log, but not sure if that's what's fatal.

Anyone got any suggestions?

Comment 5 George Notaras 2015-04-02 21:15:50 UTC
Hello Steve,

I'd focus on the permission error:

/bin/mkdir: cannot create directory `/usr/lib/opendbx': Permission denied

It seems that it tries to install files outside the build root.

In the build log it seems there is no build root environment variable set in the 'make install statement':

make install DESTDIR=

Maybe it should be:

make install DESTDIR=$RPM_BUILD_ROOT

Comment 6 Steve Jenkins 2015-04-02 23:52:12 UTC
Hi, George. Yep. You were on the right track. And all it needed was a "BuildRoot:" line for EL5 to like it.

I cloned the opendbx repo and committed all my changes locally, but I don't have permissions to push changes to a package that I don't maintain.

So I suppose our options are for me to petition to co-maintain the package, or just ask someone with big time privileges to push my changes. I'm thinking the latter will go faster. :)

I'm attaching my diff to the Rawhide spec file above. A spec file patched with that diff will build on all currently support RedHat-based platforms.

Once we get the into the EL5, EL6, and EL7 repos, I'll rebuild OpenDKIM so that --with-obdx is active on all platforms.

Comment 7 Steve Jenkins 2015-04-02 23:53:24 UTC
Created attachment 1010379 [details]
Diff file to allow opendbx spec file to build for EL5, EL6, and EL7

Comment 8 Martin Preisler 2015-04-03 10:43:57 UTC
I already replied to #1208716.

If you have the changes locally just ask to co-maintain in pkgdb and I will approve it.

Comment 9 Steve Jenkins 2015-04-03 14:21:34 UTC
Hi, Martin. Thank you very much!

I've requested admin rights in pgkdb and will gladly commit those changes once it's approved.

Comment 10 Steve Jenkins 2015-04-03 22:16:04 UTC
Updates:

1) Martin generously accepted me as co-maintainer (thanks, Martin)

2) I created a new bug to help me track opendbx builds across all supported platforms:

https://bugzilla.redhat.com/show_bug.cgi?id=1208902

Had some problems with another package's API changing in a way that broke our spec file. Debian maintainer had dealt with it previously, so used his approach to solve. opendbx now building on all six current branches. Watch bug #1208902 which will automatically track submitted builds' status in Bodhi.

3) Martin requested EL7 and EL5 branches, and they are now pending review. It's a holiday weekend, so it probably will be next week until they're approved. Once they are, I'll submit the opendbx builds to those branches.

Comment 11 Steve Jenkins 2015-04-04 18:06:33 UTC
Martin:

EL5 and EL7 branches are now open (hooray!) but I'm not allowed to give myself committ access on them.

https://admin.fedoraproject.org/pkgdb/package/opendbx/

I've got the changes committed locally, so if you can give me commit access for those two branches, I'll push them in. Thx. :)

Comment 12 Martin Preisler 2015-04-04 18:09:48 UTC
Done.

Comment 13 Steve Jenkins 2015-04-04 18:15:25 UTC
Thx, Martin. :)

EL5 and EL7 branches pushed and building now.

Comment 14 Fedora Update System 2015-04-07 05:22:03 UTC
opendkim-2.10.1-12.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/opendkim-2.10.1-12.fc21

Comment 15 Fedora Update System 2015-04-07 05:22:31 UTC
opendkim-2.10.1-12.el5 has been submitted as an update for Fedora EPEL 5.
https://admin.fedoraproject.org/updates/opendkim-2.10.1-12.el5

Comment 16 Fedora Update System 2015-04-07 05:22:59 UTC
opendkim-2.10.1-12.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/opendkim-2.10.1-12.fc20

Comment 17 Fedora Update System 2015-04-07 05:23:25 UTC
opendkim-2.10.1-12.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/opendkim-2.10.1-12.el6

Comment 18 Fedora Update System 2015-04-07 05:23:51 UTC
opendkim-2.10.1-12.fc22 has been submitted as an update for Fedora 22.
https://admin.fedoraproject.org/updates/opendkim-2.10.1-12.fc22

Comment 19 Fedora Update System 2015-04-07 05:24:17 UTC
opendkim-2.10.1-12.el7 has been submitted as an update for Fedora EPEL 7.
https://admin.fedoraproject.org/updates/opendkim-2.10.1-12.el7

Comment 20 Fedora Update System 2015-04-07 17:10:05 UTC
Package opendkim-2.10.1-12.fc22:
* should fix your issue,
* was pushed to the Fedora 22 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing opendkim-2.10.1-12.fc22'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2015-5688/opendkim-2.10.1-12.fc22
then log in and leave karma (feedback).

Comment 21 Fedora Update System 2015-04-08 06:57:06 UTC
Package opendkim-2.10.1-12.fc20:
* should fix your issue,
* was pushed to the Fedora 20 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing opendkim-2.10.1-12.fc20'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2015-5714/opendkim-2.10.1-12.fc20
then log in and leave karma (feedback).

Comment 22 Fedora Update System 2015-04-18 09:32:13 UTC
opendkim-2.10.1-12.fc20 has been pushed to the Fedora 20 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 23 Fedora Update System 2015-04-18 09:45:04 UTC
opendkim-2.10.1-12.fc21 has been pushed to the Fedora 21 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 24 Fedora Update System 2015-04-20 22:05:55 UTC
opendkim-2.10.1-13.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/opendkim-2.10.1-13.fc21

Comment 25 Fedora Update System 2015-04-20 22:06:07 UTC
opendkim-2.10.1-13.el5 has been submitted as an update for Fedora EPEL 5.
https://admin.fedoraproject.org/updates/opendkim-2.10.1-13.el5

Comment 26 Fedora Update System 2015-04-20 22:06:17 UTC
opendkim-2.10.1-13.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/opendkim-2.10.1-13.el6

Comment 27 Fedora Update System 2015-04-20 22:08:35 UTC
opendkim-2.10.1-13.fc22 has been submitted as an update for Fedora 22.
https://admin.fedoraproject.org/updates/opendkim-2.10.1-13.fc22

Comment 28 Fedora Update System 2015-04-20 22:08:47 UTC
opendkim-2.10.1-13.el7 has been submitted as an update for Fedora EPEL 7.
https://admin.fedoraproject.org/updates/opendkim-2.10.1-13.el7

Comment 29 Fedora Update System 2015-04-20 22:08:55 UTC
opendkim-2.10.1-13.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/opendkim-2.10.1-13.fc20

Comment 30 Fedora Update System 2015-04-29 13:08:20 UTC
opendkim-2.10.1-13.fc22 has been pushed to the Fedora 22 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 31 Fedora Update System 2015-05-01 16:44:07 UTC
opendkim-2.10.1-13.fc20 has been pushed to the Fedora 20 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 32 Fedora Update System 2015-05-01 16:54:46 UTC
opendkim-2.10.1-13.fc21 has been pushed to the Fedora 21 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 33 Fedora Update System 2015-05-08 16:40:35 UTC
opendkim-2.10.1-13.el5 has been pushed to the Fedora EPEL 5 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 34 Fedora Update System 2015-05-08 16:40:56 UTC
opendkim-2.10.1-13.el6 has been pushed to the Fedora EPEL 6 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 35 Fedora Update System 2015-05-08 16:41:04 UTC
opendkim-2.10.1-13.el7 has been pushed to the Fedora EPEL 7 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 36 George Notaras 2015-05-14 01:21:38 UTC
Hello Steve,

I'm sorry for my late reply, but during the last weeks it was impossible for me to stop using my own RPM and test this release. I have currently deployed the EPEL packages of opendkim and opendbx and have successfully used MySQL datasets.

Will report back if I notice anything unusual.

Thanks for your work and again I'm sorry for my late feedback.

Kind Regards,
George


Note You need to log in before you can comment on or make changes to this bug.