Right now this is just a placeholder/TODO. Spec URL: TBD SRPM URL: TBD Description: Consul is a tool for service discovery and configuration. Consul is distributed, highly available, and extremely scalable. Fedora Account System Username: tstclair
$ gofed github2spec hashicorp consul deec3bef9eb7ec368c828363cafeb31c4bccacc5 Repo URL: https://github.com/hashicorp/consul (1/4) Checking if the package already exists in PkgDB (2/4) Downloading tarball (3/4) Creating spec file (4/4) Discovering golang dependencies Class: github.com/armon/circbuf (golang-github-armon-circbuf) PkgDB=False Class: github.com/armon/go-metrics (golang-github-armon-go-metrics) PkgDB=False Class: github.com/armon/go-radix (golang-github-armon-go-radix) PkgDB=False Class: github.com/armon/gomdb (golang-github-armon-gomdb) PkgDB=False Class: github.com/hashicorp/go-checkpoint (golang-github-hashicorp-go-checkpoint) PkgDB=False Class: github.com/hashicorp/go-msgpack (golang-github-hashicorp-go-msgpack) PkgDB=False Class: github.com/hashicorp/go-syslog (golang-github-hashicorp-go-syslog) PkgDB=False Class: github.com/hashicorp/golang-lru (golang-github-hashicorp-golang-lru) PkgDB=False Class: github.com/hashicorp/hcl (golang-github-hashicorp-hcl) PkgDB=False Class: github.com/hashicorp/logutils (golang-github-hashicorp-logutils) PkgDB=False Class: github.com/hashicorp/memberlist (golang-github-hashicorp-memberlist) PkgDB=False Class: github.com/hashicorp/raft (golang-github-hashicorp-raft) PkgDB=False Class: github.com/hashicorp/raft-mdb (golang-github-hashicorp-raft-mdb) PkgDB=False Class: github.com/hashicorp/scada-client (golang-github-hashicorp-scada-client) PkgDB=False Class: github.com/hashicorp/serf (golang-github-hashicorp-serf) PkgDB=False Class: github.com/hashicorp/yamux (golang-github-hashicorp-yamux) PkgDB=False Class: github.com/inconshreveable/muxado (golang-github-inconshreveable-muxado) PkgDB=False Class: github.com/ryanuber/columnize (golang-github-ryanuber-columnize) PkgDB=False So about 18 new packages to fedora for the moment.
Spec URL: https://jchaloup.fedorapeople.org/reviews/consul/consul.spec SRPM URL: https://jchaloup.fedorapeople.org/reviews/consul/consul-0-0.1.git5079177.fc20.src.rpm Description: Tool for service discovery, monitoring and configuration http://www.consul.io Fedora Account System Username: jchaloup $ rpmlint /home/jchaloup/rpmbuild/SRPMS/consul-0-0.1.git5079177.fc20.src.rpm /home/jchaloup/rpmbuild/RPMS/x86_64/consul-0-0.1.git5079177.fc20.x86_64.rpm /home/jchaloup/rpmbuild/RPMS/noarch/golang-github-hashicorp-consul-devel-0-0.1.git5079177.fc20.noarch.rpm /home/jchaloup/rpmbuild/RPMS/x86_64/consul-debuginfo-0-0.1.git5079177.fc20.x86_64.rpm consul.x86_64: W: no-manual-page-for-binary consul golang-github-hashicorp-consul-devel.noarch: W: pem-certificate /usr/share/gocode/src/github.com/hashicorp/consul/test/key/ssl-cert-snakeoil.pem consul-debuginfo.x86_64: E: debuginfo-without-sources 4 packages and 0 specfiles checked; 1 errors, 2 warnings.
Koji: the package depends on 23 other packages not packaged in Fedora. Locally it builds fine. Notes: E: debuginfo-without-sources, this is bz1184221 related. This issue is fixed in f23 and f22. f21 and f20 are not. rpmlint is run on my f20 so for rawhide we should be fine. There is no man page and ssl-cert-snakeoil.pem is part of a test.
The list: https://bugzilla.redhat.com/buglist.cgi?quicksearch=1211985%2C%201211990%2C%201212004%2C%201212031%2C%201212044%2C%201212046%2C%201212047%2C%201212048%2C%201212049%2C%201212056%2C%201212059%2C%201212065%2C%201212068%2C%201212075%2C%201212099%2C%201212105%2C%201212111%2C%201212113%2C%201212116%2C%201212119%2C%201212124%2C%201212346%2C%201212350&list_id=3402216 Timothy, can you check consul once it gets into rawhide?
what's left?
Just review of this package, all its dependencies are already built.
Any plans to build it for RHEL7 as well? If not it could be built in epel7.
List of dependencies in deps directory.
Newer koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=10389523 Spec URL: https://jchaloup.fedorapeople.org/reviews/consul/consul.spec SRPM URL: https://jchaloup.fedorapeople.org/reviews/consul/consul-0-0.1.git5079177.fc20.src.rpm rpmlint on koji build: $ rpmlint consul-0-0.1.git5079177.fc24.x86_64.rpm consul-debuginfo-0-0.1.git5079177.fc24.x86_64.rpm golang-github-hashicorp-consul-devel-0-0.1.git5079177.fc24.noarch.rpm consul.x86_64: W: no-manual-page-for-binary consul 3 packages and 0 specfiles checked; 0 errors, 1 warnings.
Overall Result ============== The .spec file looks sane, the srpm builds fine locally -> setting review flag. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - The part about BuildArch do not need to have a %if Can you fix that on import. Otherwise, the package is ok ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: Rpmlint messages were already discussed by Jan. [x]: Spec file according to URL is the same as in SRPM.
New Package SCM Request ======================= Package Name: consul Short Description: Tool for service discovery, monitoring and configuration http://www.consul.io Upstream URL: https://github.com/hashicorp/consul Owners: jchaloup Branches: f23 f22 f21 el6 InitialCC: golang-sig
The git processing script doesn't see branto in the packager group. (which is needed to approve reviews). Are you in the packager group under another name/email?
Re-setting fedora-review flag.
@Kevin: I just checked my fas account and I am in the packager group and I use the aforementioned e-mail there. I'm not sure what went wrong in the script though. Maybe a network fluke?
Git done (by process-git-requests).
consul-0-0.1.git5079177.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/consul-0-0.1.git5079177.fc22
consul-0-0.1.git5079177.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/consul-0-0.1.git5079177.fc21
consul-0-0.1.git5079177.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/consul-0-0.1.git5079177.el6
consul-0-0.1.git5079177.el6 has been pushed to the Fedora EPEL 6 testing repository.
@jan There are no official plans for EL7, I'm certain you would get almost instant adoption if it was on epel7. May want to check with others 1st.
consul-0-0.1.git5079177.fc21 has been pushed to the Fedora 21 stable repository.
consul-0-0.1.git5079177.fc22 has been pushed to the Fedora 22 stable repository.
consul-0-0.1.git5079177.el6 has been pushed to the Fedora EPEL 6 stable repository.