Bug 1212111 - Review Request: golang-github-hashicorp-yamux- Golang connection multiplexing library
Summary: Review Request: golang-github-hashicorp-yamux- Golang connection multiplexing...
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Michael S.
QA Contact: Fedora Extras Quality Assurance
Depends On:
Blocks: 1208616 1212113
TreeView+ depends on / blocked
Reported: 2015-04-15 14:54 UTC by Jan Chaloupka
Modified: 2015-07-08 17:14 UTC (History)
2 users (show)

Fixed In Version: golang-github-hashicorp-yamux-0-0.1.gitb2e5585.el6
Doc Type: Bug Fix
Doc Text:
Clone Of:
Last Closed: 2015-06-30 00:01:56 UTC
misc: fedora-review+
gwync: fedora-cvs+

Attachments (Terms of Use)

Description Jan Chaloupka 2015-04-15 14:54:44 UTC
Spec URL: https://jchaloup.fedorapeople.org/reviews/golang-github-hashicorp-yamux/golang-github-hashicorp-yamux.spec

SRPM URL: https://jchaloup.fedorapeople.org/reviews/golang-github-hashicorp-yamux/golang-github-hashicorp-yamux-0-0.1.gitb2e5585.fc20.src.rpm

Description: Golang connection multiplexing library

Fedora Account System Username: jchaloup

Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=9488705

$ rpmlint /home/jchaloup/rpmbuild/SRPMS/golang-github-hashicorp-yamux-0-0.1.gitb2e5585.fc20.src.rpm /home/jchaloup/rpmbuild/RPMS/noarch/golang-github-hashicorp-yamux-devel-0-0.1.gitb2e5585.fc20.noarch.rpm
2 packages and 0 specfiles checked; 0 errors, 0 warnings.

Comment 1 Michael S. 2015-05-08 03:33:14 UTC
Package Review

[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed

- License should be in %license

- No need for conditional for BuildArch

- You should enable the tests ( or comment on why they are not enabled )

Provided theses 3 minors issues can be fixed before build, this package is approved.

===== MUST items =====

[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. No licenses
     found. Please check the source files for licenses manually.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 30720 bytes in 3 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
     supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: No rpmlint messages.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
     are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
     in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[-]: If the source package does not include license text(s) as a separate file
     from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

[x]: Rpmlint is run on all installed packages.
     Note: No rpmlint messages.
[x]: Spec file according to URL is the same as in SRPM.

Checking: golang-github-hashicorp-yamux-devel-0-0.1.gitb2e5585.el7.centos.noarch.rpm
2 packages and 0 specfiles checked; 0 errors, 0 warnings.

Rpmlint (installed packages)
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

golang-github-hashicorp-yamux-devel (rpmlib, GLIBC filtered):


Source checksums
https://github.com/hashicorp/yamux/archive/b2e55852ddaf823a85c67f798080eb7d08acd71d/yamux-b2e5585.tar.gz :
  CHECKSUM(SHA256) this package     : e4ca04b27f2899bd04033d4bb8cf2c5d0eac6e916c87851ded9cfa57d1f70b5f
  CHECKSUM(SHA256) upstream package : e4ca04b27f2899bd04033d4bb8cf2c5d0eac6e916c87851ded9cfa57d1f70b5f

Generated by fedora-review 0.5.2 (18d98aa) last change: 2014-10-14
Command line :./try-fedora-review -b 1212111
Buildroot used: epel-7-x86_64
Active plugins: Generic, Shell-api
Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby

Comment 2 Jan Chaloupka 2015-06-16 10:07:49 UTC
New Package SCM Request
Package Name: golang-github-hashicorp-yamux
Short Description: Golang connection multiplexing library
Upstream URL: https://github.com/hashicorp/yamux
Owners: jchaloup lsm5
Branches: f22 f21 f20 el6
InitialCC: golang-sig

Comment 3 Gwyn Ciesla 2015-06-16 13:48:38 UTC
Git done (by process-git-requests).

Comment 4 Fedora Update System 2015-06-20 08:21:21 UTC
golang-github-hashicorp-yamux-0-0.1.gitb2e5585.fc22 has been submitted as an update for Fedora 22.

Comment 5 Fedora Update System 2015-06-20 08:22:31 UTC
golang-github-hashicorp-yamux-0-0.1.gitb2e5585.fc21 has been submitted as an update for Fedora 21.

Comment 6 Fedora Update System 2015-06-20 08:22:59 UTC
golang-github-hashicorp-yamux-0-0.1.gitb2e5585.el6 has been submitted as an update for Fedora EPEL 6.

Comment 7 Fedora Update System 2015-06-20 21:14:31 UTC
golang-github-hashicorp-yamux-0-0.1.gitb2e5585.el6 has been pushed to the Fedora EPEL 6 testing repository.

Comment 8 Fedora Update System 2015-06-30 00:01:56 UTC
golang-github-hashicorp-yamux-0-0.1.gitb2e5585.fc21 has been pushed to the Fedora 21 stable repository.

Comment 9 Fedora Update System 2015-06-30 00:13:57 UTC
golang-github-hashicorp-yamux-0-0.1.gitb2e5585.fc22 has been pushed to the Fedora 22 stable repository.

Comment 10 Fedora Update System 2015-07-08 17:14:51 UTC
golang-github-hashicorp-yamux-0-0.1.gitb2e5585.el6 has been pushed to the Fedora EPEL 6 stable repository.

Note You need to log in before you can comment on or make changes to this bug.