Spec URL: https://raphgro.fedorapeople.org/review/py/jpype-py3/jpype-py3.spec SRPM URL: https://raphgro.fedorapeople.org/review/py/jpype-py3/jpype-py3-0-0.1.20150202gitca6fc96.fc21.src.rpm Description: JPype allows Python3 programs full access to Java class libraries Fedora Account System Username: raphgro
Open issue: How to run the provided tests/testsuite.py without installing the jpype module what is assumed in the test?
wget https://github.com/jcalmant/jpype-py3/archive/jpype-py3/ca6fc96a76d430c753b56ec2a4ed2a3eced0dac3.zip#/jpype-py3-ca6fc96.zip --2015-04-05 10:22:49-- https://github.com/jcalmant/jpype-py3/archive/jpype-py3/ca6fc96a76d430c753b56ec2a4ed2a3eced0dac3.zip Resolution github.com (github.com)... 192.30.252.131 Connecting to github.com (github.com)|192.30.252.131|:443... connected. HTTP request sent, awaiting response... 404 Not Found 2015-04-05 10:22:49 ERROR 404: Not Found. Please fix Source URL
Please, fix also Url field https://github.com/jcalmant/jpype-py3 ERROR 404: Not Found.
Spec URL: https://raphgro.fedorapeople.org/review/py/jpype-py3/jpype-py3.spec SRPM URL: https://raphgro.fedorapeople.org/review/py/jpype-py3/jpype-py3-0-0.1.20150202gitca6fc96.fc21.src.rpm Description: JPype allows Python3 programs full access to Java class libraries Fedora Account System Username: raphgro rawhide scratch: http://koji.fedoraproject.org/koji/taskinfo?taskID=9417336 (In reply to gil cattaneo from comment #3) > Please, fix also Url field > https://github.com/jcalmant/jpype-py3 ERROR 404: Not Found. A nasty typo fooled myself. Sorry for any confusion. I've updated with new files.
NOTE: manual review Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. Note: Cannot find LICENSE.txt in rpm(s) See: http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text IGNORE ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [-]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Apache (v2.0)", "Unknown or generated". 17 files have unknown license. Detailed output of licensecheck in /home/gil/1208701-jpype-py3/review- jpype-py3/licensecheck.txt jpype-py3-ca6fc96a76d430c753b56ec2a4ed2a3eced0dac3/native/cygwin/jni_md.h GPLv2 jpype-py3-ca6fc96a76d430c753b56ec2a4ed2a3eced0dac3/native/python/include/capsulethunk.h GPL/Python [x]: Package requires other packages for directories it uses. Note: No known owner of /usr/lib/python3.4, /usr/lib/python3.4/site- packages, /usr/share/licenses [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib/python3.4/site-packages, /usr/share/licenses, /usr/lib/python3.4 [?]: %build honors applicable compiler flags or justifies otherwise. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. Note: Using prebuilt rpms. python3-setuptools is already installed, maybe, you should remove [?]: Package contains no bundled libraries without FPC exception. see above jni_md.h is part of JDK capsulethunk.h is part of Python https://hg.python.org/cpython/file/b4cbecbc0781/Doc/includes/capsulethunk.h [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [-]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [?]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 30720 bytes in 8 files. [-]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [?]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. the "real" version is "0.5.5.2", maybe, you should use Version: 0.5.5.2 Release: 0.1.%{date}git%{shortcommit}%{?dist} * Thu ... - 0.5.5.2-0.1.20150202gitca6fc96 [x]: Package does not include license text files separate from upstream. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [?]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: jpype-py3-0-0.1.20150202gitca6fc96.fc23.i686.rpm jpype-py3-0-0.1.20150202gitca6fc96.fc21.src.rpm jpype-py3.src:64: W: macro-in-comment %{__python3} jpype-py3.src:72: W: macro-in-comment %doc jpype-py3.src: E: specfile-error sh: line 0: fg: no job control i dont understand this error ... 2 packages and 0 specfiles checked; 1 errors, 2 warnings. Rpmlint (installed packages) ---------------------------- INFO: mock.py version 1.2.7 starting (python version = 2.7.5)... Start: init plugins INFO: selinux enabled Finish: init plugins Start: run Start: chroot init INFO: calling preinit hooks INFO: enabled root cache INFO: enabled yum cache Start: cleaning yum metadata Finish: cleaning yum metadata INFO: enabled ccache Mock Version: 1.2.7 INFO: Mock Version: 1.2.7 Finish: chroot init INFO: installing package(s): rpmlint ERROR: Command failed. See logs for output. # /usr/bin/dnf --installroot /var/lib/mock/fedora-rawhide-i386/root/ --releasever 23 install rpmlint --setopt=tsflags=nocontexts Requires -------- jpype-py3 (rpmlib, GLIBC filtered): libc.so.6 libdl.so.2 libgcc_s.so.1 libgcc_s.so.1(GCC_3.0) libm.so.6 libpthread.so.0 libpython3.4m.so.1.0 libstdc++.so.6 libstdc++.so.6(CXXABI_1.3) python(abi) rtld(GNU_HASH) Provides -------- jpype-py3: jpype-py3 jpype-py3(x86-32) Unversioned so-files -------------------- jpype-py3: /usr/lib/python3.4/site-packages/_jpype.cpython-34m.so Source checksums ---------------- https://github.com/tcalmant/jpype-py3/archive/ca6fc96a76d430c753b56ec2a4ed2a3eced0dac3/jpype-py3-ca6fc96a76d430c753b56ec2a4ed2a3eced0dac3.tar.gz : CHECKSUM(SHA256) this package : d810b24e34eeebf57a11a12e11da7306d7cdf362b3f6a1fa6d9940f7483d5354 CHECKSUM(SHA256) upstream package : d810b24e34eeebf57a11a12e11da7306d7cdf362b3f6a1fa6d9940f7483d5354 Generated by fedora-review 0.5.2 (63c24cb) last change: 2014-07-14 Command line :/usr/bin/fedora-review -vpn jpype-py3 -m fedora-rawhide-i386 Buildroot used: fedora-rawhide-i386 Active plugins: Python, Generic, Shell-api, C/C++ Disabled plugins: Java, SugarActivity, fonts, Haskell, Ocaml, Perl, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG
NO blocking issues. APPROVED
Please, correct or remove this definition: # define sitearch for EPEL %{!?python3_sitearch: %global python3_sitearch %(%{__python2} -c "from distutils.sysconfig import get_python_lib; print(get_python_lib(1))")}
Thanks for the review! (In reply to gil cattaneo from comment #7) > Please, correct or remove this definition: > > # define sitearch for EPEL > %{!?python3_sitearch: %global python3_sitearch %(%{__python2} -c "from > distutils.sysconfig import get_python_lib; print(get_python_lib(1))")} There's currently no Python3 for EPEL. I'll remove this wrong line. You're right, thanks for the hint. (In reply to gil cattaneo from comment #5) > [x]: License field in the package spec file matches the actual license. > Note: Checking patched sources after %prep for licenses. Licenses found: > "Apache (v2.0)", "Unknown or generated". 17 files have unknown license. > Detailed output of licensecheck in /home/gil/1208701-jpype-py3/review- > jpype-py3/licensecheck.txt > jpype-py3-ca6fc96a76d430c753b56ec2a4ed2a3eced0dac3/native/cygwin/jni_md.h GPLv2 > jpype-py3-ca6fc96a76d430c753b56ec2a4ed2a3eced0dac3/native/python/include/capsulethunk.h GPL/Python … > [?]: Package contains no bundled libraries without FPC exception. > see above > jni_md.h is part of JDK > capsulethunk.h is part of Python https://hg.python.org/cpython/file/b4cbecbc0781/Doc/includes/capsulethunk.h As those both files are GPL'ed, I guess there's no more action needed. Is that right, please confirm. > [x]: Latest version is packaged. > the "real" version is "0.5.5.2", maybe, you should use > Version: 0.5.5.2 > Release: 0.1.%{date}git%{shortcommit}%{?dist} > * Thu ... - 0.5.5.2-0.1.20150202gitca6fc96 Will be fixed. > [?]: Useful -debuginfo package or justification otherwise. Not sure how java provides extra debuginfo, rpmbuild must find any if there. > [!]: Reviewer should test that the package builds in mock. rawhide scratch: http://koji.fedoraproject.org/koji/taskinfo?taskID=9417336 ==> OK > [?]: Python eggs must not download any dependencies during the build process. Copr build does not allow any network access and is success: https://copr.fedoraproject.org/coprs/raphgro/playground/build/84763/ > [?]: %check is present and all tests pass. (In reply to Raphael Groner from comment #1) > Open issue: How to run the provided tests/testsuite.py without installing > the jpype module what is assumed in the test? Still thinking about using that testsuite.py somehow for %check … > jpype-py3.src: E: specfile-error sh: line 0: fg: no job control > i dont understand this error ... You build for i386. Not tried yet by myself. Maybe an explanation for failure. But all x86_64 builds work (local rpmbuild f21, koji scratch rawhide, copr f20+f21+rawhide).
New Package SCM Request ======================= Package Name: jpype-py3 Short Description: JPype allows Python3 programs full access to Java class libraries Upstream URL: https://github.com/tcalmant/jpype-py3 Owners: raphgro Branches: f21 f22 InitialCC:
Git done (by process-git-requests).
Sorry, I've to make two corrections … (In reply to gil cattaneo from comment #5) > [x]: License field in the package spec file matches the actual license. > Note: Checking patched sources after %prep for licenses. Licenses found: > "Apache (v2.0)", "Unknown or generated". 17 files have unknown license. > Detailed output of licensecheck in /home/gil/1208701-jpype-py3/review- > jpype-py3/licensecheck.txt > jpype-py3-ca6fc96a76d430c753b56ec2a4ed2a3eced0dac3/native/cygwin/jni_md.h GPLv2 > jpype-py3-ca6fc96a76d430c753b56ec2a4ed2a3eced0dac3/native/python/include/capsulethunk.h GPL/Python … > [?]: Package contains no bundled libraries without FPC exception. > see above > jni_md.h is part of JDK > capsulethunk.h is part of Python https://hg.python.org/cpython/file/b4cbecbc0781/Doc/includes/capsulethunk.h As those both files are GPL'ed, I'll add GPLv2 to License: and mention both files in a comment. > [?]: Useful -debuginfo package or justification otherwise. Not sure how setup.py does extra debuginfo for all languages involved here (cpp, java, python), rpmbuild must find any if there.
jpype-py3-0-0.2.20150202gitca6fc96.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/jpype-py3-0-0.2.20150202gitca6fc96.fc22
jpype-py3-0-0.2.20150202gitca6fc96.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/jpype-py3-0-0.2.20150202gitca6fc96.fc21
jpype-py3-0-0.2.20150202gitca6fc96.fc22 has been pushed to the Fedora 22 testing repository.
jpype-py3-0-0.2.20150202gitca6fc96.fc22 has been pushed to the Fedora 22 stable repository.
jpype-py3-0-0.2.20150202gitca6fc96.fc21 has been pushed to the Fedora 21 stable repository.