Bug 1234905 - Review Request: jpype - Full access for Python programs to Java class libraries
Summary: Review Request: jpype - Full access for Python programs to Java class libraries
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: gil cattaneo
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-06-23 13:19 UTC by Raphael Groner
Modified: 2015-10-05 05:01 UTC (History)
4 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2015-10-04 19:16:28 UTC
Type: ---
Embargoed:
puntogil: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Bugzilla 1208701 0 medium CLOSED Review Request: jpype-py3 - JPype allows Python3 programs full access to Java class libraries 2021-02-22 00:41:40 UTC

Internal Links: 1208701

Description Raphael Groner 2015-06-23 13:19:38 UTC
Spec URL: https://raphgro.fedorapeople.org/review/py/jpype/jpype.spec
SRPM URL: https://raphgro.fedorapeople.org/review/py/jpype/jpype-0.6.0-1.src.rpm
Description: Full access for Python programs to Java class libraries
Fedora Account System Username: raphgro

rawhide build: http://koji.fedoraproject.org/koji/taskinfo?taskID=10191266

Notes:
- This is the main project at GitHub. I've already packaged the jpype-py3 fork but upstream does now officially support python3.
- Python tests are not working currently, some not yet understood issue with CPython. But that should not prevent an initial review.

Comment 1 Raphael Groner 2015-07-21 19:27:19 UTC
Spec URL: https://raphgro.fedorapeople.org/review/py/jpype/jpype.spec
SRPM URL: https://raphgro.fedorapeople.org/review/py/jpype/jpype-0.6.0-2.src.rpm

Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=10428806

* Tue Jul 21 2015 Raphael Groner <> - 0.6.0-2
- include patch of proxy argument issue

Enabled python tests give me:
ImportError: dynamic module does not define init function (PyInit__jpype)

This error may be related to https://bugs.python.org/issue19615
> python3 --version
Python 3.4.2

Comment 2 Raphael Groner 2015-07-27 14:04:46 UTC
Björn, how far are you with the review? Is there anything I need to fix? Please let me know about your questions.

Comment 3 gil cattaneo 2015-07-30 13:30:20 UTC
Björn, i will take this review, if you no have time

Comment 4 Zbigniew Jędrzejewski-Szmek 2015-07-30 13:51:00 UTC
You cannot remove _static, it is necessary to display the html pages properly. You should unbundle jquery probably (by replacing jquery.js with a symlink to /usr/share/javascript/jquery/2.1.3/jquery.min.js).

Why install the tests is doc... It would imho be much better to stick them in the python dir, so that they are importable as jpypy.tests or so.

"sanify"

Why put both python2 and python3 in the same package? This will (among other things) pull in the full python2 stack for python3 users of this package and vice-versa.

Why are tests only run with python3?

Missing python2-* provides.

Comment 5 Raphael Groner 2015-07-30 14:41:32 UTC
- I fully agree about _static inclusion and unbundling of jquery.

- Maybe it's best to remove the python2 stack completely. Before latest release, upstream's support was python2 only, now they promise full python3 support without the former github fork named jpype-py3 that's packaged already and my intention is to get it obsoleted when this review is done. Probably, I forgot to remove the python2 lines.

Comment 6 Zbigniew Jędrzejewski-Szmek 2015-07-30 14:48:33 UTC
Support for both python versions *should* be provided if possible. Many people are still using py2...

Comment 7 gil cattaneo 2015-07-30 15:02:45 UTC
Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed

===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[-]: Development (unversioned) .so files in -devel subpackage, if present.
     Note: Unversioned so-files in private %_libdir subdirectory (see
     attachment). Verify they are not in ld path.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[!]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Apache (v2.0)", "Unknown or generated". 15 files have unknown
     license. Detailed output of licensecheck in
     /home/gil/1234905-jpype/licensecheck.txt
    
    Please, ask to upstream to add license header for these files
jpype-0.6.0/doc/conf.py
jpype-0.6.0/native/python/include/capsulethunk.h
jpype-0.6.0/native/python/include/jp_cocoatools.h
jpype-0.6.0/native/python/include/jp_runloopstopper.h
jpype-0.6.0/test/harness/jpype/array/Test2.java
jpype-0.6.0/test/harness/jpype/attr/ClassWithBuffer.java
jpype-0.6.0/test/harness/jpype/attr/TestOverloadA.java
jpype-0.6.0/test/harness/jpype/attr/TestOverloadB.java
jpype-0.6.0/test/harness/jpype/attr/TestOverloadC.java
jpype-0.6.0/test/harness/jpype/exc/ChildTestException.java
jpype-0.6.0/test/harness/jpype/exc/ParentTestException.java
jpype-0.6.0/test/harness/jpype/properties/TestBean.java
jpype-0.6.0/test/harness/jpype/proxy/TestInterface1.java
jpype-0.6.0/test/harness/jpype/proxy/TestThreadCallback.java
jpype-0.6.0/test/transform_xunit_to_appveyor.xsl

[x]: License file installed when any subpackage combination is installed.
[-]: If the package is under multiple licenses, the licensing breakdown
     must be documented in the spec.
[x]: Package does not own files or directories owned by other packages.
     Note: Dirs in package are owned also by: /usr/lib/python3.4/site-
     packages/jpype/awt/event/__pycache__(jpype-py3), /usr/lib/python3.4
     /site-packages/jpypex/__pycache__(jpype-py3), /usr/lib/python3.4/site-
     packages/jpypex/swing(jpype-py3), /usr/lib/python3.4/site-
     packages/jpypex/swing/__pycache__(jpype-py3), /usr/lib/python3.4/site-
     packages/jpype/awt(jpype-py3), /usr/lib/python3.4/site-
     packages/jpype/awt/event(jpype-py3), /usr/lib/python3.4/site-
     packages/jpypex(jpype-py3), /usr/lib/python3.4/site-
     packages/jpype/__pycache__(jpype-py3), /usr/lib/python3.4/site-
     packages/jpype(jpype-py3), /usr/lib/python3.4/site-
     packages/jpype/awt/__pycache__(jpype-py3)
[?]: %build honors applicable compiler flags or justifies otherwise.
[?]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[-]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[?]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[?]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 40960 bytes in 6 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Java:
[x]: Bundled jar/class files should be removed before build

Maven:
[-]: If package contains pom.xml files install it (including metadata) even
     when building with ant
[x]: Old add_to_maven_depmap macro is not being used

Python:
[x]: Python eggs must not download any dependencies during the build
     process.
[x]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in jpype-
     doc
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise
     justified.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Uses parallel make %{?_smp_mflags} macro.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

Java:
[-]: Packages are noarch unless they use JNI
     Note: jpype subpackage is not noarch. Please verify manually
[x]: Package uses upstream build method (ant/maven/etc.)

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on debuginfo package(s).
     Note: There are rpmlint messages (see attachment).
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: jpype-0.6.0-2.i686.rpm
          jpype-doc-0.6.0-2.noarch.rpm
          jpype-0.6.0-2.src.rpm
jpype-doc.noarch: W: doc-file-dependency /usr/share/doc/jpype-doc/test/test_jarray_fixes.py /usr/bin/env
3 packages and 0 specfiles checked; 0 errors, 1 warnings.




Rpmlint (debuginfo)
-------------------
Checking: jpype-debuginfo-0.6.0-2.i686.rpm
jpype-debuginfo.i686: E: debuginfo-without-sources
1 packages and 0 specfiles checked; 1 errors, 0 warnings.





Rpmlint (installed packages)
----------------------------
jpype-debuginfo.i686: E: debuginfo-without-sources
jpype-doc.noarch: W: doc-file-dependency /usr/share/doc/jpype-doc/test/test_jarray_fixes.py /usr/bin/env
3 packages and 0 specfiles checked; 1 errors, 1 warnings.



Requires
--------
jpype (rpmlib, GLIBC filtered):
    libc.so.6
    libdl.so.2
    libpthread.so.0
    libpython2.7.so.1.0
    libpython3.4m.so.1.0
    python(abi)
    rtld(GNU_HASH)

jpype-doc (rpmlib, GLIBC filtered):
    /usr/bin/env



Provides
--------
jpype:
    jpype
    jpype(x86-32)

jpype-doc:
    jpype-doc



Unversioned so-files
--------------------
jpype: /usr/lib/python2.7/site-packages/_jpype.so
jpype: /usr/lib/python3.4/site-packages/_jpype.so

Source checksums
----------------
https://github.com/originell/jpype/archive/v0.6.0.tar.gz#/jpype-0.6.0.tar.gz :
  CHECKSUM(SHA256) this package     : 496c7788fe885c2f798d8ff8d3f584caed5dd7257aeeceb554298cb5cc99787a
  CHECKSUM(SHA256) upstream package : 496c7788fe885c2f798d8ff8d3f584caed5dd7257aeeceb554298cb5cc99787a


Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20
Command line :/bin/fedora-review -b 1234905 -m fedora-rawhide-i386
Buildroot used: fedora-rawhide-i386
Active plugins: Python, Shell-api, Generic, Java, C/C++
Disabled plugins: fonts, SugarActivity, Ocaml, Haskell, Perl, R, PHP, Ruby
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6

Comment 8 gil cattaneo 2015-07-30 15:05:13 UTC
NON blocking issues:
[!]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Apache (v2.0)", "Unknown or generated". 15 files have unknown
     license. Detailed output of licensecheck in
     /home/gil/1234905-jpype/licensecheck.txt
   see above 
jpype-doc.noarch: W: doc-file-dependency /usr/share/doc/jpype-doc/test/test_jarray_fixes.py /usr/bin/env
 Please, fix this file

Blocking issues:
jpype-debuginfo.i686: E: debuginfo-without-sources

Comment 9 Raphael Groner 2015-08-14 14:28:53 UTC
(In reply to Zbigniew Jędrzejewski-Szmek from comment #6)
> Support for both python versions *should* be provided if possible. Many
> people are still using py2...

Support for python2 (cause of legacy and theoretical reasons) will complicate things a lot and increases complexity in packaging. There is currently no package that requires a jpype with python2.

Comment 10 Zbigniew Jędrzejewski-Szmek 2015-08-14 15:49:04 UTC
(In reply to Raphael Groner from comment #9)
> (In reply to Zbigniew Jędrzejewski-Szmek from comment #6)
> > Support for both python versions *should* be provided if possible. Many
> > people are still using py2...
> 
> Support for python2 (cause of legacy and theoretical reasons) will
> complicate things a lot and increases complexity in packaging.
Please have a look at the new python guidelines [https://fedoraproject.org/wiki/Packaging:Python]. They have been recently updated to make parallel python2 and python3 packaging much easier.

> There is
> currently no package that requires a jpype with python2.
Packaging both versions is encouraged, even if there are no immediate users, because it much easier to move dependent projects between both versions. Another reason is that people develop their own things on Fedora, so we provide things even if they are not used by the rest of distribution.

Comment 11 Raphael Groner 2015-08-14 18:12:26 UTC
Do you have the ability to maintain this package in the requested complexity? If yes, you can take this review request. Sorry but I do not have the time to handle this complexity.

Comment 12 Zbigniew Jędrzejewski-Szmek 2015-08-14 18:58:37 UTC
I don't have any particular interest in this package. Having python2 and python3 subpackages is not (one can at least assume that without further information) harder than in any other python package... If you have a reason to think that for this package it *is* so, for example because of the interaction between java and versions, than you can provide just the python3 version. I was pretty careful to use "should" everywhere. It's your choice, even if the project encourages support for both versions.

Comment 13 Raphael Groner 2015-08-23 20:20:43 UTC
I decided to relaunch this review request and think to (hopefully) understand now how to apply properly the new python guidelines.

jpype.spec
- subpackages python2-jpype and python3-jpype
- individual %python_provides python-jpype
- virtual Provides: jpype
- Obsoletes: jpype-py3
- epel7 has only python2-jpype
- python3 support for f22+

gil,
it's a multi licensed project, some headers are taken from JDK and Python, it's already mentioned in a comment, we found that situation early in the review of jpype-py3. 
Test files could be removed from doc package when license and any other issue for those are still unclear.
> Blocking issues:
> jpype-debuginfo.i686: E: debuginfo-without-sources
This is cause of wrong BuildArch, I'll change to noarch.

Comment 14 Raphael Groner 2015-09-10 11:31:35 UTC
Spec URL: https://raphgro.fedorapeople.org/review/py/jpype/jpype.spec
SRPM URL: https://raphgro.fedorapeople.org/review/py/jpype/jpype-0.6.1-1.src.rpm

Task info (rawhide): http://koji.fedoraproject.org/koji/taskinfo?taskID=11032558
Task info (epel7): http://koji.fedoraproject.org/koji/taskinfo?taskID=11032469

* Thu Sep 10 2015 Raphael Groner <> - 0.6.1-1
- new upstream release v0.6.1
- make tests work with python3
- deprecation of jpype-py3
- split subpackages for python2 and 3
- use python build and install macros
- ease html generation
- ship _static documentation files
- unbundle jquery
- ship tests folder as an import option w/o execution bits
- restrict documentation to only some .rst files

Comment 15 gil cattaneo 2015-09-10 11:59:00 UTC
Start now the review...
if have time (no problems if you cant) can review this for me https://bugzilla.redhat.com/show_bug.cgi?id=1260975 ?
thanks in advance

Comment 16 gil cattaneo 2015-09-10 12:12:07 UTC
Build fails:
BUILD SUCCESSFUL
Total time: 1 second
+ popd
+ sphinx-build -d doctrees doc html
~/build/BUILD/jpype-0.6.1
Compilation errors RPM:
/var/tmp/rpm-tmp.fuNA0A: line 42: sphinx-build: command not found

Comment 18 gil cattaneo 2015-09-10 14:44:31 UTC
Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
=======
- Packages have proper BuildRequires/Requires on jpackage-utils
 IGNORE
- Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink)
  Note: No javadoc subpackage present
  See: https://fedoraproject.org/wiki/Packaging:Java#Javadoc_installation
 IGNORE
- Javadoc documentation files are generated and included in -javadoc
  subpackage
  Note: No javadoc subpackage present. Note: Javadocs are optional for
  Fedora versions >= 21
  See: https://fedoraproject.org/wiki/Packaging:Java#Javadoc_installation
 IGNORE

===== MUST items =====

C/C++:
[-]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[-]: Development (unversioned) .so files in -devel subpackage, if present.
     Note: Unversioned so-files in private %_libdir subdirectory (see
     attachment). Verify they are not in ld path.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Apache (v2.0)", "Unknown or generated". 40 files have unknown
     license. Detailed output of licensecheck in
     /home/gil/1234905-jpype/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: If the package is under multiple licenses, the licensing breakdown
     must be documented in the spec.
[?]: Package does not own files or directories owned by other packages.
     Note: Dirs in package are owned also by: /usr/lib/python3.4/site-
     packages/jpype/awt/event/__pycache__(jpype-py3), /usr/lib/python3.4
     /site-packages/jpypex/__pycache__(jpype-py3), /usr/lib/python3.4/site-
     packages/jpypex/swing(jpype-py3), /usr/lib/python3.4/site-
     packages/jpypex/swing/__pycache__(jpype-py3), /usr/lib/python3.4/site-
     packages/jpype/awt(jpype-py3), /usr/lib/python3.4/site-
     packages/jpype/awt/event(jpype-py3), /usr/lib/python3.4/site-
     packages/jpypex(jpype-py3), /usr/lib/python3.4/site-
     packages/jpype/__pycache__(jpype-py3), /usr/lib/python3.4/site-
     packages/jpype(jpype-py3), /usr/lib/python3.4/site-
     packages/jpype/awt/__pycache__(jpype-py3)
[x]: %build honors applicable compiler flags or justifies otherwise.
[?]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[-]: Package uses nothing in %doc for runtime.
[-]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 20480 bytes in 4 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Java:
[x]: Bundled jar/class files should be removed before build

Maven:
[-]: If package contains pom.xml files install it (including metadata) even
     when building with ant
[x]: Old add_to_maven_depmap macro is not being used

Python:
[x]: Python eggs must not download any dependencies during the build
     process.
[x]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[-]: Avoid bundling fonts in non-fonts packages.
     Note: Package contains font files
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
     python2-jpype , python3-jpype , jpype-doc
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

Java:
[x]: Packages are noarch unless they use JNI
     Note: python2-jpype subpackage is not noarch. Please verify manually
[x]: Package uses upstream build method (ant/maven/etc.)

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on debuginfo package(s).
     Note: No rpmlint messages.
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: python2-jpype-0.6.1-1.i686.rpm
          python3-jpype-0.6.1-1.i686.rpm
          jpype-doc-0.6.1-1.noarch.rpm
          jpype-0.6.1-1.src.rpm
python3-jpype.i686: W: self-obsoletion jpype-py3 obsoletes jpype-py3
python3-jpype.i686: E: python-bytecode-inconsistent-mtime /usr/lib/python3.4/site-packages/jpypetest/__pycache__/jvmfinder.cpython-34.pyo 2015-09-10T16:23:39 /usr/lib/python3.4/site-packages/jpypetest/jvmfinder.py 2015-09-10T16:24:01
jpype-doc.noarch: W: dangling-relative-symlink /usr/share/doc/jpype-doc/html/_static/jquery.js %{_jsdir}/jquery/2/jquery.min.js
jpype.src:48: W: unversioned-explicit-provides %{name}
jpype.src:67: W: unversioned-explicit-obsoletes %{name}-py3
jpype.src:68: W: unversioned-explicit-provides %{name}-py3
4 packages and 0 specfiles checked; 1 errors, 5 warnings.




Rpmlint (debuginfo)
-------------------
Checking: jpype-debuginfo-0.6.1-1.i686.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.





Rpmlint (installed packages)
----------------------------
python3-jpype.i686: W: self-obsoletion jpype-py3 obsoletes jpype-py3
python3-jpype.i686: E: python-bytecode-inconsistent-mtime /usr/lib/python3.4/site-packages/jpypetest/__pycache__/jvmfinder.cpython-34.pyo 2015-09-10T16:23:39 /usr/lib/python3.4/site-packages/jpypetest/jvmfinder.py 2015-09-10T16:24:01
jpype-doc.noarch: W: dangling-relative-symlink /usr/share/doc/jpype-doc/html/_static/jquery.js %{_jsdir}/jquery/2/jquery.min.js
4 packages and 0 specfiles checked; 1 errors, 2 warnings.



Requires
--------
python3-jpype (rpmlib, GLIBC filtered):
    libc.so.6
    libdl.so.2
    libgcc_s.so.1
    libgcc_s.so.1(GCC_3.0)
    libm.so.6
    libpthread.so.0
    libpython3.4m.so.1.0
    libstdc++.so.6
    libstdc++.so.6(CXXABI_1.3)
    python(abi)
    rtld(GNU_HASH)

python2-jpype (rpmlib, GLIBC filtered):
    libc.so.6
    libdl.so.2
    libgcc_s.so.1
    libgcc_s.so.1(GCC_3.0)
    libm.so.6
    libpthread.so.0
    libpython2.7.so.1.0
    libstdc++.so.6
    libstdc++.so.6(CXXABI_1.3)
    python(abi)
    rtld(GNU_HASH)

jpype-doc (rpmlib, GLIBC filtered):
    js-jquery



Provides
--------
python3-jpype:
    jpype-py3
    python3-jpype
    python3-jpype(x86-32)

python2-jpype:
    jpype
    python-jpype
    python2-jpype
    python2-jpype(x86-32)

jpype-doc:
    jpype-doc



Unversioned so-files
--------------------
python2-jpype: /usr/lib/python2.7/site-packages/_jpype.so
python3-jpype: /usr/lib/python3.4/site-packages/_jpype.cpython-34m.so

Source checksums
----------------
https://github.com/originell/jpype/archive/v0.6.1.tar.gz#/jpype-0.6.1.tar.gz :
  CHECKSUM(SHA256) this package     : f7e81ef2e722a26929d329d2a15e2638f5b28f15a30d1dff1c88e6c3d38a85d8
  CHECKSUM(SHA256) upstream package : f7e81ef2e722a26929d329d2a15e2638f5b28f15a30d1dff1c88e6c3d38a85d8


Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20
Command line :/bin/fedora-review -b 1234905 -m fedora-rawhide-i386
Buildroot used: fedora-rawhide-i386
Active plugins: Python, Shell-api, Generic, Java, C/C++
Disabled plugins: fonts, SugarActivity, Ocaml, Haskell, Perl, R, PHP, Ruby
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6

Comment 19 gil cattaneo 2015-09-10 14:45:29 UTC
Seem all fine. Approved

Comment 20 Raphael Groner 2015-09-10 14:59:58 UTC
New Package SCM Request
=======================
Package Name: jpype
Short Description: Full access for Python programs to Java class libraries
Upstream URL: https://github.com/originell/jpype
Owners: raphgro
Branches: f23 f22 epel7
InitialCC:

Comment 21 Gwyn Ciesla 2015-09-10 19:52:47 UTC
Git done (by process-git-requests).

Comment 22 Fedora Update System 2015-09-12 19:52:35 UTC
jpype-0.6.1-1.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2015-15701

Comment 23 Fedora Update System 2015-09-12 20:17:52 UTC
jpype-0.6.1-1.fc22 has been submitted as an update to Fedora 22. https://bodhi.fedoraproject.org/updates/FEDORA-2015-15702

Comment 24 Fedora Update System 2015-09-12 21:05:42 UTC
jpype-0.6.1-1.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-8052

Comment 25 Fedora Update System 2015-09-13 04:19:56 UTC
jpype-0.6.1-1.fc22 has been pushed to the Fedora 22 testing repository. If problems still persist, please make note of it in this bug report.\nIf you want to test the update, you can install it with \n su -c 'yum --enablerepo=updates-testing update jpype'. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-15702

Comment 26 Fedora Update System 2015-09-13 18:20:11 UTC
jpype-0.6.1-1.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report.\nIf you want to test the update, you can install it with \n su -c 'yum --enablerepo=updates-testing update jpype'. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-15701

Comment 27 Fedora Update System 2015-09-14 02:49:27 UTC
jpype-0.6.1-1.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report.\nIf you want to test the update, you can install it with \n su -c 'yum --enablerepo=updates-testing update jpype'. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-8052

Comment 28 Fedora Update System 2015-10-04 19:16:26 UTC
jpype-0.6.1-1.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.

Comment 29 Fedora Update System 2015-10-04 22:51:54 UTC
jpype-0.6.1-1.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report.

Comment 30 Fedora Update System 2015-10-05 05:01:25 UTC
jpype-0.6.1-1.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.