Bug 1210684 - BitRot :- scrub pause/resume should give proper error message if scrubber is already paused/resumed and Admin tries to perform same operation
Summary: BitRot :- scrub pause/resume should give proper error message if scrubber is ...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: bitrot
Version: mainline
Hardware: x86_64
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Satish Mohan
QA Contact:
bugs@gluster.org
URL:
Whiteboard:
Depends On:
Blocks: qe_tracker_everglades 1218596
TreeView+ depends on / blocked
 
Reported: 2015-04-10 11:18 UTC by Rachana Patel
Modified: 2016-06-16 12:48 UTC (History)
3 users (show)

Fixed In Version: glusterfs-3.8rc2
Clone Of:
: 1218596 1224240 (view as bug list)
Environment:
Last Closed: 2016-06-16 12:48:36 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Rachana Patel 2015-04-10 11:18:15 UTC
Description of problem:
=======================
If Scrubber is already pasued then pause command should give proper error message rather than saying 'success'. Same is expected for resume functionality.


Version-Release number of selected component (if applicable):
=============================================================
3.7dev-0.952.gita7f1d08.el6.x86_64

How reproducible:
=================
always

Steps to Reproduce:
===================
1. create and mount volume.
2. enable bitrot
3. pause scrub process and check volume info.
4. try to pause scrub process.
5. Resume scrub process and check Volume info.
6. try to resume scrub process again


Actual Result:-
===============
On resuming/pausing it again it says 'volume bitrot: success' 

Expect Result:-
===============
On resuming/pausing it should say it is already paused/resumed

Comment 1 Anand Avati 2015-04-13 07:11:05 UTC
REVIEW: http://review.gluster.org/10209 (bitrot/glusterd: Bitrot scrub pause/resume should give proper error) posted (#1) for review on master by Gaurav Kumar Garg (ggarg)

Comment 3 Anand Avati 2015-04-29 14:53:37 UTC
REVIEW: http://review.gluster.org/10209 (bitrot/glusterd: Bitrot scrub pause/resume should give proper error) posted (#2) for review on master by Gaurav Kumar Garg (ggarg)

Comment 4 Anand Avati 2015-05-04 07:04:17 UTC
REVIEW: http://review.gluster.org/10209 (bitrot/glusterd: Bitrot scrub pause/resume should give proper error) posted (#3) for review on master by Gaurav Kumar Garg (ggarg)

Comment 5 Anand Avati 2015-05-04 09:37:53 UTC
REVIEW: http://review.gluster.org/10209 (bitrot/glusterd: Bitrot scrub pause/resume should give proper error) posted (#4) for review on master by Gaurav Kumar Garg (ggarg)

Comment 6 Anand Avati 2015-05-05 06:32:10 UTC
REVIEW: http://review.gluster.org/10209 (bitrot/glusterd: Bitrot scrub pause/resume should give proper error) posted (#5) for review on master by Gaurav Kumar Garg (ggarg)

Comment 7 Anand Avati 2015-05-05 11:25:02 UTC
REVIEW: http://review.gluster.org/10576 (bitrot/glusterd: Bitrot scrub pause/resume should give proper error) posted (#1) for review on release-3.7 by Gaurav Kumar Garg (ggarg)

Comment 8 Anand Avati 2015-05-05 18:19:18 UTC
REVIEW: http://review.gluster.org/10209 (bitrot/glusterd: Bitrot scrub pause/resume should give proper error) posted (#6) for review on master by Gaurav Kumar Garg (ggarg)

Comment 9 Anand Avati 2015-05-06 06:38:31 UTC
REVIEW: http://review.gluster.org/10209 (bitrot/glusterd: Bitrot scrub pause/resume should give proper error) posted (#7) for review on master by Gaurav Kumar Garg (ggarg)

Comment 10 Anand Avati 2015-05-07 07:27:29 UTC
COMMIT: http://review.gluster.org/10209 committed in master by Kaushal M (kaushal) 
------
commit d68a2dbb3a4be89a4a45661310ae3f32542df20f
Author: Gaurav Kumar Garg <ggarg>
Date:   Mon Apr 13 12:34:26 2015 +0530

    bitrot/glusterd: Bitrot scrub pause/resume should give proper error
    
    bitrot scrubber paused/resume command should give proper error messages if
    scrubber already pause/resume and user again try to perform same
    operation on a volume.
    
    Change-Id: I01ad69c80f03b177535a4e5f1c95ab7709a804b0
    BUG: 1210684
    Signed-off-by: Gaurav Kumar Garg <ggarg>
    Reviewed-on: http://review.gluster.org/10209
    Reviewed-by: Atin Mukherjee <amukherj>
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Kaushal M <kaushal>

Comment 11 Nagaprasad Sathyanarayana 2015-10-25 14:54:31 UTC
Fix for this bug is already made in a GlusterFS release. The cloned BZ has details of the fix and the release. Hence closing this mainline BZ.

Comment 12 Nagaprasad Sathyanarayana 2015-10-25 15:16:44 UTC
Fix for this BZ is already present in a GlusterFS release. You can find clone of this BZ, fixed in a GlusterFS release and closed. Hence closing this mainline BZ as well.

Comment 14 Niels de Vos 2016-06-16 12:48:36 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.8.0, please open a new bug report.

glusterfs-3.8.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://blog.gluster.org/2016/06/glusterfs-3-8-released/
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user


Note You need to log in before you can comment on or make changes to this bug.