+++ This bug was initially created as a clone of Bug #1210684 +++ Description of problem: ======================= If Scrubber is already pasued then pause command should give proper error message rather than saying 'success'. Same is expected for resume functionality. Version-Release number of selected component (if applicable): ============================================================= 3.7dev-0.952.gita7f1d08.el6.x86_64 How reproducible: ================= always Steps to Reproduce: =================== 1. create and mount volume. 2. enable bitrot 3. pause scrub process and check volume info. 4. try to pause scrub process. 5. Resume scrub process and check Volume info. 6. try to resume scrub process again Actual Result:- =============== On resuming/pausing it again it says 'volume bitrot: success' Expect Result:- =============== On resuming/pausing it should say it is already paused/resumed --- Additional comment from Anand Avati on 2015-04-13 03:11:05 EDT --- REVIEW: http://review.gluster.org/10209 (bitrot/glusterd: Bitrot scrub pause/resume should give proper error) posted (#1) for review on master by Gaurav Kumar Garg (ggarg) --- Additional comment from Anand Avati on 2015-04-29 10:53:37 EDT --- REVIEW: http://review.gluster.org/10209 (bitrot/glusterd: Bitrot scrub pause/resume should give proper error) posted (#2) for review on master by Gaurav Kumar Garg (ggarg) --- Additional comment from Anand Avati on 2015-05-04 03:04:17 EDT --- REVIEW: http://review.gluster.org/10209 (bitrot/glusterd: Bitrot scrub pause/resume should give proper error) posted (#3) for review on master by Gaurav Kumar Garg (ggarg) --- Additional comment from Anand Avati on 2015-05-04 05:37:53 EDT --- REVIEW: http://review.gluster.org/10209 (bitrot/glusterd: Bitrot scrub pause/resume should give proper error) posted (#4) for review on master by Gaurav Kumar Garg (ggarg) --- Additional comment from Anand Avati on 2015-05-05 02:32:10 EDT --- REVIEW: http://review.gluster.org/10209 (bitrot/glusterd: Bitrot scrub pause/resume should give proper error) posted (#5) for review on master by Gaurav Kumar Garg (ggarg) --- Additional comment from Anand Avati on 2015-05-05 07:25:02 EDT --- REVIEW: http://review.gluster.org/10576 (bitrot/glusterd: Bitrot scrub pause/resume should give proper error) posted (#1) for review on release-3.7 by Gaurav Kumar Garg (ggarg) --- Additional comment from Anand Avati on 2015-05-05 14:19:18 EDT --- REVIEW: http://review.gluster.org/10209 (bitrot/glusterd: Bitrot scrub pause/resume should give proper error) posted (#6) for review on master by Gaurav Kumar Garg (ggarg) --- Additional comment from Anand Avati on 2015-05-06 02:38:31 EDT --- REVIEW: http://review.gluster.org/10209 (bitrot/glusterd: Bitrot scrub pause/resume should give proper error) posted (#7) for review on master by Gaurav Kumar Garg (ggarg) --- Additional comment from Anand Avati on 2015-05-07 03:27:29 EDT --- COMMIT: http://review.gluster.org/10209 committed in master by Kaushal M (kaushal) ------ commit d68a2dbb3a4be89a4a45661310ae3f32542df20f Author: Gaurav Kumar Garg <ggarg> Date: Mon Apr 13 12:34:26 2015 +0530 bitrot/glusterd: Bitrot scrub pause/resume should give proper error bitrot scrubber paused/resume command should give proper error messages if scrubber already pause/resume and user again try to perform same operation on a volume. Change-Id: I01ad69c80f03b177535a4e5f1c95ab7709a804b0 BUG: 1210684 Signed-off-by: Gaurav Kumar Garg <ggarg> Reviewed-on: http://review.gluster.org/10209 Reviewed-by: Atin Mukherjee <amukherj> Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Kaushal M <kaushal>
http://review.gluster.org/10209 patch already available in 3.7 branch. moving status of this bug as a QA
Tested with glusterfs-fuse-3.7.0-2.el6rhs.x86_64 and once scruber is on pause state if we run command to pause the scrubber giving proper message [root@rhs-client38 CIFS]# gluster vol bitrot smb scrub pause volume bitrot: success [root@rhs-client38 CIFS]# gluster vol bitrot smb scrub pause Bitrot command failed : Scrub is already paused for volume smb [root@rhs-client38 CIFS]# gluster vol bitrot smb scrub resume volume bitrot: success [root@rhs-client38 CIFS]# gluster vol bitrot smb scrub resume Bitrot command failed : Scrub is already resumed for volume smb [root@rhs-client38 CIFS]# gluster vol bitrot vol1 scrub resume Bitrot command failed : Bitrot is not enabled on volume vol1
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://rhn.redhat.com/errata/RHSA-2015-1495.html