Bug 1211849 - RFE: As a project maintainer, I want to be able to change my project/version slug
RFE: As a project maintainer, I want to be able to change my project/version ...
Status: CLOSED CURRENTRELEASE
Product: Zanata
Classification: Community
Component: Component-Logic (Show other bugs)
3.7
Unspecified Unspecified
high Severity high
: ---
: 3.7
Assigned To: Patrick Huang
Damian Jansen
: Triaged
Depends On:
Blocks: 1082840
  Show dependency treegraph
 
Reported: 2015-04-15 01:55 EDT by Alex Eng
Modified: 2015-07-23 00:10 EDT (History)
5 users (show)

See Also:
Fixed In Version: 3.7.0-SNAPSHOT (git-jenkins-zanata-server-github-pull-requests-3524)
Doc Type: Bug Fix
Doc Text:
Story Points: 3
Clone Of:
Environment:
Last Closed: 2015-07-21 22:20:01 EDT
Type: Bug
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)

  None (edit)
Description Alex Eng 2015-04-15 01:55:41 EDT
Points from discussion:

- Allow change of slug for project/version after creation.
Comment 1 David Mason 2015-04-21 23:44:34 EDT
What to implement (from dev team discussion):

 - Allow maintainer to change slug to an available slug on the settings page.
   - Same sort of validation messages for unavailable slug as when creating a new project/version.
 - Make it clear to the user that changing will break the links to the project/version.
 - Old slug is available immediately.
 - Make sure tooltips & help do not say that it cannot be changed.
 - A renamed project-version should still show up in a group that it was in (with the new name).

Technical note: has to invalidate cache and lucene indexes.
Comment 2 Patrick Huang 2015-05-04 00:19:29 EDT
All open editor session (workspace) will become invalid after slug change. Need to sent notification to editor or even force redirect to new url
Comment 3 Patrick Huang 2015-05-04 02:41:20 EDT
From what I can see in our code, we index project version slug but never really query it.
We used to use lucene search in project wide search but then switched back to HQL.   There is a boolean value to switch between the two implementation.
Right now, it is not used. But I will re-index it anyway after a version slug change.

see:
org.zanata.service.impl.TranslationMemoryServiceImpl#buildContextQuery
org.zanata.hibernate.search.ContainingWorkspaceBridge#set
org.zanata.service.impl.TextFlowSearchServiceImpl#findTextFlowsByDocumentPaths
Comment 4 Patrick Huang 2015-05-06 01:56:29 EDT
https://github.com/zanata/zanata-server/pull/796
Comment 5 Patrick Huang 2015-05-10 21:13:35 EDT
comment 3 is no longer true. we don't index version slug any more.
Comment 6 Damian Jansen 2015-05-18 20:59:46 EDT
Verified (master) at 4995a027ab73f0b1e2ea734fc5a7db43b92ee37d

Note You need to log in before you can comment on or make changes to this bug.