Spec URL: http://download.eng.brq.redhat.com/scratch/jskarvad/fbb/fbb.spec SRPM URL: http://download.eng.brq.redhat.com/scratch/jskarvad/fbb/fbb-7.0.8-0.1.beta.fc21.src.rpm Description: F6FBB BBS software for bulletins and messages distribution via Packet Radio and wired networks. Fedora Account System Username: jskarvad Patches were sent upstream and upstream was notified about invalid FSF snail mail address. I also moved files from /var/lib/ax25/fbb to /var/lib/fbb as the former directory structure is not yet allowed by FHS, but the request has been submitted and it may get into next FHS revisions. There is CRC implementation included, I am not sure whether it is problem requiring bundling exception.
Issues: ======= - Package does not contain duplicates in %files. Note: warning: File listed twice: /var/lib/fbb See: http://fedoraproject.org/wiki/Packaging/Guidelines#DuplicateFiles - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. Note: License file COPYING is marked as %doc instead of %license See: http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text ===== MUST items ===== C/C++: [ ]: Package does not contain kernel modules. [ ]: Package contains no static executables. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "GPL (v2 or later) (with incorrect FSF address)", "*No copyright* GPL (v2 or later) (with incorrect FSF address)", "Unknown or generated". 1 files have unknown license. Detailed output of licensecheck in /home/jsynacek/work/reviews/fbb/1214834-fbb/licensecheck.txt [ ]: License file installed when any subpackage combination is installed. [ ]: Package must own all directories that it creates. Note: Directories without known owners: /etc/ax25 [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package uses nothing in %doc for runtime. [ ]: Package consistently uses macros (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 92160 bytes in 6 files. [ ]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in fbb-doc [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [ ]: Patches link to upstream bugs/comments/lists or are otherwise justified. [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make %{?_smp_mflags} macro. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: There are rpmlint messages (see attachment). [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Package should not use obsolete m4 macros [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: fbb-7.0.8-0.1.beta.fc21.x86_64.rpm fbb-doc-7.0.8-0.1.beta.fc21.noarch.rpm fbb-gui-7.0.8-0.1.beta.fc21.x86_64.rpm fbb-7.0.8-0.1.beta.fc21.src.rpm fbb.x86_64: E: incorrect-fsf-address /usr/share/doc/fbb/COPYING fbb.x86_64: W: no-manual-page-for-binary ajoursat fbb.x86_64: W: no-manual-page-for-binary satdoc fbb.x86_64: W: no-manual-page-for-binary satupdat fbb-gui.x86_64: W: no-documentation fbb-gui.x86_64: W: no-manual-page-for-binary xfbbX_cl fbb-gui.x86_64: W: no-manual-page-for-binary xfbbX fbb-gui.x86_64: W: no-manual-page-for-binary xfbb 4 packages and 0 specfiles checked; 1 errors, 7 warnings. Rpmlint (debuginfo) ------------------- Checking: fbb-debuginfo-7.0.8-0.1.beta.fc21.x86_64.rpm fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/fbb_orb.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/arbre.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/xfbbC.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/tncio.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/drv_hst.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/mbl_rev.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/qraloc.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/X11/xfbb.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/statis.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/kernel.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/driver.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/gesfic.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/forward.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/X11/xfbblcnx.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/include/serv.h fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/devio.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/drv_tcp.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/autobin.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/tnc.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/mbl_expo.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/ibm.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/X11/xfbbcnsl.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/X11/xfbbXcnsl.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/trait.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/modem.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/drv_ded.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/initfwd.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/nouvfwd.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/fbb_conf.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/fwdutil.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/wpserv.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/epurwp.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/console.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/pacsat.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/xfbbd.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/include/fbb_conf.h fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/waveplay.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/mbl_stat.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/themes.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/X11/xfbbmain.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/maintinf.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/serv.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/mbl_prn.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/trajovl.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/yapp.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/mbl_read.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/fwdovl6.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/fwdovl4.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/include/md5.h fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/terminal.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/clr_user.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/include/global.h fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/serveur.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/dos_dir.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/init_srv.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/drv_aea.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/variable.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/aff_stat.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/include/pbsv.h fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/conf.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/include/fbb_dec.h fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/xmodem.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/X11/xfbbabtd.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/watchdog.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/lzhuf.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/fbbgetconf.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/bidexms.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/drv_sock.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/epurmess.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/maint_fw.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/include/xfbbX.h fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/ajoursat.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/fwdovl2.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/rx25.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/warning.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/include/fbb_var.h fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/X11/xfbbXabtd.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/fwdovl7.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/include/fbb_serv.h fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/satupdat.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/exec_pg.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/redist.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/X11/xeditor.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/reqdir.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/include/crc.h fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/drv_kam.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/mbl_kill.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/balise.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/drv_mod.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/k_tasks.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/mbl_lc.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/mbl_menu.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/wp.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/edit.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/mbl_log.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/fortify.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/mbl_opt.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/include/fmtheaders.h fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/md5c.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/info.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/init.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/nomenc.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/mbl_user.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/ems.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/mblutil.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/fwdovl5.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/xfwd.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/error.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/mbl_sys.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/fwdovl3.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/mbl_impo.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/initport.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/fwdovl1.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/mbl_list.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/X11/xfbbedtm.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/dos_1.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/mbl_edit.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/pac_crc.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/wp_mess.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/date.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/init_tnc.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/trajec.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/X11/xfbbedtu.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/include/xfbb.h fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/X11/xfbbpndd.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/drv_pop.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/X11/xfbbX.c 1 packages and 0 specfiles checked; 127 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- fbb.x86_64: E: incorrect-fsf-address /usr/share/doc/fbb/COPYING fbb.x86_64: W: no-manual-page-for-binary ajoursat fbb.x86_64: W: no-manual-page-for-binary satdoc fbb.x86_64: W: no-manual-page-for-binary satupdat fbb-gui.x86_64: W: no-documentation fbb-gui.x86_64: W: no-manual-page-for-binary xfbbX_cl fbb-gui.x86_64: W: no-manual-page-for-binary xfbbX fbb-gui.x86_64: W: no-manual-page-for-binary xfbb fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/fbb_orb.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/arbre.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/xfbbC.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/tncio.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/drv_hst.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/mbl_rev.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/qraloc.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/X11/xfbb.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/statis.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/kernel.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/driver.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/gesfic.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/forward.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/X11/xfbblcnx.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/include/serv.h fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/devio.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/drv_tcp.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/autobin.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/tnc.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/mbl_expo.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/ibm.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/X11/xfbbcnsl.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/X11/xfbbXcnsl.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/trait.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/modem.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/drv_ded.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/initfwd.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/nouvfwd.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/fbb_conf.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/fwdutil.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/wpserv.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/epurwp.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/console.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/pacsat.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/xfbbd.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/include/fbb_conf.h fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/waveplay.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/mbl_stat.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/themes.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/X11/xfbbmain.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/maintinf.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/serv.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/mbl_prn.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/trajovl.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/yapp.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/mbl_read.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/fwdovl6.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/fwdovl4.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/include/md5.h fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/terminal.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/clr_user.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/include/global.h fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/serveur.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/dos_dir.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/init_srv.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/drv_aea.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/variable.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/aff_stat.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/include/pbsv.h fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/conf.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/include/fbb_dec.h fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/xmodem.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/X11/xfbbabtd.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/watchdog.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/lzhuf.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/fbbgetconf.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/bidexms.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/drv_sock.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/epurmess.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/maint_fw.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/include/xfbbX.h fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/ajoursat.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/fwdovl2.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/rx25.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/warning.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/include/fbb_var.h fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/X11/xfbbXabtd.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/fwdovl7.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/include/fbb_serv.h fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/satupdat.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/exec_pg.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/redist.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/X11/xeditor.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/reqdir.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/include/crc.h fbb-debuginFinish: chroot ["echo 'rpmlint:'; rpmlint fbb fbb-gui fbb-doc fbb-debuginfo; echo 'rpmlint-done:'"] Finish: run fo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/drv_kam.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/mbl_kill.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/balise.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/drv_mod.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/k_tasks.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/mbl_lc.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/mbl_menu.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/wp.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/edit.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/mbl_log.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/fortify.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/mbl_opt.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/include/fmtheaders.h fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/md5c.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/info.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/init.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/nomenc.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/mbl_user.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/ems.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/mblutil.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/fwdovl5.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/xfwd.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/error.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/mbl_sys.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/fwdovl3.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/mbl_impo.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/initport.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/fwdovl1.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/mbl_list.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/X11/xfbbedtm.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/dos_1.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/mbl_edit.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/pac_crc.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/wp_mess.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/date.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/init_tnc.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/trajec.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/X11/xfbbedtu.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/include/xfbb.h fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/X11/xfbbpndd.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/drv_pop.c fbb-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/fbb-7.0.8-beta/src/X11/xfbbX.c 4 packages and 0 specfiles checked; 128 errors, 7 warnings. Requires -------- fbb (rpmlib, GLIBC filtered): /bin/sh config(fbb) libax25.so.0()(64bit) libc.so.6()(64bit) libm.so.6()(64bit) libncursesw.so.5()(64bit) libtinfo.so.5()(64bit) rtld(GNU_HASH) systemd fbb-gui (rpmlib, GLIBC filtered): /bin/sh fbb(x86-64) libX11.so.6()(64bit) libXext.so.6()(64bit) libXm.so.2()(64bit) libXpm.so.4()(64bit) libXt.so.6()(64bit) libax25.so.0()(64bit) libc.so.6()(64bit) libm.so.6()(64bit) rtld(GNU_HASH) fbb-doc (rpmlib, GLIBC filtered): fbb Provides -------- fbb: config(fbb) fbb fbb(x86-64) fbb-gui: fbb-gui fbb-gui(x86-64) fbb-doc: fbb-doc Source checksums ---------------- http://downloads.sourceforge.net/linfbb/fbb-7.0.8-beta.tar.bz2 : CHECKSUM(SHA256) this package : 8f6f1b1eeeedc2535910f594eea51f838755dbfa19ad2ad9547c9ec53449186f CHECKSUM(SHA256) upstream package : 8f6f1b1eeeedc2535910f594eea51f838755dbfa19ad2ad9547c9ec53449186f Comments on various things are on the way...
(In reply to Jaroslav Skarvada from comment #0) > I also moved files from /var/lib/ax25/fbb to /var/lib/fbb as the former > directory structure is not yet allowed by FHS, but the request has been > submitted and it may get into next FHS revisions. OK. > There is CRC implementation included, I am not sure whether it is problem > requiring bundling exception. I don't think that one simple implementation of CRC can be called bundling. No problem. (In reply to Jan Synacek from comment #1) > Issues: > ======= > - Package does not contain duplicates in %files. > Note: warning: File listed twice: /var/lib/fbb > See: http://fedoraproject.org/wiki/Packaging/Guidelines#DuplicateFiles > - If (and only if) the source package includes the text of the license(s) > in its own file, then that file, containing the text of the license(s) > for the package is included in %license. > Note: License file COPYING is marked as %doc instead of %license > See: > http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text These should be solved. > ===== MUST items ===== > > C/C++: > [ ]: Package does not contain kernel modules. > [ ]: Package contains no static executables. > [x]: Package does not contain any libtool archives (.la) > [x]: Rpath absent or only used for internal libs. > > Generic: > [ ]: Package is licensed with an open-source compatible license and meets > other legal requirements as defined in the legal section of Packaging > Guidelines. > [ ]: License field in the package spec file matches the actual license. > Note: Checking patched sources after %prep for licenses. Licenses > found: "GPL (v2 or later) (with incorrect FSF address)", "*No > copyright* GPL (v2 or later) (with incorrect FSF address)", "Unknown > or generated". 1 files have unknown license. Detailed output of > licensecheck in > /home/jsynacek/work/reviews/fbb/1214834-fbb/licensecheck.txt > [ ]: License file installed when any subpackage combination is installed. OK. > [ ]: Package must own all directories that it creates. > Note: Directories without known owners: /etc/ax25 I vaguely remember one package that had this problem as well. Is the directory owned by another package? > [ ]: %build honors applicable compiler flags or justifies otherwise. > [ ]: Package contains no bundled libraries without FPC exception. > [ ]: Changelog in prescribed format. > [ ]: Sources contain only permissible code or content. OK. > [ ]: Package contains desktop file if it is a GUI application. The package is not primarily a GUI application, but it does have a GUI. I leave the decision to include a desktop file to the packager. > [ ]: Development files must be in a -devel package > [ ]: Package uses nothing in %doc for runtime. > [ ]: Package consistently uses macros (instead of hard-coded directory > names). > [ ]: Package is named according to the Package Naming Guidelines. > [ ]: Package does not generate any conflict. > [ ]: Package obeys FHS, except libexecdir and /usr/target. > [ ]: If the package is a rename of another package, proper Obsoletes and > Provides are present. > [ ]: Requires correct, justified where necessary. > [ ]: Spec file is legible and written in American English. s/overrided/overridden/ in the spec, line 3. > [ ]: Package contains systemd file(s) if in need. > [ ]: Useful -debuginfo package or justification otherwise. > [ ]: Package is not known to require an ExcludeArch tag. > [ ]: Large documentation must go in a -doc subpackage. Large could be size > (~1MB) or number of files. > Note: Documentation size is 92160 bytes in 6 files. > [ ]: Package complies to the Packaging Guidelines > [x]: Package successfully compiles and builds into binary rpms on at least > one supported primary architecture. > [x]: Package installs properly. > [x]: Rpmlint is run on all rpms the build produces. > Note: There are rpmlint messages (see attachment). > [x]: Package requires other packages for directories it uses. > [x]: Package does not own files or directories owned by other packages. > [x]: All build dependencies are listed in BuildRequires, except for any > that are listed in the exceptions section of Packaging Guidelines. > [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT > [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the > beginning of %install. > [x]: Macros in Summary, %description expandable at SRPM build time. > [x]: Dist tag is present. > [x]: Permissions on files are set properly. > [x]: Package use %makeinstall only when make install DESTDIR=... doesn't > work. > [x]: Package is named using only allowed ASCII characters. > [x]: Package does not use a name that already exists. > [x]: Package is not relocatable. > [x]: Sources used to build the package match the upstream source, as > provided in the spec URL. > [x]: Spec file name must match the spec package %{name}, in the format > %{name}.spec. > [x]: File names are valid UTF-8. > [x]: Packages must not store files under /srv, /opt or /usr/local OK. > ===== SHOULD items ===== > > Generic: > [ ]: If the source package does not include license text(s) as a separate > file from upstream, the packager SHOULD query upstream to include it. > [ ]: Final provides and requires are sane (see attachments). > [ ]: Fully versioned dependency in subpackages if applicable. > Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in fbb-doc > [ ]: Package functions as described. > [ ]: Latest version is packaged. > [ ]: Package does not include license text files separate from upstream. > [ ]: Patches link to upstream bugs/comments/lists or are otherwise > justified. > [ ]: Description and summary sections in the package spec file contains > translations for supported Non-English languages, if available. > [ ]: Package should compile and build into binary rpms on all supported > architectures. > [ ]: %check is present and all tests pass. > [ ]: Packages should try to preserve timestamps of original installed > files. > [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file > [x]: Sources can be downloaded from URI in Source: tag > [x]: Reviewer should test that the package builds in mock. > [x]: Buildroot is not present > [x]: Package has no %clean section with rm -rf %{buildroot} (or > $RPM_BUILD_ROOT) > [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. > [x]: Uses parallel make %{?_smp_mflags} macro. > [x]: SourceX is a working URL. > [x]: Spec use %global instead of %define unless justified. OK. > ===== EXTRA items ===== > > Generic: > [x]: Rpmlint is run on debuginfo package(s). > Note: There are rpmlint messages (see attachment). > [x]: Rpmlint is run on all installed packages. > Note: There are rpmlint messages (see attachment). > [x]: Large data in /usr/share should live in a noarch subpackage if package > is arched. > [x]: Package should not use obsolete m4 macros > [x]: Spec file according to URL is the same as in SRPM. > > > Rpmlint > ------- > Checking: fbb-7.0.8-0.1.beta.fc21.x86_64.rpm > fbb-doc-7.0.8-0.1.beta.fc21.noarch.rpm > fbb-gui-7.0.8-0.1.beta.fc21.x86_64.rpm > fbb-7.0.8-0.1.beta.fc21.src.rpm > fbb.x86_64: E: incorrect-fsf-address /usr/share/doc/fbb/COPYING Upstream has already been notified. > fbb.x86_64: W: no-manual-page-for-binary ajoursat > fbb.x86_64: W: no-manual-page-for-binary satdoc > fbb.x86_64: W: no-manual-page-for-binary satupdat > fbb-gui.x86_64: W: no-documentation > fbb-gui.x86_64: W: no-manual-page-for-binary xfbbX_cl > fbb-gui.x86_64: W: no-manual-page-for-binary xfbbX > fbb-gui.x86_64: W: no-manual-page-for-binary xfbb No problem. > Comments on various things are on the way... I noticed that in the fbb.service, there is: ExecStart = /usr/sbin/fbb -f -l - I believe that the last argument is a typo, and should be "-N", since it's added by one of the patches.
Thanks for the review. > (In reply to Jan Synacek from comment #1) > > Issues: > > ======= > > - Package does not contain duplicates in %files. > > Note: warning: File listed twice: /var/lib/fbb > > See: http://fedoraproject.org/wiki/Packaging/Guidelines#DuplicateFiles > > - If (and only if) the source package includes the text of the license(s) > > in its own file, then that file, containing the text of the license(s) > > for the package is included in %license. > > Note: License file COPYING is marked as %doc instead of %license > > See: > > http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text > > These should be solved. > Hopefully fixed. > > [ ]: Package must own all directories that it creates. > > Note: Directories without known owners: /etc/ax25 > > I vaguely remember one package that had this problem as well. Is the > directory owned by another package? > Bug 1168929. > > [ ]: Package contains desktop file if it is a GUI application. > > The package is not primarily a GUI application, but it does have a GUI. I > leave the decision to include a desktop file to the packager. > Fixed and created simple icon :). It's not art competition winner :) but better than nothing. I will probably provide it to upstream. > > [ ]: Development files must be in a -devel package > > [ ]: Package uses nothing in %doc for runtime. > > [ ]: Package consistently uses macros (instead of hard-coded directory > > names). > > [ ]: Package is named according to the Package Naming Guidelines. > > [ ]: Package does not generate any conflict. > > [ ]: Package obeys FHS, except libexecdir and /usr/target. > > [ ]: If the package is a rename of another package, proper Obsoletes and > > Provides are present. > > [ ]: Requires correct, justified where necessary. > > [ ]: Spec file is legible and written in American English. > > s/overrided/overridden/ in the spec, line 3. > Fixed :) > I noticed that in the fbb.service, there is: > > ExecStart = /usr/sbin/fbb -f -l - > > I believe that the last argument is a typo, and should be "-N", since it's > added by one of the patches. It's OK, "-l -" means logging to the STDOUT, the functionality is added by the stdout patch. The -N option is added by the fbb script, because it is called with the NON_INTERACTIVE environment variable set to 1. Maybe I could implement it better, but I wanted to stay consistent with other packages (e.g. uronode) which also uses this environment variable. Using the same -N switch in both fbb and xfbbd could be confusing and would require re-design of the fbb script, because the option parser is called after basic interactive initialisation, which the NON_INTERACTIVE variable tries to avoid. New version: Spec URL: https://jskarvad.fedorapeople.org/fbb/fbb.spec SRPM URL: https://jskarvad.fedorapeople.org/fbb/fbb-7.0.8-0.2.beta.fc21.src.rpm
s/overriden/overridden/ in the spec, line 3 (double 'd'). Additionally: 1) [ ]: Package must own all directories that it creates. Note: Directories without known owners: /etc/ax25, /usr/share/icons/hicolor/128x128/apps, /usr/share/icons/hicolor, /usr/share/icons/hicolor/128x128 This is a false positive. The icon directories are owned by hicolor-icon-theme. 2) [ ]: gtk-update-icon-cache is invoked in %postun and %posttrans if package contains icons. Note: icons in fbb-gui This should be probably fixed. 3) Running fbb fails after just installing fbb and fbb-gui. I'm getting: $ fbb Checking fbb tree.... Error : directory /var/lib/fbb/oldmail does not exist. FBB software was not correctly installed or configured Giving up ! $ sudo systemctl start fbb $ sudo systemctl status fbb ● fbb.service - F6FBB Packet Radio BBS Loaded: loaded (/usr/lib/systemd/system/fbb.service; disabled) Active: failed (Result: exit-code) since Thu 2015-05-14 09:28:49 CEST; 2s ago Process: 823 ExecStart=/usr/sbin/fbb -f -l - (code=exited, status=1/FAILURE) Main PID: 823 (code=exited, status=1/FAILURE) May 14 09:28:49 jsynacek-ntb-work.brq.redhat.com fbb[823]: Checking fbb tree.... May 14 09:28:49 jsynacek-ntb-work.brq.redhat.com fbb[823]: Error : directory /var/lib/fbb/o.... May 14 09:28:49 jsynacek-ntb-work.brq.redhat.com fbb[823]: FBB software was not correctly i...d May 14 09:28:49 jsynacek-ntb-work.brq.redhat.com fbb[823]: Giving up ! May 14 09:28:49 jsynacek-ntb-work.brq.redhat.com systemd[1]: fbb.service: main process exit...E May 14 09:28:49 jsynacek-ntb-work.brq.redhat.com systemd[1]: Unit fbb.service entered faile.... May 14 09:28:49 jsynacek-ntb-work.brq.redhat.com systemd[1]: fbb.service failed.
(In reply to Jan Synacek from comment #4) > s/overriden/overridden/ in the spec, line 3 (double 'd'). > Fixed. > 2) [ ]: gtk-update-icon-cache is invoked in %postun and %posttrans if package > contains icons. > Note: icons in fbb-gui > > This should be probably fixed. > It is invoked, may be false positive. > 3) Running fbb fails after just installing fbb and fbb-gui. I'm getting: > > $ fbb > Checking fbb tree.... > Error : directory /var/lib/fbb/oldmail does not exist. > FBB software was not correctly installed or configured > Giving up ! > Hopefully fixed, i.e. at least not reproducible on my system :). Also added policykit policy for GUI app. I was not able to find anything about it in the guidelines, so hopefully there is no process required:) New version: Spec URL: https://jskarvad.fedorapeople.org/fbb/fbb.spec SRPM URL: https://jskarvad.fedorapeople.org/fbb/fbb-7.0.8-0.3.beta.fc21.src.rpm
Ok, I don't see any issues anymore. Approving.
New Package SCM Request ======================= Package Name: fbb Short Description: Packet radio mailbox and utilities Upstream URL: https://sourceforge.net/projects/linfbb/ Owners: jskarvad Branches: f20 f21 f22 InitialCC:
Git done (by process-git-requests).
fbb-7.0.8-0.3.beta.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/fbb-7.0.8-0.3.beta.fc22
fbb-7.0.8-0.3.beta.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/fbb-7.0.8-0.3.beta.fc21
fbb-7.0.8-0.3.beta.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/fbb-7.0.8-0.3.beta.fc20
fbb-7.0.8-0.3.beta.fc22 has been pushed to the Fedora 22 stable repository.
fbb-7.0.8-0.3.beta.fc21 has been pushed to the Fedora 21 stable repository.
fbb-7.0.8-0.3.beta.fc20 has been pushed to the Fedora 20 stable repository.