Spec URL: https://gil.fedorapeople.org/morphia.spec SRPM URL: https://gil.fedorapeople.org/morphia-0.105-1.fc20.src.rpm Description: Morphia is a lightweight type-safe library for mapping Java objects to/from MongoDB. Morphia provides a type-safe, and fluent Query API support with (run-time) validation. Morphia uses annotations so there are no XML files to manage or update. Morphia should feel very comfortable for any developer with JPA experience. Fedora Account System Username: gil
Spec URL: https://gil.fedorapeople.org/morphia.spec SRPM URL: https://gil.fedorapeople.org/morphia-0.105-1.fc20.src.rpm Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=9854592
I will take this review.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated Issues: ======= - Package does not contain duplicates in %files. Note: warning: File listed twice: /usr/share/java/morphia See: http://fedoraproject.org/wiki/Packaging/Guidelines#DuplicateFiles This is probably due to the presence of %dir %{_javadir}/%{name} in %files. - While the subpackages have dependencies generated for them by maven that result in them requiring the main package, those dependencies are unversioned. I think you should also have explicit versioned Requires in the subpackages so that it is not possible for someone to mix and match versions. ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. [x]: License file installed when any subpackage combination is installed. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Java: [x]: Bundled jar/class files should be removed before build [x]: Packages have proper BuildRequires/Requires on jpackage-utils Note: Maven packages do not need to (Build)Require jpackage-utils. It is pulled in by maven-local [x]: Javadoc documentation files are generated and included in -javadoc subpackage [x]: Javadoc subpackages should not have Requires: jpackage-utils [x]: Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink) Maven: [x]: If package contains pom.xml files install it (including metadata) even when building with ant [x]: POM files have correct Maven mapping [x]: Maven packages should use new style packaging [x]: Old add_to_maven_depmap macro is not being used [x]: Packages DO NOT have Requires(post) and Requires(postun) on jpackage- utils for %update_maven_depmap macro [x]: Package DOES NOT use %update_maven_depmap in %post/%postun [x]: Packages use .mfiles file list instead of %{_datadir}/maven2/poms ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [!]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in morphia- entityscanner-plug , morphia-guice-plug , morphia-logging-slf4j , morphia-parent , morphia-validation , morphia-javadoc [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. However, tests are run by maven during the build, so this is of no consequence. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. Java: [x]: Package uses upstream build method (ant/maven/etc.) [x]: Packages are noarch unless they use JNI ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: morphia-0.105-1.fc23.noarch.rpm morphia-entityscanner-plug-0.105-1.fc23.noarch.rpm morphia-guice-plug-0.105-1.fc23.noarch.rpm morphia-logging-slf4j-0.105-1.fc23.noarch.rpm morphia-parent-0.105-1.fc23.noarch.rpm morphia-validation-0.105-1.fc23.noarch.rpm morphia-javadoc-0.105-1.fc23.noarch.rpm morphia-0.105-1.fc23.src.rpm morphia-entityscanner-plug.noarch: W: no-documentation morphia-guice-plug.noarch: W: no-documentation morphia-logging-slf4j.noarch: W: no-documentation morphia-parent.noarch: W: no-documentation morphia-validation.noarch: W: no-documentation 8 packages and 0 specfiles checked; 0 errors, 5 warnings. Rpmlint (installed packages) ---------------------------- morphia-logging-slf4j.noarch: W: no-documentation morphia-validation.noarch: W: no-documentation morphia-entityscanner-plug.noarch: W: no-documentation morphia-guice-plug.noarch: W: no-documentation morphia-parent.noarch: W: no-documentation 7 packages and 0 specfiles checked; 0 errors, 5 warnings. Requires -------- morphia-logging-slf4j (rpmlib, GLIBC filtered): java-headless jpackage-utils mvn(org.mongodb.morphia:morphia) mvn(org.slf4j:slf4j-api) morphia-javadoc (rpmlib, GLIBC filtered): jpackage-utils morphia (rpmlib, GLIBC filtered): java-headless jpackage-utils morphia-validation (rpmlib, GLIBC filtered): java-headless jpackage-utils mvn(javax.validation:validation-api) mvn(org.mongodb.morphia:morphia) morphia-entityscanner-plug (rpmlib, GLIBC filtered): java-headless jpackage-utils mvn(com.google.collections:google-collections) mvn(org.mongodb.morphia:morphia) mvn(org.reflections:reflections) mvn(org.scannotation:scannotation) morphia-guice-plug (rpmlib, GLIBC filtered): java-headless jpackage-utils mvn(com.google.inject:guice) mvn(org.mongodb.morphia:morphia) morphia-parent (rpmlib, GLIBC filtered): java-headless jpackage-utils mvn(org.apache.maven.plugins:maven-compiler-plugin) mvn(org.apache.maven.plugins:maven-javadoc-plugin) mvn(org.apache.maven.plugins:maven-release-plugin) mvn(org.apache.maven.plugins:maven-resources-plugin) mvn(org.sonatype.oss:oss-parent:pom:) Provides -------- morphia-logging-slf4j: morphia-logging-slf4j mvn(org.mongodb.morphia:morphia-logging-slf4j) mvn(org.mongodb.morphia:morphia-logging-slf4j:pom:) morphia-javadoc: morphia-javadoc morphia: morphia mvn(org.mongodb.morphia:morphia) mvn(org.mongodb.morphia:morphia:pom:) morphia-validation: morphia-validation mvn(org.mongodb.morphia:morphia-validation) mvn(org.mongodb.morphia:morphia-validation:pom:) morphia-entityscanner-plug: morphia-entityscanner-plug mvn(org.mongodb.morphia:morphia-entityscanner-plug) mvn(org.mongodb.morphia:morphia-entityscanner-plug:pom:) morphia-guice-plug: morphia-guice-plug mvn(org.mongodb.morphia:morphia-guice-plug) mvn(org.mongodb.morphia:morphia-guice-plug:pom:) morphia-parent: morphia-parent mvn(org.mongodb.morphia:morphia-parent:pom:) Source checksums ---------------- https://github.com/mongodb/morphia/archive/0.105.tar.gz : CHECKSUM(SHA256) this package : 7c56cc019116d07334b6ad2735073d30a5775442418f9c0ef49bdabfd47e1851 CHECKSUM(SHA256) upstream package : 7c56cc019116d07334b6ad2735073d30a5775442418f9c0ef49bdabfd47e1851 Generated by fedora-review 0.5.3 (bcf15e3) last change: 2015-05-04 Command line :/usr/bin/fedora-review -b 1215080 -m fedora-rawhide-x86_64 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, Java Disabled plugins: C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
(In reply to Jerry James from comment #3) > Issues: > ======= > - Package does not contain duplicates in %files. > Note: warning: File listed twice: /usr/share/java/morphia > See: http://fedoraproject.org/wiki/Packaging/Guidelines#DuplicateFiles > > This is probably due to the presence of %dir %{_javadir}/%{name} in %files. Fixed > - While the subpackages have dependencies generated for them by maven that > result in them requiring the main package, those dependencies are > unversioned. I think you should also have explicit versioned Requires in > the subpackages so that it is not possible for someone to mix and match > versions. This/ese is a noarch package/s is not necessary add "explicit versioned Requires" there is no way to "mix and match versions", our Java tools resolve this operation Spec URL: https://gil.fedorapeople.org/morphia.spec SRPM URL: https://gil.fedorapeople.org/morphia-0.105-2.fc20.src.rpm - remove duplicate files
(In reply to gil cattaneo from comment #4) > (In reply to Jerry James from comment #3) > This/ese is a noarch package/s is not necessary add "explicit versioned > Requires" > there is no way to "mix and match versions", our Java tools resolve this > operation see inthe build.log [INFO maven.req]
Sorry, I don't know what happened there. I could have sworn that the Requires weren't versioned when I looked at them last night, but looking at them now, they clearly are versioned. Anyway, I see no further issues, so this package is APPROVED.
Thanks for the review! New Package SCM Request ======================= Package Name: morphia Short Description: A type-safe Java library for MongoDB Upstream URL: https://github.com/mongodb/morphia Owners: gil Branches: f22 InitialCC: java-sig
Git done (by process-git-requests).
morphia-0.105-2.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/morphia-0.105-2.fc22
morphia-0.105-3.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/morphia-0.105-3.fc22
morphia-0.105-3.fc22 has been pushed to the Fedora 22 testing repository.
morphia-0.105-3.fc22 has been pushed to the Fedora 22 stable repository.