Bug 826038 - Review Request: proxytoys - An implementation neutral API for creation of dynamic proxies
Summary: Review Request: proxytoys - An implementation neutral API for creation of dyn...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Till Hofmann
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1215071 1215080
TreeView+ depends on / blocked
 
Reported: 2012-05-29 12:50 UTC by gil cattaneo
Modified: 2015-06-05 23:58 UTC (History)
4 users (show)

Fixed In Version: proxytoys-1.0-3.fc22
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-06-05 23:58:03 UTC
Type: ---
Embargoed:
thofmann: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description gil cattaneo 2012-05-29 12:50:36 UTC
Spec URL: http://gil.fedorapeople.org/proxytoys.spec
SRPM URL: http://gil.fedorapeople.org/proxytoys-0.2.1-1.fc16.src.rpm
Description: ProxyToys provides a collection of toys acting as factories for
creating "special" proxies such as:

* Decorators - for simple AOP-like chained method interception
* Delegates - for method invocation on a delegate object,
  that might have different type
* Dispatcher proxy - single proxy instance dispatching method
  calls to different object with separate types
* Echo proxy - for tracing method calls
* Failover objects - fails over to a next object in case of
  exception
* Hot swapping proxy - allows implementation hiding that
  can be swapped, and mutual dependencies
* Multicasting objects - for multicasting a method invocation
  to multiple objects
* Null objects - for default implementations of classes that
  do nothing at all
* Pool - for a pool implemntation with proxied objects that
  return automatically to the pool
Fedora Account System Username: gil

tested on: http://koji.fedoraproject.org/koji/taskinfo?taskID=4111547

Comment 3 gil cattaneo 2013-11-21 07:57:14 UTC
Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=6208370

Comment 4 Mikolaj Izdebski 2015-02-12 05:10:01 UTC
Build fails.

Comment 5 gil cattaneo 2015-02-12 15:18:50 UTC
(In reply to Mikolaj Izdebski from comment #4)
> Build fails.

Spec URL: http://gil.fedorapeople.org/proxytoys.spec
SRPM URL: http://gil.fedorapeople.org/proxytoys-1.0-2.fc20.src.rpm

Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=8909418

Comment 6 gil cattaneo 2015-04-02 08:58:15 UTC
Spec URL: http://gil.fedorapeople.org/proxytoys.spec
SRPM URL: http://gil.fedorapeople.org/proxytoys-1.0-3.fc20.src.rpm

- fix test deps

Comment 7 gil cattaneo 2015-04-02 09:24:36 UTC
Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=9398539

Comment 8 gil cattaneo 2015-04-27 18:12:52 UTC
Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=9579742

Comment 9 Till Hofmann 2015-05-26 13:33:04 UTC
Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed

==== Issues ====
[!]: Package must own all directories that it creates.
     Note: Directories without known owners: /usr/share/maven-
     poms/proxytoys


===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated". 79 files have unknown license.
[x]: License file installed when any subpackage combination is installed.
[x]: Package requires other packages for directories it uses.
     Note: No known owner of /usr/share/maven-poms/proxytoys
[!]: Package must own all directories that it creates.
     Note: Directories without known owners: /usr/share/maven-
     poms/proxytoys
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

Java:
[x]: Bundled jar/class files should be removed before build
[x]: Packages have proper BuildRequires/Requires on jpackage-utils
     Note: Maven packages do not need to (Build)Require jpackage-utils. It
     is pulled in by maven-local
[x]: Javadoc documentation files are generated and included in -javadoc
     subpackage
[x]: Javadoc subpackages should not have Requires: jpackage-utils
[x]: Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink)

Maven:
[x]: If package contains pom.xml files install it (including metadata) even
     when building with ant
[x]: POM files have correct Maven mapping
[x]: Maven packages should use new style packaging
[x]: Old add_to_maven_depmap macro is not being used
[x]: Packages DO NOT have Requires(post) and Requires(postun) on jpackage-
     utils for %update_maven_depmap macro
[x]: Package DOES NOT use %update_maven_depmap in %post/%postun
[x]: Packages use .mfiles file list instead of %{_datadir}/maven2/poms

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
     proxytoys-example-code , proxytoys-javadoc
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise
     justified.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

Java:
[x]: Package uses upstream build method (ant/maven/etc.)
[x]: Packages are noarch unless they use JNI

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: proxytoys-1.0-3.fc21.noarch.rpm
          proxytoys-example-code-1.0-3.fc21.noarch.rpm
          proxytoys-javadoc-1.0-3.fc21.noarch.rpm
          proxytoys-1.0-3.fc21.src.rpm
proxytoys.noarch: W: spelling-error %description -l en_US multicasting -> simulcasting, multitasking, masticating
proxytoys.noarch: W: spelling-error %description -l en_US proxied -> proxies, peroxided
proxytoys.noarch: W: no-documentation
proxytoys-example-code.noarch: W: no-documentation
proxytoys.src: W: spelling-error %description -l en_US multicasting -> simulcasting, multitasking, masticating
proxytoys.src: W: spelling-error %description -l en_US proxied -> proxies, peroxided
4 packages and 0 specfiles checked; 0 errors, 6 warnings.




Rpmlint (installed packages)
----------------------------
proxytoys.noarch: W: spelling-error %description -l en_US multicasting -> simulcasting, multitasking, masticating
proxytoys.noarch: W: spelling-error %description -l en_US proxied -> proxies, peroxided
proxytoys.noarch: W: no-documentation
proxytoys-example-code.noarch: W: no-documentation
3 packages and 0 specfiles checked; 0 errors, 4 warnings.



Requires
--------
proxytoys (rpmlib, GLIBC filtered):
    java-headless
    jpackage-utils
    mvn(cglib:cglib)

proxytoys-example-code (rpmlib, GLIBC filtered):
    java-headless
    jpackage-utils
    mvn(com.thoughtworks.proxytoys:proxytoys)

proxytoys-javadoc (rpmlib, GLIBC filtered):
    jpackage-utils



Provides
--------
proxytoys:
    mvn(com.thoughtworks.proxytoys:proxytoys)
    mvn(com.thoughtworks.proxytoys:proxytoys-parent:pom:)
    mvn(com.thoughtworks.proxytoys:proxytoys:pom:)
    mvn(proxytoys:proxytoys)
    mvn(proxytoys:proxytoys:pom:)
    proxytoys

proxytoys-example-code:
    mvn(com.thoughtworks.proxytoys:proxytoys-example-code)
    mvn(com.thoughtworks.proxytoys:proxytoys-example-code:pom:)
    proxytoys-example-code

proxytoys-javadoc:
    proxytoys-javadoc



Source checksums
----------------
https://github.com/proxytoys/proxytoys/archive/6f4d22725ef28f09bfd5422939b83e1865b5daef/proxytoys-6f4d22725ef28f09bfd5422939b83e1865b5daef.tar.gz :
  CHECKSUM(SHA256) this package     : 7c356184f7963b912eda79433cde4d37de15a31860de87bdfc872b545d3f6e34
  CHECKSUM(SHA256) upstream package : 7c356184f7963b912eda79433cde4d37de15a31860de87bdfc872b545d3f6e34


Generated by fedora-review 0.5.3 (bcf15e3) last change: 2015-05-04
Command line :/usr/bin/fedora-review -b 826038
Buildroot used: fedora-21-x86_64
Active plugins: Generic, Shell-api, Java
Disabled plugins: C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6

Comment 10 Till Hofmann 2015-05-26 13:45:38 UTC
Non-blocking issues:
     Package must own all directories that it creates.
     Note: Directories without known owners: /usr/share/maven-
     poms/proxytoys
Please fix this before pushing the package.

APPROVED

Comment 11 gil cattaneo 2015-05-26 13:58:43 UTC
(In reply to Till Hofmann from comment #10)
> Non-blocking issues:
>      Package must own all directories that it creates.
>      Note: Directories without known owners: /usr/share/maven-
>      poms/proxytoys
> Please fix this before pushing the package.
this directory should be handled/owner by maven/java tools
> APPROVED

Thanks!

Comment 12 gil cattaneo 2015-05-26 13:59:52 UTC
New Package SCM Request
=======================
Package Name: proxytoys
Short Description: An implementation neutral API for creation of dynamic proxies
Upstream URL: http://proxytoys.codehaus.org/
Owners: gil
Branches: f22
InitialCC: java-sig

Comment 13 Gwyn Ciesla 2015-05-26 19:19:24 UTC
Git done (by process-git-requests).

Comment 14 Fedora Update System 2015-05-26 20:55:56 UTC
proxytoys-1.0-3.fc22 has been submitted as an update for Fedora 22.
https://admin.fedoraproject.org/updates/proxytoys-1.0-3.fc22

Comment 15 Fedora Update System 2015-05-28 12:03:39 UTC
proxytoys-1.0-3.fc22 has been pushed to the Fedora 22 testing repository.

Comment 16 Fedora Update System 2015-06-05 23:58:03 UTC
proxytoys-1.0-3.fc22 has been pushed to the Fedora 22 stable repository.


Note You need to log in before you can comment on or make changes to this bug.