+++ This bug was initially created as a clone of Bug #1212385 +++ Description of problem: RPC throttling is enabled for all rpcsvc programs. While the NFS rpcsvc program can benefit from throttling, the glusterfs rpcsvc program does not need throttling. Version-Release number of selected component (if applicable): How reproducible: Steps to Reproduce: 1. 2. 3. Actual results: Expected results: Additional info: --- Additional comment from Anand Avati on 2015-04-16 06:11:54 EDT --- REVIEW: http://review.gluster.org/10267 (rpc: Introduce attribute throttle for rpcsvc_t) posted (#1) for review on master by Vijay Bellur (vbellur) --- Additional comment from Anand Avati on 2015-04-16 06:11:59 EDT --- REVIEW: http://review.gluster.org/10268 (rpc: Perform throttling conditionally) posted (#1) for review on master by Vijay Bellur (vbellur) --- Additional comment from Anand Avati on 2015-04-16 06:12:03 EDT --- REVIEW: http://review.gluster.org/10269 (nfs: Enable throttling for rpcsvc) posted (#1) for review on master by Vijay Bellur (vbellur) --- Additional comment from Anand Avati on 2015-04-16 06:29:08 EDT --- REVIEW: http://review.gluster.org/10267 (rpc: Introduce attribute throttle for rpcsvc_t) posted (#2) for review on master by Vijay Bellur (vbellur) --- Additional comment from Anand Avati on 2015-04-16 06:29:16 EDT --- REVIEW: http://review.gluster.org/10269 (nfs: Enable throttling for rpcsvc) posted (#2) for review on master by Vijay Bellur (vbellur) --- Additional comment from Anand Avati on 2015-04-16 06:29:21 EDT --- REVIEW: http://review.gluster.org/10268 (rpc: Perform throttling conditionally) posted (#2) for review on master by Vijay Bellur (vbellur) --- Additional comment from Anand Avati on 2015-04-29 00:30:45 EDT --- COMMIT: http://review.gluster.org/10267 committed in master by Raghavendra G (rgowdapp) ------ commit b04b957f2f27cf03958b456b3cec097d1e04923c Author: Vijay Bellur <vbellur> Date: Mon Apr 6 12:34:55 2015 +0530 rpc: Introduce attribute throttle for rpcsvc_t This attribute will be used to set/unset throttling for a rpcsvc_t program subsequently. Following APIs have been added to get/set throttle. int rpcsvc_set_throttle (rpcsvc_t svc, gf_boolean_t value); gf_boolean_t rpcsvc_get_throttle (rpcsvc_t svc); Change-Id: Ica8a9166cef22eb92d81fe68e48d0a5e24a1ef95 BUG: 1212385 Signed-off-by: Vijay Bellur <vbellur> Reviewed-on: http://review.gluster.org/10267 Tested-by: NetBSD Build System Reviewed-by: Niels de Vos <ndevos> Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Raghavendra G <rgowdapp> Tested-by: Raghavendra G <rgowdapp> --- Additional comment from Anand Avati on 2015-04-29 00:31:28 EDT --- COMMIT: http://review.gluster.org/10268 committed in master by Raghavendra G (rgowdapp) ------ commit 32c35e175ac362a9682b10600044a5fe17441176 Author: Vijay Bellur <vbellur> Date: Mon Apr 6 12:55:13 2015 +0530 rpc: Perform throttling conditionally This change makes rpc's throttling to be performed only if attribute throttle is set in rpcsvc_t. Change-Id: I24620095570e206f5dc8fc6208fcf55cb22a1658 BUG: 1212385 Signed-off-by: Vijay Bellur <vbellur> Reviewed-on: http://review.gluster.org/10268 Tested-by: NetBSD Build System Reviewed-by: Niels de Vos <ndevos> Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Raghavendra G <rgowdapp> Tested-by: Raghavendra G <rgowdapp> --- Additional comment from Anand Avati on 2015-04-29 00:31:46 EDT --- COMMIT: http://review.gluster.org/10269 committed in master by Raghavendra G (rgowdapp) ------ commit 2bde49f98964724b9e12255539bd1a91b3c8b086 Author: Vijay Bellur <vbellur> Date: Mon Apr 6 17:30:02 2015 +0530 nfs: Enable throttling for rpcsvc Busy nfs servers need throttling to prevent duplicate requests from casuing an increase in memory consumption. Change-Id: I855bb1e841ba06b523e55f86f7788a0f7a49d444 BUG: 1212385 Signed-off-by: Vijay Bellur <vbellur> Reviewed-on: http://review.gluster.org/10269 Tested-by: NetBSD Build System Reviewed-by: Niels de Vos <ndevos> Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Raghavendra G <rgowdapp> Tested-by: Raghavendra G <rgowdapp>
REVIEW: http://review.gluster.org/10442 (rpc: Introduce attribute throttle for rpcsvc_t) posted (#1) for review on release-3.7 by Vijay Bellur (vbellur)
REVIEW: http://review.gluster.org/10443 (rpc: Perform throttling conditionally) posted (#1) for review on release-3.7 by Vijay Bellur (vbellur)
REVIEW: http://review.gluster.org/10444 (nfs: Enable throttling for rpcsvc) posted (#1) for review on release-3.7 by Vijay Bellur (vbellur)
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report. glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution. [1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939 [2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user