Created attachment 1020511 [details]
update maven notation

- generate pom file
- use new javapackages macros
- introduce %%license macro
- remove some rpmlint problems (mixed-use-of-spaces-and-tabs)
- adapt to current guideline
- add alias alias for backward compatibility

Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=9606006

This bug appears to have been reported against 'rawhide' during the Fedora 23 development cycle.
Changing version to '23'.

(As we did not run this process for some time, it could affect also pre-Fedora 23 development
cycle bugs. We are very sorry. It will help us with cleanup during Fedora 23 End Of Life. Thank you.)

More information and reason for this action is here:
https://fedoraproject.org/wiki/BugZappers/HouseKeeping/Fedora23

Thanks for the report.

This all should be fixed by rebase to new version of postgresql-jdbc.  Once
done, I'll close this as duplicate of bug 1196445.

(In reply to Pavel Raiskup from comment #3)
> Thanks for the report.
> 
> This all should be fixed by rebase to new version of postgresql-jdbc.  Once
> done, I'll close this as duplicate of bug 1196445.

It's ok for me. Thanks

Created attachment 1169531 [details]
update maven notation

- fix rhbz#1217395
- generate pom file
- use new javapackages macros
- introduce %license macro
- disable doclint
- remove some rpmlint problems (mixed-use-of-spaces-and-tabs)
- adapt to current guideline

Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=14565015

gil, sorry for the delay -- could you please rebase your patches against
actual 'master' branch?

(In reply to Pavel Raiskup from comment #6)
> gil, sorry for the delay -- could you please rebase your patches against
> actual 'master' branch?

No, problems. but is not possible merge the changes in https://bugzilla.redhat.com/show_bug.cgi?id=1358134#c2 in other branches?

I would like to avoid merging this, what exactly you would like to have
in stable fedoras?

Also, I've removed the postgresql-jdbc.jar symlink, which will probably
break some 'weka' runtime scripts.  Should I restore that symlink?

There is similar issue with libreoffice, I'll try to contact maintainers.

I've reverted the postgresql-jdbc.jar symlink.

(In reply to Pavel Raiskup from comment #10)
> I've reverted the postgresql-jdbc.jar symlink.

try with
%mvn_file org.postgresql:postgresql %{name}/postgresql %{name}
before %mvn_package macro

(In reply to gil cattaneo from comment #11)
> (In reply to Pavel Raiskup from comment #10)
> > I've reverted the postgresql-jdbc.jar symlink.
> 
> try with
# compat symlink: requested by dtardon (libreoffice), reverts part of
# 0af97ce32de877 commit.
> %mvn_file org.postgresql:postgresql %{name}/postgresql %{name}
> before %mvn_package macro

and remove

pushd $RPM_BUILD_ROOT%{_javadir}
# compat symlink: requested by dtardon (libreoffice), reverts part of
# 0af97ce32de877 commit.
ln -s %{name}/postgresql.jar postgresql-jdbc.jar
popd

gil, can you please re-attach patch with requested changes?  That would really
simplify things.

But just please keep the comment saying why the compat postgresql-jdbc.jar
exists.

Created attachment 1182329 [details]
fix postgresql-jdbc.jar symlink using javapackages macros

- remove some rpmlint problems (mixed-use-of-spaces-and-tabs)
- adapt to current guideline
- install doc and license file in parent-poms sub package
- simplified runselftest check

Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=14965976

Thanks!  Gil, pushed with one slight modification -- I removed the
tab2space change, as the tabs are in majority of PostgreSQL related packages
and I don't want to change it with respect to history of that package :)
(it is kind of sentimental).  Also, I'm not sure -- my F24 version of rpmlint
was silent before and so it is now (the mixed-use-of-spaces-and-tabs).  Is
that still an issue?

I'm closing and thanks again!  If there are some issues, feel free to discuss.
http://pkgs.fedoraproject.org/cgit/rpms/postgresql-jdbc.git/commit/?id=668b4398f9c43

(In reply to Pavel Raiskup from comment #15)
> Thanks!  Gil, pushed with one slight modification -- I removed the
> tab2space change, as the tabs are in majority of PostgreSQL related packages
> and I don't want to change it with respect to history of that package :)
> (it is kind of sentimental). 
my patch was only some suggestion for adapt spec file with the current guideline
> was silent before and so it is now (the mixed-use-of-spaces-and-tabs).  Is
> that still an issue?
Is not an issues but it makes the file spec a little more clean and to eliminate some problems, in less, with rpmlint
> I'm closing and thanks again!  If there are some issues, feel free to
> discuss.
> http://pkgs.fedoraproject.org/cgit/rpms/postgresql-jdbc.git/commit/
> ?id=668b4398f9c43
again thanks
regards