Bug 1217587 - oo-admin-ctl-district command's district argument requirement is unnecessary
Summary: oo-admin-ctl-district command's district argument requirement is unnecessary
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Node
Version: 2.2.0
Hardware: Unspecified
OS: Unspecified
high
low
Target Milestone: ---
: ---
Assignee: Brenton Leanhardt
QA Contact: libra bugs
URL:
Whiteboard:
Depends On: 1216191
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-04-30 18:08 UTC by Brenton Leanhardt
Modified: 2015-07-21 19:12 UTC (History)
13 users (show)

Fixed In Version: openshift-origin-broker-util-1.34.1.1-1.el6op
Doc Type: Bug Fix
Doc Text:
Previously, all oo-admin-ctl-district commands required that the district name or UUID was specified. This made performing actions on multiple node hosts using oo-admin-ctl-district impossible if they were not in the same district. Additionally, finding the district a node host belonged to was difficult, requiring the administrator to sift through all district node hosts. This bug fix updates oo-admin-ctl-district to allow the district not to be specified for numerous actions; the district can still be specified manually with --uuid or --name options. As a result, the oo-admin-ctl-district command now searches for the correct district if no district is specified, and administrators can additionally perform actions on numerous node hosts across multiple districts.
Clone Of: 1216191
Environment:
Last Closed: 2015-07-21 19:12:34 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2015:1463 0 normal SHIPPED_LIVE Red Hat OpenShift Enterprise 2.2.6 bug fix and enhancement update 2015-07-21 23:11:33 UTC

Description Brenton Leanhardt 2015-04-30 18:08:51 UTC
+++ This bug was initially created as a clone of Bug #1216191 +++

Description of problem:

There are two issues with oo-admin-ctl-district requiring the district name for most subcommands:

1) It's valid to pass a comma-separated list of server identities to a subcommand, but unless all of the servers happen to be in the same district, there's not a valid district name which can be passed.

2) Looking up which district a given server belongs to is an awkward process for an administrator, but it's a single line of code in the script.  We should not make admins do this manually.

My upcoming PR will allow a district to be specified, but will search for it when it is omitted.

--- Additional comment from Andy Grimm on 2015-04-28 13:41:43 EDT ---

https://github.com/openshift/origin-server/pull/6130

--- Additional comment from Sten Turpin on 2015-04-28 13:58:01 EDT ---



--- Additional comment from Andy Grimm on 2015-04-28 14:24:06 EDT ---

stage PR https://github.com/openshift/origin-server/pull/6131

--- Additional comment from openshift-github-bot on 2015-04-28 16:55:01 EDT ---

Commit pushed to master at https://github.com/openshift/origin-server

https://github.com/openshift/origin-server/commit/1f0626caae582f3bd65cd1de6eb34c73c6683a1e
Bug 1216191 - oo-admin-ctl-district: look up district by server if not specified

Comment 5 errata-xmlrpc 2015-07-21 19:12:34 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2015-1463.html


Note You need to log in before you can comment on or make changes to this bug.