Bug 1218961 - snapshot: Can not activate the name provided while creating snaps to do any further access
Summary: snapshot: Can not activate the name provided while creating snaps to do any f...
Keywords:
Status: CLOSED CANTFIX
Alias: None
Product: GlusterFS
Classification: Community
Component: snapshot
Version: 3.7.0
Hardware: All
OS: Linux
unspecified
urgent
Target Milestone: ---
Assignee: bugs@gluster.org
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks: glusterfs-3.7.3
TreeView+ depends on / blocked
 
Reported: 2015-05-06 09:59 UTC by M S Vishwanath Bhat
Modified: 2016-06-01 01:56 UTC (History)
8 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-07-23 06:37:54 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description M S Vishwanath Bhat 2015-05-06 09:59:38 UTC
Description of problem:
REGRESSION - The snap name provided while creating the snap is pretty much useless. Because they can't be used to do any further snapshot operations. This is breaking something which was working earlier. Hence this is a regression.

Version-Release number of selected component (if applicable):
glusterfs-3.7 branch

How reproducible:
Always

Steps to Reproduce:
1. Create a snap with snapname 'snap0'
2. Try to activate the snap with snap0
3. Try to delete the snap with 'snap0'

Actual results:

<bash#> gluster snapshot create snap0 hosdu
snapshot create: success: Snap snap0_GMT-2015.04.30-14.58.30 created successfully

<bash#> gluster snapshot activate snap0
 Snapshot command failed
 snapshot activate: failed: Snapshot (snap0) does not exist.

Expected results:
I should be able to activate the snapshot using the same name I give.

I am aware of --no-timestamp option, but without that backward compatibility is broken.

Additional info:

I am aware of the requirement that lead to this change. But that is no reason to introduce a regression. Backward compatibility must not be broken.


Proposed solution is to provide the access to snaps both by the name as provided by the user and the name generated by the glusterd. The only thing you might have to change in snap-scheduler.py is to increment the snap-name each time a snap is taken. I don't think this is very had thing to do.

Comment 1 Niels de Vos 2015-06-02 08:20:16 UTC
The required changes to fix this bug have not made it into glusterfs-3.7.1. This bug is now getting tracked for glusterfs-3.7.2.

Comment 2 Niels de Vos 2015-06-20 10:08:04 UTC
Unfortunately glusterfs-3.7.2 did not contain a code change that was associated with this bug report. This bug is now proposed to be a blocker for glusterfs-3.7.3.

Comment 3 Avra Sengupta 2015-07-23 06:37:54 UTC
There is an option no-timestamp that allows the user to create snapshots with the name supplied by the user. This is a preferred way of taking snapshots going forward. Hence closing the bug.


Note You need to log in before you can comment on or make changes to this bug.