Bug 1219388 - Do not let an inode evict during split-brain resolution process.
Summary: Do not let an inode evict during split-brain resolution process.
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: replicate
Version: 3.7.0
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Anuradha
QA Contact:
URL:
Whiteboard:
Depends On: 1209104
Blocks: glusterfs-3.7.1
TreeView+ depends on / blocked
 
Reported: 2015-05-07 08:31 UTC by Anuradha
Modified: 2016-09-20 02:00 UTC (History)
3 users (show)

Fixed In Version: glusterfs-3.7.0
Doc Type: Bug Fix
Doc Text:
Clone Of: 1209104
Environment:
Last Closed: 2015-05-14 17:29:38 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Anuradha 2015-05-07 08:31:51 UTC
+++ This bug was initially created as a clone of Bug #1209104 +++

Description of problem:

During split-brain resolution from mount, an inode may get evicted from table even before inspection/resolution is complete, leading to failure. This should not happen.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

--- Additional comment from Anand Avati on 2015-04-06 06:39:36 EDT ---

REVIEW: http://review.gluster.org/10134 (cluster/afr : Prevent inode-evict during split-brain resolution) posted (#1) for review on master by Anuradha Talur (atalur)

--- Additional comment from Anand Avati on 2015-04-06 09:25:16 EDT ---

REVIEW: http://review.gluster.org/10134 (cluster/afr : Prevent inode-evict during split-brain resolution) posted (#2) for review on master by Niels de Vos (ndevos)

--- Additional comment from Anand Avati on 2015-04-16 06:54:22 EDT ---

REVIEW: http://review.gluster.org/10134 (cluster/afr : Prevent inode-evict during split-brain resolution) posted (#3) for review on master by Anuradha Talur (atalur)

--- Additional comment from Anand Avati on 2015-04-16 07:00:04 EDT ---

REVIEW: http://review.gluster.org/10134 (cluster/afr : Prevent inode-evict during split-brain resolution) posted (#4) for review on master by Anuradha Talur (atalur)

--- Additional comment from Anand Avati on 2015-04-17 08:33:20 EDT ---

REVIEW: http://review.gluster.org/10134 (cluster/afr : Prevent inode-evict during split-brain resolution) posted (#6) for review on master by Anuradha Talur (atalur)

--- Additional comment from Anand Avati on 2015-04-17 08:40:42 EDT ---

REVIEW: http://review.gluster.org/10134 (cluster/afr : Prevent inode-evict during split-brain resolution) posted (#7) for review on master by Anuradha Talur (atalur)

--- Additional comment from Anand Avati on 2015-04-17 09:08:14 EDT ---

REVIEW: http://review.gluster.org/10134 (cluster/afr : Prevent inode-evict during split-brain resolution) posted (#8) for review on master by Anuradha Talur (atalur)

--- Additional comment from Anand Avati on 2015-04-27 06:59:53 EDT ---

REVIEW: http://review.gluster.org/10134 (cluster/afr : Prevent inode-evict during split-brain resolution) posted (#9) for review on master by Anuradha Talur (atalur)

--- Additional comment from Anand Avati on 2015-04-27 07:15:00 EDT ---

REVIEW: http://review.gluster.org/10134 (cluster/afr : Prevent inode-evict during split-brain resolution) posted (#10) for review on master by Anuradha Talur (atalur)

--- Additional comment from Anand Avati on 2015-04-30 06:05:58 EDT ---

REVIEW: http://review.gluster.org/10134 (cluster/afr : Prevent inode-evict during split-brain resolution) posted (#11) for review on master by Anuradha Talur (atalur)

--- Additional comment from Anand Avati on 2015-05-06 01:57:39 EDT ---

REVIEW: http://review.gluster.org/10134 (cluster/afr : Prevent inode-evict during split-brain resolution) posted (#12) for review on master by Anuradha Talur (atalur)

Comment 1 Anand Avati 2015-05-07 08:40:01 UTC
REVIEW: http://review.gluster.org/10624 (cluster/afr : Prevent inode-evict during split-brain resolution) posted (#1) for review on release-3.7 by Anuradha Talur (atalur)

Comment 2 Anand Avati 2015-05-07 08:51:37 UTC
REVIEW: http://review.gluster.org/10624 (cluster/afr : Prevent inode-evict during split-brain resolution) posted (#2) for review on release-3.7 by Anuradha Talur (atalur)

Comment 3 Anand Avati 2015-05-08 13:59:08 UTC
REVIEW: http://review.gluster.org/10679 (cluster/afr : Prevent inode-evict during split-brain resolution) posted (#1) for review on release-3.7 by Anuradha Talur (atalur)

Comment 4 Anand Avati 2015-05-09 05:01:42 UTC
REVIEW: http://review.gluster.org/10679 (cluster/afr : Prevent inode-evict during split-brain resolution) posted (#2) for review on release-3.7 by Anuradha Talur (atalur)

Comment 5 Anand Avati 2015-05-09 08:55:02 UTC
COMMIT: http://review.gluster.org/10679 committed in release-3.7 by Pranith Kumar Karampuri (pkarampu) 
------
commit 719c927592cfdb0de88243769d477ca211a2b494
Author: Anuradha <atalur>
Date:   Sat May 9 10:25:08 2015 +0530

    cluster/afr : Prevent inode-evict during split-brain resolution
    
            Backport of: http://review.gluster.org/#/c/10134/
    
    1) Provided setfattr command to set timeout for split-brain
    choice.
    
    2) If split-brain inspection/resolution is being done
    from the mount for a file, ref the inode when
    split-brain-choice is set.
    This inode will be unconditionally unref-ed after timeout
    seconds set by the user/default otherwise.
    
    3) Updated the doc and testcase to reflect the changes.
    
    Change-Id: I15c9037dee28855f21e680e7e3632e1f48dba4e1
    BUG: 1219388
    Reviewed-on: http://review.gluster.org/10134
    Reviewed-by: Krutika Dhananjay <kdhananj>
    Reviewed-by: Ravishankar N <ravishankar>
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Pranith Kumar Karampuri <pkarampu>
    Signed-off-by: Anuradha <atalur>
    Reviewed-on: http://review.gluster.org/10679

Comment 6 Niels de Vos 2015-05-14 17:29:38 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 7 Niels de Vos 2015-05-14 17:36:01 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 8 Niels de Vos 2015-05-14 17:38:22 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 9 Niels de Vos 2015-05-14 17:47:23 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user


Note You need to log in before you can comment on or make changes to this bug.