Bug 1220100 - Typos in the messages logged by the CTR translator
Summary: Typos in the messages logged by the CTR translator
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: tiering
Version: 3.7.0
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: ---
Assignee: Joseph Elwin Fernandes
QA Contact: bugs@gluster.org
URL:
Whiteboard:
Depends On: 1215896
Blocks: 1260923
TreeView+ depends on / blocked
 
Reported: 2015-05-10 05:10 UTC by Joseph Elwin Fernandes
Modified: 2016-06-20 00:01 UTC (History)
4 users (show)

Fixed In Version: glusterfs-3.7.0
Clone Of: 1215896
Environment:
Last Closed: 2015-05-15 17:10:10 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Joseph Elwin Fernandes 2015-05-10 05:10:36 UTC
+++ This bug was initially created as a clone of Bug #1215896 +++

Description of problem:

There are several typos and missing punctuation in the messages written to the brick logs by the changetimerecorder translator.

1.
[ctr-helper.c:249:extract_ctr_options] 0-gfdbdatastore: CTR Xlator is Disable!

should be 
[ctr-helper.c:249:extract_ctr_options] 0-gfdbdatastore: CTR Xlator is disabled. 


2.
0-patchy-changetimerecorder: Failed retriving sql-db-pagesize from paramsAssigning default value: 4096

Typo : retrieving. Though "Failed to retrieve" might be better.
Missing punctuation (period) before "Assigning"








Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:
No typos. Exclamation marks in log messages are usually unnecessary.

Additional info:

--- Additional comment from Anand Avati on 2015-05-08 07:10:10 EDT ---

REVIEW: http://review.gluster.org/10668 (CTR/Libgfdb: Log typo fix) posted (#1) for review on master by Joseph Fernandes (josferna)

--- Additional comment from Anand Avati on 2015-05-08 09:15:23 EDT ---

REVIEW: http://review.gluster.org/10668 (CTR/Libgfdb: Log typo fix) posted (#2) for review on master by Joseph Fernandes (josferna)

--- Additional comment from Anand Avati on 2015-05-10 01:00:21 EDT ---

REVIEW: http://review.gluster.org/10668 (CTR/Libgfdb: Log typo fix) posted (#3) for review on master by Vijay Bellur (vbellur)

Comment 1 Anand Avati 2015-05-10 05:13:06 UTC
REVIEW: http://review.gluster.org/10741 (CTR/Libgfdb: Log typo fix) posted (#1) for review on master by Joseph Fernandes (josferna)

Comment 2 Anand Avati 2015-05-10 05:27:05 UTC
REVIEW: http://review.gluster.org/10742 (CTR/Libgfdb: Log typo fix) posted (#1) for review on release-3.7 by Joseph Fernandes (josferna)

Comment 3 Anand Avati 2015-05-10 06:22:54 UTC
REVIEW: http://review.gluster.org/10742 (CTR/Libgfdb: Log typo fix) posted (#2) for review on release-3.7 by Vijay Bellur (vbellur)

Comment 4 Niels de Vos 2015-05-15 17:10:10 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user


Note You need to log in before you can comment on or make changes to this bug.