Bug 1221926 - hosted-engine - cloud-init - missing VM FQDN validation
Summary: hosted-engine - cloud-init - missing VM FQDN validation
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-hosted-engine-setup
Classification: oVirt
Component: General
Version: 1.3.0
Hardware: Unspecified
OS: Unspecified
high
medium
Target Milestone: ovirt-3.6.2
: 1.3.2
Assignee: Simone Tiraboschi
QA Contact: Nikolai Sednev
URL:
Whiteboard:
Depends On:
Blocks: 1293565 1293654
TreeView+ depends on / blocked
 
Reported: 2015-05-15 09:31 UTC by Sandro Bonazzola
Modified: 2016-02-18 11:05 UTC (History)
9 users (show)

Fixed In Version: ovirt-hosted-engine-setup-1.3.2-1
Doc Type: Bug Fix
Doc Text:
Better validating the engine VM fqdn if the user chooses to configure it via cloud-init.
Clone Of:
Environment:
Last Closed: 2016-02-18 11:05:02 UTC
oVirt Team: Integration
Embargoed:
rule-engine: ovirt-3.6.z+
ylavi: planning_ack+
sbonazzo: devel_ack+
mavital: testing_ack+


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 42781 0 master ABANDONED packaging: setup: validate VM instance name Never
oVirt gerrit 49228 0 None None None Never
oVirt gerrit 49250 0 master MERGED setup: better validate engine VM hostname 2015-12-21 17:19:09 UTC
oVirt gerrit 50861 0 ovirt-hosted-engine-setup-1.3 MERGED setup: better validate engine VM hostname 2015-12-22 10:12:59 UTC

Description Sandro Bonazzola 2015-05-15 09:31:13 UTC
using cloud-init support in hosted engine the FQDN of the VM is not validated during the customization and it will fail in a later stage where the FQDN is validated.
The FQDN should be verified right after it's inserted.

Current behaviour:

...
          --== VM CONFIGURATION ==--
         
          Please specify the device to boot the VM from (cdrom, disk, pxe) [cdrom]: disk
          Would you like to use cloud-init to customize the appliance on the first boot (Yes, No)[Yes]? 
          Would you like to generate on-fly a cloud-init no-cloud ISO image
          or do you have an existing one (Generate, Existing)[Generate]? 
          Please provide the FQDN you would like to use for the engine appliance.
          Note: This will be the FQDN of the engine VM you are now going to launch,
          it should not point to the base host or to any other existing machine.
          Engine VM FQDN: (leave it empty to skip): ovirt.home
          Enter root password that will be used for the engine appliance (leave it empty to skip): 
...
          --== HOSTED ENGINE CONFIGURATION ==--
         
          Enter the name which will be used to identify this host inside the Administrator Portal [hosted_engine_1]: 
          Enter 'admin@internal' user password that will be used for accessing the Administrator Portal: 
          Confirm 'admin@internal' user password: 
[ ERROR ] Failed to execute stage 'Environment customization': Host name is not valid: ovirt.home did not resolve into an IP address
[ INFO  ] Stage: Clean up
[ INFO  ] Generating answer file '/var/lib/ovirt-hosted-engine-setup/answers/answers-20150515112303.conf'
[ INFO  ] Stage: Pre-termination
[ INFO  ] Stage: Termination

Comment 1 Red Hat Bugzilla Rules Engine 2015-10-19 10:59:19 UTC
Target release should be placed once a package build is known to fix a issue. Since this bug is not modified, the target version has been reset. Please use target milestone to plan a fix for a oVirt release.

Comment 2 Yaniv Lavi 2015-10-29 12:15:52 UTC
In oVirt testing is done on single release by default. Therefore I'm removing the 4.0 flag. If you think this bug must be tested in 4.0 as well, please re-add the flag. Please note we might not have testing resources to handle the 4.0 clone.

Comment 3 Sandro Bonazzola 2015-11-26 20:29:57 UTC
This should be on ovirt-setup-lib.

Comment 4 Sandro Bonazzola 2015-12-23 13:42:12 UTC
oVirt 3.6.2 RC1 has been released for testing, moving to ON_QA

Comment 5 Nikolai Sednev 2016-01-14 15:47:24 UTC
Deployed appliance rhevm-appliance-20151216.0-1.x86_64.rhevm.ova on Red Hat Enterprise Virtualization Hypervisor (Beta) release 7.2 (20160107.0.el7ev) over iSCSI SD.

Works for me on these components:
foovirt-hosted-engine-setup-1.3.2.2-1.el7ev.noarch
ovirt-node-plugin-vdsm-0.6.1-4.el7ev.noarch
ovirt-setup-lib-1.0.1-1.el7ev.noarch
ovirt-node-branding-rhev-3.6.1-2.0.el7ev.noarch
ovirt-host-deploy-1.4.1-1.el7ev.noarch
ovirt-vmconsole-host-1.0.0-1.el7ev.noarch
ovirt-node-lib-config-3.6.1-2.0.el7ev.noarch
ovirt-node-lib-3.6.1-2.0.el7ev.noarch
libvirt-1.2.17-13.el7_2.2.x86_64
ovirt-node-3.6.1-2.0.el7ev.noarch
ovirt-node-plugin-snmp-logic-3.6.1-2.0.el7ev.noarch
qemu-kvm-rhev-2.3.0-31.el7_2.4.x86_64
ovirt-hosted-engine-ha-1.3.3.6-1.el7ev.noarch
ovirt-node-plugin-hosted-engine-0.3.0-6.el7ev.noarch
ovirt-host-deploy-offline-1.4.0-1.el7ev.x86_64
ovirt-node-plugin-snmp-3.6.1-2.0.el7ev.noarch
ovirt-node-plugin-rhn-3.6.1-2.0.el7ev.noarch
sanlock-3.2.4-1.el7.x86_64
ovirt-vmconsole-1.0.0-1.el7ev.noarch
mom-0.5.1-1.el7ev.noarch
ovirt-node-lib-legacy-3.6.1-2.0.el7ev.noarch
ovirt-node-selinux-3.6.1-2.0.el7ev.noarch
ovirt-node-plugin-cim-logic-3.6.1-2.0.el7ev.noarch
vdsm-4.17.16-0.el7ev.noarch
ovirt-node-plugin-cim-3.6.1-2.0.el7ev.noarch

[ INFO  ] Checking OVF archive content (could take a few minutes depending on archive size)
[ INFO  ] Checking OVF XML content (could take a few minutes depending on archive size)
[WARNING] OVF does not contain a valid image description, using default.
          Would you like to use cloud-init to customize the appliance on the first boot (Yes, No)[Yes]? 
          Would you like to generate on-fly a cloud-init no-cloud ISO image
          or do you have an existing one (Generate, Existing)[Generate]? 
          Please provide the FQDN you would like to use for the engine appliance.
          Note: This will be the FQDN of the engine VM you are now going to launch,
          it should not point to the base host or to any other existing machine.
          Engine VM FQDN: (leave it empty to skip):  []: ovirt.home
[ ERROR ] Host name is not valid: ovirt.home did not resolve into an IP address
          Please provide the FQDN you would like to use for the engine appliance.
          Note: This will be the FQDN of the engine VM you are now going to launch,
          it should not point to the base host or to any other existing machine.
          Engine VM FQDN: (leave it empty to skip):  []:


Note You need to log in before you can comment on or make changes to this bug.