Bug 1223318 - brick-op failure for glusterd command should log error message in cmd_history.log
Summary: brick-op failure for glusterd command should log error message in cmd_history...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: glusterd
Version: 3.7.0
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Atin Mukherjee
QA Contact:
URL:
Whiteboard:
Depends On: 1219732
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-05-20 10:25 UTC by Atin Mukherjee
Modified: 2015-07-30 09:49 UTC (History)
2 users (show)

Fixed In Version: glusterfs-3.7.3
Doc Type: Bug Fix
Doc Text:
Clone Of: 1219732
Environment:
Last Closed: 2015-07-30 09:49:31 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Atin Mukherjee 2015-05-20 10:25:53 UTC
+++ This bug was initially created as a clone of Bug #1219732 +++

Description of problem:

In glusterd brick-op if underlying transport connection is broken between glusterd and brick, then the command fails with a blank error message

Version-Release number of selected component (if applicable):
Mainline

How reproducible:
Always

Steps to Reproduce:
1.Create a volume & start it
2. Take the glusterd process in gdb and put a break point in gd_syncop_submit_request () and continue
3. Stop the volume
3. the breakpoint will be hit, and set to ret to -1 after rpc_clnt_submit () is executed

Actual results:
In cmd_history.log the command will be logged as failed with no error message

Expected results:
error message should be logged.

Additional info:

--- Additional comment from Anand Avati on 2015-05-08 00:30:38 EDT ---

REVIEW: http://review.gluster.org/10659 (glusterd: populate errstr if gd_syncop_submit_request fails) posted (#1) for review on master by Atin Mukherjee (amukherj)

--- Additional comment from Anand Avati on 2015-05-08 02:40:45 EDT ---

REVIEW: http://review.gluster.org/10659 (glusterd: populate errstr if gd_syncop_submit_request fails) posted (#2) for review on master by Atin Mukherjee (amukherj)

--- Additional comment from Anand Avati on 2015-05-20 05:30:34 EDT ---

COMMIT: http://review.gluster.org/10659 committed in master by Vijay Bellur (vbellur) 
------
commit 988db25572b94220a7cc69bcc3040c2a77b8e9a5
Author: Atin Mukherjee <amukherj>
Date:   Fri May 8 09:53:50 2015 +0530

    glusterd: populate errstr if gd_syncop_submit_request fails
    
    Change-Id: Ie4a3edef5d553fc07de53b46f9485c46a4305245
    BUG: 1219732
    Signed-off-by: Atin Mukherjee <amukherj>
    Reviewed-on: http://review.gluster.org/10659
    Tested-by: Gluster Build System <jenkins.com>
    Tested-by: NetBSD Build System
    Reviewed-by: Krishnan Parthasarathi <kparthas>
    Tested-by: Krishnan Parthasarathi <kparthas>

Comment 1 Anand Avati 2015-05-20 10:26:58 UTC
REVIEW: http://review.gluster.org/10838 (glusterd: populate errstr if gd_syncop_submit_request fails) posted (#1) for review on release-3.7 by Atin Mukherjee (amukherj)

Comment 2 Anand Avati 2015-06-18 04:11:35 UTC
REVIEW: http://review.gluster.org/10838 (glusterd: populate errstr if gd_syncop_submit_request fails) posted (#4) for review on release-3.7 by Atin Mukherjee (amukherj)

Comment 3 Kaushal 2015-07-30 09:49:31 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.3, please open a new bug report.

glusterfs-3.7.3 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/12078
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user


Note You need to log in before you can comment on or make changes to this bug.