Hide Forgot
Spec URL: https://raphgro.fedorapeople.org/review/locker/light-locker.spec SRPM URL: https://raphgro.fedorapeople.org/review/locker/light-locker-1.6.0-1.fc22.src.rpm Description: A simple session-locker for lightdm Fedora Account System Username: raphgro http://koji.fedoraproject.org/koji/taskinfo?taskID=9854416
naming: ok sources: ok 7f2425887d7bc8e86b53846f400d4ace light-locker-1.6.0.tar.bz2 1. licensing: NOT ok using licensecheck, it's clear all sources are GPLv2, so MUST use: License: GPLv2+ 2. scriptlets NOT ok, MUST add gsettings schema scriplets, see https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#GSettings_Schema 3. SHOULD drop desktop-file-validate %{buildroot}%{_sysconfdir}/xdg/autostart/*.desktop no need to validate autostart, only stuff under /usr/share/applications/ 4. MUST do verbose build (to show compiler flags), either use %configure --disable-silent-rules and/or make ... V=1 As a practical matter, it worries my a little that it seems to conditionally autostart based on DE used (regardless if lightdm is active or not?). this feels wrong to me, but I don't have any suggestions on how to improve that offhand.
Spec URL: https://raphgro.fedorapeople.org/review/locker/light-locker.spec SRPM URL: https://raphgro.fedorapeople.org/review/locker/light-locker-1.6.0-2.fc22.src.rpm rawhide build: http://koji.fedoraproject.org/koji/taskinfo?taskID=10218012 epel7 build: http://koji.fedoraproject.org/koji/taskinfo?taskID=10218073 * Fri Jun 26 2015 Raphael Groner <> - 1.6.0-2 - fix license, enhance build options, add gsettings schema scriplets (In reply to Rex Dieter from comment #1) … > 3. SHOULD drop > desktop-file-validate %{buildroot}%{_sysconfdir}/xdg/autostart/*.desktop > no need to validate autostart, only stuff under /usr/share/applications/ Well, I do that intentionally. There's an issue with NotShowIn and a patch provided, see also the upstream issue. … > As a practical matter, it worries my a little that it seems to conditionally > autostart based on DE used (regardless if lightdm is active or not?). this > feels wrong to me, but I don't have any suggestions on how to improve that > offhand. Not sure what you mean. The DE should provide an on/off switch. What DE could be problematic in that matter?
Thanks, APPROVED
New Package SCM Request ======================= Package Name: light-locker Short Description: Upstream URL: https://github.com/the-cavalry/light-locker Owners: raphgro Branches: f22 f21 epel7 InitialCC:
New Package SCM Request ======================= Package Name: light-locker Short Description: A simple session-locker for lightdm Upstream URL: https://github.com/the-cavalry/light-locker Owners: raphgro Branches: f22 f21 epel7 InitialCC:
Git done (by process-git-requests).
light-locker-1.6.0-2.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/light-locker-1.6.0-2.fc22
light-locker-1.6.0-2.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/light-locker-1.6.0-2.fc21
light-locker-1.6.0-2.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/light-locker-1.6.0-2.el7
light-locker-1.6.0-2.fc22 has been pushed to the Fedora 22 testing repository.
Raphael, your fixes for the desktop file don't seem correct: 1. First you fix NotShowIn and then you use sed to remove the key, so your patch becomes useless. 2. You will also need this patch: https://github.com/the-cavalry/light-locker/commit/1c23309c2f6a Please also configure with --enable-lock-on-suspend=on instead of --enable-lock-on-suspend=yes because the Red Hat security response team wants machines to be locked after waking up from suspend (see bug 614608 and bug 632978). "on" means we do it by default whereas "yes" means just having the option to do it, but that requires changing the command line in the desktop file that starts light-locker.
(In reply to Christoph Wickert from comment #11) > Raphael, your fixes for the desktop file don't seem correct: > > 1. First you fix NotShowIn and then you use sed to remove the key, so your > patch becomes useless. Yeah, this is currently b0rken, as mentioned in the comments. > 2. You will also need this patch: > https://github.com/the-cavalry/light-locker/commit/1c23309c2f6a Thanks. > Please also configure with > > --enable-lock-on-suspend=on > > instead of > > --enable-lock-on-suspend=yes > > because the Red Hat security response team wants machines to be locked after > waking up from suspend (see bug 614608 and bug 632978). "on" means we do it > by default whereas "yes" means just having the option to do it, but that > requires changing the command line in the desktop file that starts > light-locker. Sure. Thanks a lot for these hints. Next update will include both fixes.
light-locker-1.6.0-3.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/light-locker-1.6.0-3.fc22
light-locker-1.6.0-4.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/light-locker-1.6.0-4.fc22
light-locker-1.6.0-4.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/light-locker-1.6.0-4.fc21
light-locker-1.6.0-4.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/light-locker-1.6.0-4.el7
light-locker-1.6.0-4.el7 has been pushed to the Fedora EPEL 7 testing repository.
bodhi - 2015-07-17 22:25:16 (karma: 0) This update has reached 7 days in testing and can be pushed to stable now if the maintainer wishes Well, it might be better to push with light-locker-settings in combination to improve the user experience. But still waiting for a reviewer in bug #1225231.
Transition to systemd. Is that Debian Bug (#779749) somehow relevant, also for Fedora? Upstream issue: https://github.com/the-cavalry/light-locker/issues/64
light-locker-1.6.0-4.fc21 has been pushed to the Fedora 21 stable repository.
light-locker-1.6.0-4.fc22 has been pushed to the Fedora 22 stable repository.
light-locker-1.6.0-4.el7 has been pushed to the Fedora EPEL 7 stable repository.
Enable search for light-locker bugs.