Bug 1227572 - Sharding - Fix posix compliance test failures.
Summary: Sharding - Fix posix compliance test failures.
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: sharding
Version: 3.7.0
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Krutika Dhananjay
QA Contact: bugs@gluster.org
URL:
Whiteboard:
Depends On: 1223759
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-06-03 04:07 UTC by Krutika Dhananjay
Modified: 2015-07-30 09:48 UTC (History)
2 users (show)

Fixed In Version: glusterfs-3.7.3
Doc Type: Bug Fix
Doc Text:
Clone Of: 1223759
Environment:
Last Closed: 2015-06-20 09:49:30 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Krutika Dhananjay 2015-06-03 04:07:41 UTC
+++ This bug was initially created as a clone of Bug #1223759 +++

Description of problem:
There are a bunch of posix compliance tests that fail because of sharding translator not appropriately handling fops on symlinks.
This BZ is to be associated with all the patches sent to fix these issues.


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

--- Additional comment from Anand Avati on 2015-05-29 04:34:25 EDT ---

REVIEW: http://review.gluster.org/10995 (features/shard: Handle symlinks appropriately in fops) posted (#1) for review on master by Krutika Dhananjay (kdhananj)

--- Additional comment from Anand Avati on 2015-05-30 06:07:23 EDT ---

REVIEW: http://review.gluster.org/10995 (features/shard: Handle symlinks appropriately in fops) posted (#2) for review on master by Niels de Vos (ndevos)

--- Additional comment from Anand Avati on 2015-05-31 22:58:07 EDT ---

REVIEW: http://review.gluster.org/10995 (features/shard: Handle symlinks appropriately in fops) posted (#3) for review on master by Krutika Dhananjay (kdhananj)

Comment 1 Anand Avati 2015-06-03 04:10:32 UTC
REVIEW: http://review.gluster.org/11051 (features/shard: Fix incorrect parameter to get_lowest_block()) posted (#1) for review on release-3.7 by Krutika Dhananjay (kdhananj)

Comment 2 Anand Avati 2015-06-03 13:41:22 UTC
REVIEW: http://review.gluster.org/11066 (features/shard: Handle symlinks appropriately in fops) posted (#1) for review on release-3.7 by Krutika Dhananjay (kdhananj)

Comment 3 Anand Avati 2015-06-04 01:59:38 UTC
COMMIT: http://review.gluster.org/11051 committed in release-3.7 by Pranith Kumar Karampuri (pkarampu) 
------
commit ebeab96411947ca73c946422aef8af9bcd88ff05
Author: Krutika Dhananjay <kdhananj>
Date:   Sat May 16 21:23:48 2015 +0530

    features/shard: Fix incorrect parameter to get_lowest_block()
    
            Backport of: http://review.gluster.org/10804
    
    Due to get_lowest_block() being a macro, what needs to be passed
    to it is the evaluation of the expression (local->offset - 1), without
    which its substitution can cause junk values to be assigned to
    local->first_block.
    
    This patch also fixes calls to get_highest_block() where if offset and
    size are both equal to zero, it could return negative values.
    
    Change-Id: I8f1bc54b536587d6af3a5c193434d06dccbf76dc
    BUG: 1227572
    Signed-off-by: Krutika Dhananjay <kdhananj>
    Reviewed-on: http://review.gluster.org/11051
    Tested-by: Gluster Build System <jenkins.com>
    Tested-by: NetBSD Build System <jenkins.org>
    Reviewed-by: Pranith Kumar Karampuri <pkarampu>

Comment 4 Anand Avati 2015-06-07 06:02:41 UTC
COMMIT: http://review.gluster.org/11066 committed in release-3.7 by Vijay Bellur (vbellur) 
------
commit 53b3c38f47251aff361c55005def8e3940114aa1
Author: Krutika Dhananjay <kdhananj>
Date:   Thu May 21 14:58:26 2015 +0530

    features/shard: Handle symlinks appropriately in fops
    
            Backport of: http://review.gluster.org/10995
    
    (f)stat, unlink and rename must skip doing inode_ctx_get()
    of shard block size on symbolic links.
    
    Change-Id: Iaf2502512a5838db137e5e1f0c14b12f5058865f
    BUG: 1227572
    Signed-off-by: Krutika Dhananjay <kdhananj>
    Reviewed-on: http://review.gluster.org/11066
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Pranith Kumar Karampuri <pkarampu>
    Tested-by: NetBSD Build System <jenkins.org>

Comment 5 Krutika Dhananjay 2015-06-19 08:44:11 UTC
Moving the bug back to ASSIGNED state as there are a couple more patches that need to go in (some of them not yet sent) before it can be moved to MODIFIED.

Comment 6 Anand Avati 2015-06-20 05:05:03 UTC
REVIEW: http://review.gluster.org/11332 (features/shard: Skip shards resolution if lookup on /.shard returns ENOENT) posted (#1) for review on release-3.7 by Krutika Dhananjay (kdhananj)

Comment 7 Niels de Vos 2015-06-20 09:49:30 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.2, please reopen this bug report.

glusterfs-3.7.2 has been announced on the Gluster Packaging mailinglist [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://www.gluster.org/pipermail/packaging/2015-June/000006.html
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 8 Kaushal 2015-07-30 09:48:45 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.3, please open a new bug report.

glusterfs-3.7.3 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/12078
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user


Note You need to log in before you can comment on or make changes to this bug.