Fedora Account System
Red Hat Associate
Red Hat Customer
Spec URL: https://corsepiu.fedorapeople.org/packages/perl-Cookie-Baker.spec SRPM URL: https://corsepiu.fedorapeople.org/packages/perl-Cookie-Baker-0.05-1.fc23.src.rpm Description: Cookie::Baker provides simple cookie string generator and parser. Fedora Account System Username: corsepiu
URL and Source0 are usable. Ok. Source archive is original (SHA-256: 28c0e2bcda793a55d77ab166e6ab6b5eb5c69c58f326d2b550f32a0b9520a98c). Ok. Summary verified from lib/Cookie/Baker.pm. Ok. Description verified from lib/Cookie/Baker.pm. Ok. License verified from lib/Cookie/Baker.pm, README.md, LICENSE. Ok. No XS code, noarch BuildArch is Ok. FIX: Build-require `perl(File::Basename)' (Build.PL:13). FIX: Build-require `perl(File::Copy)' (Build.PL:54). FIX: Build-require `perl(File::Spec)' (Build.PL:14). FIX: Build-require `perl(utf8)' (Build.PL:10). Cookie::Baker::XS is optional. Ok. FIX: Build-require `findutils' (perl-Cookie-Baker.spec:35). FIX: Build-require `coreutils' (perl-Cookie-Baker.spec:35). FATAL: `perl(Test::Time)' dependency is not available in Fedora. Please correct all these issue, especially package Test::Time first. Resolution: Package NOT approved.
Any progress?
To make this clear: Due to the attitude Mr. Pisar repeatedly has displayed, I am not any longer accepting Mr. Pisar as reviewer.
I'll take this one. Ralf, can you update your spec file, taking into account Petr's comments?
Ralf, have you been able to move forward on this?
Update: https://corsepiu.fedorapeople.org/packages/perl-Cookie-Baker.spec https://corsepiu.fedorapeople.org/packages/perl-Cookie-Baker-0.06-1.fc24.src.rpm
=== KEY === - = N/A x = Check ! = Problem ? = Not evaluated === REQUIRED ITEMS === [*] Package is named according to the Package Naming Guidelines. [*] Spec file name must match the base package %{name}, in the format %{name}.spec. [*] Package meets the Packaging Guidelines including the Perl specific items [*] Package successfully compiles and builds into binary rpms on at least one supported architecture. Tested on: http://koji.fedoraproject.org/koji/taskinfo?taskID=14347754 [*] Rpmlint output: 2 packages and 1 specfiles checked; 0 errors, 0 warnings. [*] Package is not relocatable. [*] Buildroot is correct None specified, default used [*] Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [*] License field in the package spec file matches the actual license. License type: GPL+ or Artistic [*] If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [*] Spec file is legible and written in American English. [*] Sources used to build the package matches the upstream source, as provided in the spec URL. 7b51cd44122e2a18e46e94f4f9d843f5 Cookie-Baker-0.06.tar.gz [*] Package is not known to require ExcludeArch [*] All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [-] The spec file handles locales properly. [-] ldconfig called in %post and %postun if required. [*] Package must own all directories that it creates. [*] Package requires other packages for directories it uses. [*] Package does not contain duplicates in %files. [*] Permissions on files are set properly. [*] Package consistently uses macros. [*] Package contains code, or permissable content. [-] Large documentation files are in a -doc subpackage, if required. [-] Package uses nothing in %doc for runtime. [-] Header files in -devel subpackage, if present. [-] Static libraries in -devel subpackage, if present. [-] Package requires pkgconfig, if .pc files are present. [-] Development .so files in -devel subpackage, if present. [-] Fully versioned dependency in subpackages, if present. [*] Package does not contain any libtool archives (.la). [-] Package contains a properly installed %{name}.desktop file if it is a GUI application. [*] Package does not own files or directories owned by other packages. === SUGGESTED ITEMS === [*] Latest version is packaged. [*] Package does not include license text files separate from upstream. [-] Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [*] Reviewer should test that the package builds in mock. Tested on: fedora-rawhide.x86_64 [*] Package should compile and build into binary rpms on all supported architectures. Tested on: http://koji.fedoraproject.org/koji/taskinfo?taskID=14347754 [*] Package functions as described. [-] Scriptlets must be sane, if used. [-] The placement of pkgconfig(.pc) files is correct. [-] File based requires are sane. [*] %check is present and the tests pass All tests successful. Files=3, Tests=49, 0 wallclock secs ( 0.04 usr 0.01 sys + 0.19 cusr 0.04 csys = 0.28 CPU) Result: PASS Binary requires and provides are all OK. I like to tighten the file listing as much as possible but this is by no means a blocker. Package APPROVED.
Thanks for the review, Emmanuel. (In reply to Emmanuel Seyman from comment #7) > I like to tighten the file listing as much as possible but this is by no > means a blocker. That's something I personally consider to be contradicting to simplicity of maintenance and to be introducing avoidable effort.
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/perl-Cookie-Baker
perl-Cookie-Baker-0.06-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-6c34a4ccaa
perl-Cookie-Baker-0.06-1.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-0578df5386
perl-Cookie-Baker-0.06-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-6c34a4ccaa
perl-Cookie-Baker-0.06-1.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-0578df5386
perl-Cookie-Baker-0.06-1.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.
perl-Cookie-Baker-0.06-1.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.