Hide Forgot
Spec URL: http://people.parinux.org/~seyman/fedora/perl-Test-Time/perl-Test-Time.spec SRPM URL: http://people.parinux.org/~seyman/fedora/perl-Test-Time/perl-Test-Time-0.04-1.fc23.src.rpm Description: Test::Time can be used to test modules that deal with time. Once you use this module, all references to time and sleep will be internalized. You can set custom time by passing time => number after the use statement. Fedora Account System Username: eseyman Rpmlint Output: 2 packages and 1 specfiles checked; 0 errors, 0 warnings. Third time's the charm, right?
Source file is ok Summary is ok License is ok URL and Source0 are ok All tests passed $ rpm -qp --requires perl-Test-Time-0.04-1.fc25.noarch.rpm | sort | uniq -c 1 perl(:MODULE_COMPAT_5.22.1) 1 perl(Test::More) 1 perl(strict) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 Binary requires are Ok. $ rpm -qp --provides perl-Test-Time-0.04-1.fc25.noarch.rpm | sort | uniq -c 1 perl(Test::Time) = 0.04 1 perl-Test-Time = 0.04-1.fc25 Binary provides are Ok. $ rpmlint ./perl-Test-Time* 2 packages and 1 specfiles checked; 0 errors, 0 warnings. Rpmlint is ok BuildRequires FIX: * Please add missing BRs - perl(Module::Install::Include) - provides auto_include - Makefile.PL:43 - perl(Module::Install::Metadata) - provides all_from - Makefile.PL:24 - perl(Module::Install::WriteAll) - provides WriteAll - Makefile.PL:44 * Removed BRs - perl(Filter::Util::Call) - it is not used TODO: Because you remove all files from repository inc, it could be done easily, e.g. rm -r inc sed -i -e '/^inc\// d' MANIFEST In that case, the 'findutils' could be removed from BRs TODO: You can replace %__perl macros with plain perl command. Description is ok TODO: Please replace ':' at the end of description with '.' Please correct 'FIX' issue and consider fixing 'TODO' items and provide new spec file. The package is not approved
(In reply to Jitka Plesnikova from comment #1) > Source file is ok > Summary is ok > License is ok > URL and Source0 are ok > All tests passed > > $ rpm -qp --requires perl-Test-Time-0.04-1.fc25.noarch.rpm | sort | uniq -c > 1 perl(:MODULE_COMPAT_5.22.1) > 1 perl(Test::More) > 1 perl(strict) > 1 perl(warnings) > 1 rpmlib(CompressedFileNames) <= 3.0.4-1 > 1 rpmlib(FileDigests) <= 4.6.0-1 > 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 > 1 rpmlib(PayloadIsXz) <= 5.2-1 > Binary requires are Ok. > > $ rpm -qp --provides perl-Test-Time-0.04-1.fc25.noarch.rpm | sort | uniq -c > 1 perl(Test::Time) = 0.04 > 1 perl-Test-Time = 0.04-1.fc25 > Binary provides are Ok. > > $ rpmlint ./perl-Test-Time* > 2 packages and 1 specfiles checked; 0 errors, 0 warnings. > Rpmlint is ok > > BuildRequires > FIX: > * Please add missing BRs > - perl(Module::Install::Include) - provides auto_include - Makefile.PL:43 > - perl(Module::Install::Metadata) - provides all_from - Makefile.PL:24 > - perl(Module::Install::WriteAll) - provides WriteAll - Makefile.PL:44 > * Removed BRs > - perl(Filter::Util::Call) - it is not used Done. > TODO: Because you remove all files from repository inc, it could be done > easily, e.g. > rm -r inc > sed -i -e '/^inc\// d' MANIFEST > > In that case, the 'findutils' could be removed from BRs Indeed. Done. > Description is ok > TODO: Please replace ':' at the end of description with '.' Done. Spec URL: http://people.parinux.org/~seyman/fedora/perl-Test-Time/perl-Test-Time.spec SRPM URL: http://people.parinux.org/~seyman/fedora/perl-Test-Time/perl-Test-Time-0.04-2.fc23.src.rpm
It looks good now. Approved
Built for rawhide, updates have been issued for f23 and f24. Jikta, thank you for the review.