Spec URL: http://michael.cronenworth.com/RPMS/php-cdb.spec SRPM URL: http://michael.cronenworth.com/RPMS/php-cdb-1.0.1-1.fc21.src.rpm Description: CDB functions for PHP, split out of mediawiki Fedora Account System Username: mooninite $ rpmlint php-cdb.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. $ rpmlint ~/rpmbuild/SRPMS/php-cdb-1.0.1-1.fc21.src.rpm php-cdb.src: W: spelling-error %description -l en_US dba -> dab, db, bad 1 packages and 0 specfiles checked; 0 errors, 1 warnings.
* Shouldn't source come from https://github.com/wikimedia/cdb as that's where Composer installs from? -- https://packagist.org/packages/wikimedia/cdb * Per https://fedoraproject.org/wiki/Packaging:PHP#Naming_scheme, name should be "php-wikimedia-cdb" * Per https://fedoraproject.org/wiki/Packaging:PHP#File_Placement, install path should be "/usr/share/php/Cdb/*" to be PSR-0 compliant * Per https://fedoraproject.org/wiki/Packaging:PHP#Composer_registered_Packages, need to provide "php-composer(wikimedia/cdb) = %{version}" * Tests are provided so they should be run in %check
http://michael.cronenworth.com/RPMS/php-wikimedia-cdb.spec http://michael.cronenworth.com/RPMS/php-wikimedia-cdb-1.0.1-2.fc21.src.rpm Upstream is Wikimedia's git. Why is it preferred to use the github mirror? The provided test can only be loaded through composer.
See #1231356 for a simple fix to run the test suite.
Added tests and composer.json. http://michael.cronenworth.com/RPMS/php-wikimedia-cdb.spec http://michael.cronenworth.com/RPMS/php-wikimedia-cdb-1.0.1-3.fc22.src.rpm
Created attachment 1043006 [details] phpci.log phpCompatInfo version 4.3.0 DB built Jun 21 2015 20:17:04 CEST static analyze results
Created attachment 1043007 [details] review.txt Generated by fedora-review 0.5.3 (bcf15e3) last change: 2015-05-04
[!]: License field in the package spec file matches the actual license. from file headers * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation; either version 2 of the License, or * (at your option) any later version. => GPLv2+ [~]: Requires correct, justified where necessary. missing php-spl (because of autoloader) php-dba is optional, but ok (packager choice).
Thanks for catching the missing +. The php-dba package is required to perform the unit test. http://michael.cronenworth.com/RPMS/php-wikimedia-cdb.spec http://michael.cronenworth.com/RPMS/php-wikimedia-cdb-1.0.1-4.fc22.src.rpm
-License: GPLv2 +License: GPLv2+ [x]: License field in the package spec file matches the actual license. +Requires: php-spl [x]: Requires correct, justified where necessary. === APPROVED ===
Thanks for the review. New Package SCM Request ======================= Package Name: php-wikimedia-cdb Short Description: CDB functions for PHP Upstream URL: http://www.mediawiki.org/wiki/CDB Owners: mooninite Branches: f21 f22 InitialCC:
Git done (by process-git-requests).
Jon, the repo hasn't been made. Can you re-run?
this runs asynchronously and should exist by now.
Ugh. I was typing "wikipedia" instead of "wikimedia". :(
php-wikimedia-cdb-1.0.1-1.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/php-wikimedia-cdb-1.0.1-1.fc22
php-wikimedia-cdb-1.0.1-1.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/php-wikimedia-cdb-1.0.1-1.fc21
php-wikimedia-cdb-1.0.1-1.fc22 has been pushed to the Fedora 22 testing repository.
php-wikimedia-cdb-1.0.1-1.fc21 has been pushed to the Fedora 21 stable repository.
php-wikimedia-cdb-1.0.1-1.fc22 has been pushed to the Fedora 22 stable repository.