Spec URL: http://michael.cronenworth.com/RPMS/php-StatsdClient.spec SRPM URL: http://michael.cronenworth.com/RPMS/php-StatsdClient-1.0.16-1.fc21.noarch.rpm Description: Object Oriented Client for etsy/statsd written in php, broken out from mediawiki Fedora Account System Username: mooninite $ rpmlint php-StatsdClient.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. $ rpmlint ~/rpmbuild/SRPMS/php-StatsdClient-1.0.16-1.fc21.src.rpm php-StatsdClient.src: W: spelling-error Summary(en_US) etsy -> Betsy, easy, tsetse php-StatsdClient.src: W: spelling-error Summary(en_US) statsd -> stats, stated, stats d php-StatsdClient.src: W: spelling-error %description -l en_US statsd -> stats, stated, stats d php-StatsdClient.src: W: spelling-error %description -l en_US etsy -> Betsy, easy, tsetse 1 packages and 0 specfiles checked; 0 errors, 4 warnings.
* Per https://fedoraproject.org/wiki/Packaging:PHP#Naming_scheme, name should be "php-liuggio-statsd-php-client" * Per https://fedoraproject.org/wiki/Packaging:PHP#File_Placement, install path should be "/usr/share/php/Liuggio/StatsdClient/*" to be PSR-0 compliant * Per https://fedoraproject.org/wiki/Packaging:PHP#Composer_registered_Packages, need to provide "php-composer(liuggio/statsd-php-client) = %{version}" * Tests are provided so they should be run in %check
http://michael.cronenworth.com/RPMS/php-liuggio-statsd-php-client.spec http://michael.cronenworth.com/RPMS/php-liuggio-statsd-php-client-1.0.16-2.fc21.src.rpm The provided test can only be loaded through composer.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 22 files have unknown license. Detailed output of licensecheck in /home/tom/1231355-php-liuggio-statsd-php- client/licensecheck.txt [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. PHP: [x]: Run phpci static analyze on all php files. Note: phpCompatInfo version 4.2.0 DB built May 22 2015 19:29:18 CEST static analyze results in /home/tom/1231355-php-liuggio-statsd-php- client/phpci.log Rpmlint ------- Checking: php-liuggio-statsd-php-client-1.0.16-2.fc23.noarch.rpm php-liuggio-statsd-php-client-1.0.16-2.fc23.src.rpm php-liuggio-statsd-php-client.noarch: W: spelling-error Summary(en_US) etsy -> Betsy, easy, tsetse php-liuggio-statsd-php-client.noarch: W: spelling-error %description -l en_US etsy -> Betsy, easy, tsetse php-liuggio-statsd-php-client.noarch: E: script-without-shebang /usr/share/php/Liuggio/StatsdClient/Entity/StatsdData.php php-liuggio-statsd-php-client.noarch: E: script-without-shebang /usr/share/php/Liuggio/StatsdClient/Entity/StatsdDataInterface.php php-liuggio-statsd-php-client.src: W: spelling-error Summary(en_US) etsy -> Betsy, easy, tsetse php-liuggio-statsd-php-client.src: W: spelling-error %description -l en_US etsy -> Betsy, easy, tsetse 2 packages and 0 specfiles checked; 2 errors, 4 warnings. Rpmlint (installed packages) ---------------------------- php-liuggio-statsd-php-client.noarch: W: spelling-error Summary(en_US) etsy -> Betsy, easy, tsetse php-liuggio-statsd-php-client.noarch: W: spelling-error %description -l en_US etsy -> Betsy, easy, tsetse php-liuggio-statsd-php-client.noarch: E: script-without-shebang /usr/share/php/Liuggio/StatsdClient/Entity/StatsdData.php php-liuggio-statsd-php-client.noarch: E: script-without-shebang /usr/share/php/Liuggio/StatsdClient/Entity/StatsdDataInterface.php 1 packages and 0 specfiles checked; 2 errors, 2 warnings. Requires -------- php-liuggio-statsd-php-client (rpmlib, GLIBC filtered): php(language) Provides -------- php-liuggio-statsd-php-client: php-composer(liuggio/statsd-php-client) php-liuggio-statsd-php-client Source checksums ---------------- https://github.com/liuggio/statsd-php-client/archive/v1.0.16.tar.gz#/php-liuggio-statsd-php-client-1.0.16.tar.gz : CHECKSUM(SHA256) this package : c0dd89d7d8eccbbe6705833bb3e9404e7334719823f6ec6cafd753e458bee2a7 CHECKSUM(SHA256) upstream package : c0dd89d7d8eccbbe6705833bb3e9404e7334719823f6ec6cafd753e458bee2a7 Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20 Command line :/usr/bin/fedora-review -m compton-rawhide-x86_64 -b 1231355 Buildroot used: compton-rawhide-x86_64 Active plugins: Generic, PHP, Shell-api Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, Ruby Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
Other than the recommendation that composor.json be installed as %doc this all looks good now.
Thanks for the review. New Package SCM Request ======================= Package Name: php-liuggio-statsd-php-client Short Description: Object Oriented Client for etsy/statsd written in php Upstream URL: https://github.com/liuggio/statsd-php-client Owners: mooninite Branches: f21 f22 InitialCC:
Git done (by process-git-requests).
php-liuggio-statsd-php-client-1.0.16-1.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/php-liuggio-statsd-php-client-1.0.16-1.fc22
php-liuggio-statsd-php-client-1.0.16-1.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/php-liuggio-statsd-php-client-1.0.16-1.fc21
Again... late. Really running test suite should be considered as a MUST. Proposal: https://github.com/remicollet/remirepo/commit/8841d05c2405111958f747d7ff3295cabb2c9d24 https://raw.githubusercontent.com/remicollet/remirepo/d4e53fcb43c4d4afd8ddd314795ca9738dc1df51/php/php-liuggio-statsd-php-client/autoload.php
php-liuggio-statsd-php-client-1.0.16-1.fc22 has been pushed to the Fedora 22 testing repository.
php-liuggio-statsd-php-client-1.0.16-1.fc21 has been pushed to the Fedora 21 stable repository.
php-liuggio-statsd-php-client-1.0.16-1.fc22 has been pushed to the Fedora 22 stable repository.