Bug 1232549 - <AEMethod servicetemplateprovisionrequest_denied> [undefined method `+' for nil:NilClass] lines 24 + 29
Summary: <AEMethod servicetemplateprovisionrequest_denied> [undefined method `+' for n...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat CloudForms Management Engine
Classification: Red Hat
Component: Automate
Version: 5.4.0
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: GA
: 5.5.0
Assignee: Tina Fitzgerald
QA Contact: Milan Falešník
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-06-17 02:40 UTC by Jeffrey Cutter
Modified: 2015-12-08 13:14 UTC (History)
5 users (show)

Fixed In Version: 5.5.0.1
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-12-08 13:14:26 UTC
Category: ---
Cloudforms Team: ---
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHSA-2015:2551 0 normal SHIPPED_LIVE Moderate: CFME 5.5.0 bug fixes and enhancement update 2015-12-08 17:58:09 UTC

Description Jeffrey Cutter 2015-06-17 02:40:26 UTC
Description of problem:

/ RedHat / Service / Provisioning / Email / ServiceTemplateProvisionRequest_Denied 

Lines 24 and 29 attempt to append to not yet defined objects, "body" in both cases.

Error for 29:

[----] E, [2015-06-16T22:16:09.847660 #2083:6c92ccc] ERROR -- : Q-task_id([service_template_provision_request_1000000000128]) <AEMethod servicetemplateprovisionrequest_denied> [undefined method `+' for nil:NilClass]
<code: body += "<br>A service request received from #{requester_email} was denied.">:29:in `approver_denied_text'
<code: body += approver_denied_text(requester_email, msg, reason)>:37:in `approver_text'
<code: send_mail(to, from, subject, approver_text(appliance, msg, requester_email))>:59:in `email_approver'
<code: email_approver(appliance, msg)>:101:in `<main>'

Error for 24:

[----] E, [2015-06-16T22:22:18.919802 #2086:72e136c] ERROR -- : Q-task_id([service_template_provision_request_1000000000129]) <AEMethod servicetemplateprovisionrequest_denied> [undefined method `+' for nil:NilClass]
<code: body += " <a href='https://#{appliance}/miq_request/show/#{@miq_request.id}'</a>">:24:in `approver_href'
<code: body += approver_href(appliance)>:39:in `approver_text'
<code: send_mail(to, from, subject, approver_text(appliance, msg, requester_email))>:59:in `email_approver'
<code: email_approver(appliance, msg)>:101:in `<main>'

How reproducible:

Submit provision which will be denied for example by being over quota.

Comment 3 Milan Falešník 2015-10-19 16:43:16 UTC
Checked in 5.5.0.6. I made the request to become automatically denied and the method went ok. Also checked the code and the "body += '...'" is not present.

Comment 5 errata-xmlrpc 2015-12-08 13:14:26 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2015:2551


Note You need to log in before you can comment on or make changes to this bug.