Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1233258

Summary:	Possible double execution of the state machine for fops that start other subfops
Product:	[Community] GlusterFS	Reporter:	Xavi Hernandez <jahernan>
Component:	disperse	Assignee:	Xavi Hernandez <jahernan>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	mainline	CC:	bugs, gluster-bugs
Target Milestone:	---	Keywords:	Reopened, Triaged
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.8rc2	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:
Clones:	1233282 1233484 (view as bug list)		Environment:
Last Closed:	2016-06-16 13:14:28 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1233282, 1233484

Description Xavi Hernandez 2015-06-18 14:43:52 UTC

Description of problem:

When a fop starts a subfop as part of its own execution, it's possible that this subfop finishes before the manager has completed the processing of the current state. In this case ec_resume() is called and a new instance of the same state machine is executed by another thread.

This could cause multiple problems.

Version-Release number of selected component (if applicable): mainline


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Anand Avati 2015-06-18 14:52:24 UTC

REVIEW: http://review.gluster.org/11317 (cluster/ec: Avoid parallel executions of the same state machine) posted (#1) for review on master by Xavier Hernandez (xhernandez)

Comment 2 Anand Avati 2015-06-18 16:17:32 UTC

REVIEW: http://review.gluster.org/11317 (cluster/ec: Avoid parallel executions of the same state machine) posted (#2) for review on master by Xavier Hernandez (xhernandez)

Comment 3 Anand Avati 2015-06-19 03:39:07 UTC

REVIEW: http://review.gluster.org/11317 (cluster/ec: Avoid parallel executions of the same state machine) posted (#3) for review on master by Pranith Kumar Karampuri (pkarampu)

Comment 4 Anand Avati 2015-06-19 06:33:47 UTC

COMMIT: http://review.gluster.org/11317 committed in master by Pranith Kumar Karampuri (pkarampu) 
------
commit 4442449f1436e47c84c55c3f0d8f1a8b248db4b6
Author: Xavier Hernandez <xhernandez>
Date:   Thu Jun 18 16:44:55 2015 +0200

    cluster/ec: Avoid parallel executions of the same state machine
    
    In very rare circumstances it was possible that a subfop started
    by another fop could finish fast enough to cause that two or more
    instances of the same state machine be executing at the same time.
    
    Change-Id: I319924a18bd3f88115e751a66f8f4560435e0e0e
    BUG: 1233258
    Signed-off-by: Xavier Hernandez <xhernandez>
    Reviewed-on: http://review.gluster.org/11317
    Tested-by: Pranith Kumar Karampuri <pkarampu>
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Pranith Kumar Karampuri <pkarampu>

Comment 5 Nagaprasad Sathyanarayana 2015-10-25 15:08:43 UTC

Fix for this BZ is already present in a GlusterFS release. You can find clone of this BZ, fixed in a GlusterFS release and closed. Hence closing this mainline BZ as well.

Comment 6 Niels de Vos 2016-06-16 13:14:28 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.8.0, please open a new bug report.

glusterfs-3.8.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://blog.gluster.org/2016/06/glusterfs-3-8-released/
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user