Spec URL: https://jjames.fedorapeople.org/gap-pkg-carat/gap-pkg-carat.spec SRPM URL: https://jjames.fedorapeople.org/gap-pkg-carat/gap-pkg-carat-2.1.4-1.fc23.src.rpm Fedora Account System Username: jjames Description: This package provides GAP interface routines to some of the standalone programs of the package CARAT, developed by J. Opgenorth, W. Plesken, and T. Schulz at Lehrstuhl B für Mathematik, RWTH Aachen. CARAT is a package for computation with crystallographic groups. CARAT is to a large extent complementary to the GAP 4 package Cryst. In particular, it provides routines for the computation of normalizers and conjugators of finite unimodular groups in GL(n,Z), and routines for the computation of Bravais groups, which are all missing in Cryst. Furthermore, it provides a catalog of Bravais groups up to dimension 6. Cryst automatically loads Carat when it is available, and makes use of its functions where necessary. The Carat package thereby extends the functionality of the package Cryst considerably.
I noticed the use of the Suggests Tag, which from what I gather has been available for some time now but as far as I can tell isn't widely discussed. I did find this: http://www.rpm.org/wiki/PackagerDocs/Dependencies#Weakdependencies I didn't find it discussed anywhere in the Fedora documentation. Did I miss something? If not, I'll consider taking it up with the FPC just for the reason that I think at times some reviewers become a bit pedantic and flip out when they encounter something which isn't specifically mentioned. Approved. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed FALSE POSITIVES: - W: spelling-error Summary(en_US) [...listed below...] SHOULD: - E: incorrect-fsf-address /usr/share/licenses/gap-pkg-carat/GPL It is recommended you advise upstream. - %check is present and all tests pass. ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 4 files have unknown license. Detailed output of licensecheck in /home/gbcox/bugzilla_fedora_review/1233986 -gap-pkg-carat/licensecheck.txt [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Scriptlets must be sane, if used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: gap-pkg-carat-2.1.4-1.fc23.noarch.rpm gap-pkg-carat-2.1.4-1.fc23.src.rpm gap-pkg-carat.noarch: W: spelling-error %description -l en_US Opgenorth -> Northrop gap-pkg-carat.noarch: W: spelling-error %description -l en_US Plesken -> Spleen gap-pkg-carat.noarch: W: spelling-error %description -l en_US für -> fr, fer, fir gap-pkg-carat.noarch: W: spelling-error %description -l en_US normalizers -> normalizes, normalize rs, normalize-rs gap-pkg-carat.noarch: W: spelling-error %description -l en_US conjugators -> conjugates, conjugation, conjugate gap-pkg-carat.noarch: W: spelling-error %description -l en_US unimodular -> uni modular, uni-modular, modular gap-pkg-carat.noarch: W: spelling-error %description -l en_US Cryst -> Crest, Tryst, Crust gap-pkg-carat.noarch: W: only-non-binary-in-usr-lib gap-pkg-carat.noarch: E: incorrect-fsf-address /usr/share/licenses/gap-pkg-carat/GPL gap-pkg-carat.src: W: spelling-error %description -l en_US Opgenorth -> Northrop gap-pkg-carat.src: W: spelling-error %description -l en_US Plesken -> Spleen gap-pkg-carat.src: W: spelling-error %description -l en_US für -> fr, fer, fir gap-pkg-carat.src: W: spelling-error %description -l en_US normalizers -> normalizes, normalize rs, normalize-rs gap-pkg-carat.src: W: spelling-error %description -l en_US conjugators -> conjugates, conjugation, conjugate gap-pkg-carat.src: W: spelling-error %description -l en_US unimodular -> uni modular, uni-modular, modular gap-pkg-carat.src: W: spelling-error %description -l en_US Cryst -> Crest, Tryst, Crust 2 packages and 0 specfiles checked; 1 errors, 15 warnings. Rpmlint (installed packages) ---------------------------- gap-pkg-carat.noarch: W: spelling-error %description -l en_US Opgenorth -> Northrop gap-pkg-carat.noarch: W: spelling-error %description -l en_US Plesken -> Spleen gap-pkg-carat.noarch: W: spelling-error %description -l en_US für -> fr, fer, fir gap-pkg-carat.noarch: W: spelling-error %description -l en_US normalizers -> normalizes, normalize rs, normalize-rs gap-pkg-carat.noarch: W: spelling-error %description -l en_US conjugators -> conjugates, conjugation, conjugate gap-pkg-carat.noarch: W: spelling-error %description -l en_US unimodular -> uni modular, uni-modular, modular gap-pkg-carat.noarch: W: spelling-error %description -l en_US Cryst -> Crest, Tryst, Crust gap-pkg-carat.noarch: W: only-non-binary-in-usr-lib gap-pkg-carat.noarch: E: incorrect-fsf-address /usr/share/licenses/gap-pkg-carat/GPL 1 packages and 0 specfiles checked; 1 errors, 8 warnings. Requires -------- gap-pkg-carat (rpmlib, GLIBC filtered): /usr/bin/update-gap-workspace carat gap-core Provides -------- gap-pkg-carat: gap-pkg-carat Source checksums ---------------- https://www.math.uni-bielefeld.de/~gaehler/gap45/Carat/carat-2.1.4.tar.gz : CHECKSUM(SHA256) this package : 54372eb9b445a5bfeb3c3bc4e79042c5396fd4c2d8d8af5ac80bc2568eae0b66 CHECKSUM(SHA256) upstream package : 54372eb9b445a5bfeb3c3bc4e79042c5396fd4c2d8d8af5ac80bc2568eae0b66 Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20 Command line :/usr/bin/fedora-review -b 1233986 -m fedora-rawhide-x86_64 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
(In reply to Gerald Cox from comment #1) > I noticed the use of the Suggests Tag, which from what I gather has been > available for some time now but as far as I can tell isn't widely discussed. > I did find this: > > http://www.rpm.org/wiki/PackagerDocs/Dependencies#Weakdependencies > > I didn't find it discussed anywhere in the Fedora documentation. Did I miss > something? > > If not, I'll consider taking it up with the FPC just for the reason that I > think at times some reviewers become a bit pedantic and flip out when they > encounter something which isn't specifically mentioned. There has been some discussion, for example: https://lists.fedoraproject.org/pipermail/devel/2014-October/203208.html https://lists.fedoraproject.org/pipermail/devel/2014-November/204113.html https://lists.fedoraproject.org/pipermail/packaging/2015-January/010417.html And a packaging draft (not final and not approved): https://fedoraproject.org/wiki/PackagingDrafts/WeakDependencies Nothing about weak dependencies has been finalized for Fedora, as far as I know. If it makes you uncomfortable, I can take that out of the package until something gets finalized. But I think that having some examples of weak dependencies in Fedora is valuable for gaining experience with them.
New Package SCM Request ======================= Package Name: gap-pkg-carat Short Description: GAP interface to CARAT Upstream URL: https://www.math.uni-bielefeld.de/~gaehler/gap45/packages.php Owners: jjames Branches: f22 InitialCC:
(In reply to Jerry James from comment #2) > > Nothing about weak dependencies has been finalized for Fedora, as far as I > know. If it makes you uncomfortable, I can take that out of the package > until something gets finalized. But I think that having some examples of > weak dependencies in Fedora is valuable for gaining experience with them. No, it doesn't make me uncomfortable at all; and I agree the information would be valuable. Regardless "uncomfortable" isn't a justification to block. I was just curious.
Git done (by process-git-requests).
gap-pkg-carat-2.1.4-1.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/gap-pkg-carat-2.1.4-1.fc22
gap-pkg-carat-2.1.4-1.fc22 has been pushed to the Fedora 22 testing repository.
gap-pkg-carat-2.1.4-1.fc22 has been pushed to the Fedora 22 stable repository.