Bug 1233987 - Review Request: gap-pkg-cryst - GAP support for crystallographic groups
Summary: Review Request: gap-pkg-cryst - GAP support for crystallographic groups
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Gerald Cox
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 1233986
Blocks: 1233988
TreeView+ depends on / blocked
 
Reported: 2015-06-19 23:33 UTC by Jerry James
Modified: 2015-07-23 08:57 UTC (History)
2 users (show)

Fixed In Version: gap-pkg-cryst-4.1.12-1.fc22
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-07-23 08:57:17 UTC
Type: ---
Embargoed:
gbcox: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Jerry James 2015-06-19 23:33:32 UTC
Spec URL: https://jjames.fedorapeople.org/gap-pkg-cryst/gap-pkg-cryst.spec
SRPM URL: https://jjames.fedorapeople.org/gap-pkg-cryst/gap-pkg-cryst-4.1.12-1.fc23.src.rpm
Fedora Account System Username: jjames
Description: The Cryst package previously known as CrystGAP, is the successor of  the CrystGAP package for GAP 3. During the porting process to GAP 4, large parts  of the code have been rewritten, and the functionality has been extended considerably. Cryst provides a rich set of methods to compute with affine crystallographic groups, in particular space groups. In contrast to the GAP 3 version, affine crystallographic groups are now fully supported both in the representation acting from the right and in the representation acting from the left. The latter representation is the one preferred by crystallographers. There are also functions to determine representatives of all space group types of a given dimension.

Comment 1 Gerald Cox 2015-07-05 14:52:58 UTC
Running into a weird problem:
Error: nothing provides gap-pkg-carat needed by gap-pkg-cryst-4.1.12-1.fc23.noarch

Do you mind running fedora-review against rawhide and see if you get the same thing?  I've looked and it shows it is there...

Comment 2 Jerry James 2015-07-06 01:18:09 UTC
That's almost certainly because the repodata for Rawhide had not been regenerated after my gap-pkg-carat build, or hadn't made it to your local mirror yet.  I bet if you try again now, that it will work fine.

Comment 3 Gerald Cox 2015-07-06 16:59:40 UTC
(In reply to Jerry James from comment #2)
> That's almost certainly because the repodata for Rawhide had not been
> regenerated after my gap-pkg-carat build, or hadn't made it to your local
> mirror yet.  I bet if you try again now, that it will work fine.

Yeah, it finally worked.  I had been trying all weekend.  Weird because I could get to the copy in updates-testing.

Anyway...

You've got a typo in your Spec file:
Suggests   :    xgap

Probably want to fix that.  Otherwise, approved.

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed

FALSE POSITIVES:

- W: spelling-error Summary(en_US) [...listed below...]

SHOULD:

- E: incorrect-fsf-address /usr/share/licenses/gap-pkg-cryst/COPYING
  It is recommended you advise upstream.

- %check is present and all tests pass.


===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated". 3 files have unknown license. Detailed
     output of licensecheck in /home/gbcox/bugzilla_fedora_review/1233987
     -gap-pkg-cryst/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 10240 bytes in 2 files.
[x ]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Scriptlets must be sane, if used.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[!]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: gap-pkg-cryst-4.1.12-1.fc23.noarch.rpm
          gap-pkg-cryst-4.1.12-1.fc23.src.rpm
gap-pkg-cryst.noarch: W: spelling-error %description -l en_US affine -> caffeine, fine
gap-pkg-cryst.noarch: W: spelling-error %description -l en_US crystallographers -> crystallography, crystallographic, cryptographers
gap-pkg-cryst.noarch: W: only-non-binary-in-usr-lib
gap-pkg-cryst.noarch: E: incorrect-fsf-address /usr/share/licenses/gap-pkg-cryst/COPYING
gap-pkg-cryst.src: W: spelling-error %description -l en_US affine -> caffeine, fine
gap-pkg-cryst.src: W: spelling-error %description -l en_US crystallographers -> crystallography, crystallographic, cryptographers
2 packages and 0 specfiles checked; 1 errors, 5 warnings.




Rpmlint (installed packages)
----------------------------
gap-pkg-cryst.noarch: W: spelling-error %description -l en_US affine -> caffeine, fine
gap-pkg-cryst.noarch: W: spelling-error %description -l en_US crystallographers -> crystallography, crystallographic, cryptographers
gap-pkg-cryst.noarch: W: only-non-binary-in-usr-lib
gap-pkg-cryst.noarch: E: incorrect-fsf-address /usr/share/licenses/gap-pkg-cryst/COPYING
1 packages and 0 specfiles checked; 1 errors, 3 warnings.



Requires
--------
gap-pkg-cryst (rpmlib, GLIBC filtered):
    /usr/bin/update-gap-workspace
    gap-core
    gap-pkg-carat
    gap-pkg-polycyclic



Provides
--------
gap-pkg-cryst:
    gap-pkg-cryst



Source checksums
----------------
https://www.math.uni-bielefeld.de/~gaehler/gap45/Cryst/cryst-4.1.12.tar.gz :
  CHECKSUM(SHA256) this package     : 56e5434800f50c9bcd621b5ca9d57c1e82e413f1362abd9463d8fcd2bae6f5ca
  CHECKSUM(SHA256) upstream package : 56e5434800f50c9bcd621b5ca9d57c1e82e413f1362abd9463d8fcd2bae6f5ca


Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20
Command line :/usr/bin/fedora-review -b 1233987 -m fedora-rawhide-x86_64
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Shell-api
Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6

Comment 4 Jerry James 2015-07-06 19:24:51 UTC
(In reply to Gerald Cox from comment #3)
> You've got a typo in your Spec file:
> Suggests   :    xgap

Good catch.  I will fix that when I import.

> - E: incorrect-fsf-address /usr/share/licenses/gap-pkg-cryst/COPYING
>   It is recommended you advise upstream.

Will do.

Thank you again for the review!

Comment 5 Jerry James 2015-07-06 19:27:04 UTC
New Package SCM Request
=======================
Package Name: gap-pkg-cryst
Short Description: GAP support for crystallographic groups
Upstream URL: https://www.math.uni-bielefeld.de/~gaehler/gap45/packages.php
Owners: jjames
Branches: f22
InitialCC:

Comment 6 Gwyn Ciesla 2015-07-08 12:02:21 UTC
Git done (by process-git-requests).

Comment 7 Fedora Update System 2015-07-08 23:22:06 UTC
gap-pkg-cryst-4.1.12-1.fc22 has been submitted as an update for Fedora 22.
https://admin.fedoraproject.org/updates/gap-pkg-cryst-4.1.12-1.fc22

Comment 8 Fedora Update System 2015-07-13 19:16:58 UTC
gap-pkg-cryst-4.1.12-1.fc22 has been pushed to the Fedora 22 testing repository.

Comment 9 Fedora Update System 2015-07-23 08:57:17 UTC
gap-pkg-cryst-4.1.12-1.fc22 has been pushed to the Fedora 22 stable repository.


Note You need to log in before you can comment on or make changes to this bug.