Bug 1236274 - Upcall: Directory or file creation should send cache invalidation requests to parent directories
Summary: Upcall: Directory or file creation should send cache invalidation requests to...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: upcall
Version: 3.7.2
Hardware: All
OS: All
unspecified
urgent
Target Milestone: ---
Assignee: Soumya Koduri
QA Contact:
URL:
Whiteboard:
Depends On: 1235542
Blocks: 1235543 1235544
TreeView+ depends on / blocked
 
Reported: 2015-06-27 06:44 UTC by Soumya Koduri
Modified: 2015-07-30 09:51 UTC (History)
1 user (show)

Fixed In Version: glusterfs-3.7.3
Clone Of: 1235542
Environment:
Last Closed: 2015-07-30 09:50:49 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Soumya Koduri 2015-06-27 06:44:26 UTC
+++ This bug was initially created as a clone of Bug #1235542 +++

Description of problem:
Any directory or file creation should result in cache-invalidation requests sent to parent directory. However that is not the case currently due to a bug while processing these requests in the upcall xlator. We need to do invalidation checks on parent inode.

--- Additional comment from Anand Avati on 2015-06-25 03:10:51 EDT ---

REVIEW: http://review.gluster.org/11387 (Upcall: Fix an issue with invalidating parent entries) posted (#2) for review on master by soumya k (skoduri)

--- Additional comment from Anand Avati on 2015-06-25 06:43:28 EDT ---

REVIEW: http://review.gluster.org/11387 (Upcall: Fix an issue with invalidating parent entries) posted (#3) for review on master by soumya k (skoduri)

--- Additional comment from Anand Avati on 2015-06-25 10:18:49 EDT ---

REVIEW: http://review.gluster.org/11387 (Upcall: Fix an issue with invalidating parent entries) posted (#4) for review on master by soumya k (skoduri)

--- Additional comment from Anand Avati on 2015-06-25 10:38:30 EDT ---

REVIEW: http://review.gluster.org/11411 (protocol/server: Include a check to validate xprt->client) posted (#1) for review on master by soumya k (skoduri)

--- Additional comment from Anand Avati on 2015-06-26 06:19:15 EDT ---

REVIEW: http://review.gluster.org/11411 (protocol/server: Include a check to validate xprt->client) posted (#3) for review on master by soumya k (skoduri)

--- Additional comment from Anand Avati on 2015-06-26 07:32:25 EDT ---

REVIEW: http://review.gluster.org/11411 (protocol/server: Include a check to validate xprt->client) posted (#4) for review on master by soumya k (skoduri)

--- Additional comment from Anand Avati on 2015-06-26 21:12:53 EDT ---

COMMIT: http://review.gluster.org/11387 committed in master by Kaleb KEITHLEY (kkeithle) 
------
commit 35d24f0c967130ef8424660b5f6dfd182bb305c1
Author: Soumya Koduri <skoduri>
Date:   Thu Jun 25 00:47:19 2015 +0530

    Upcall: Fix an issue with invalidating parent entries
    
    Any directory or file creation should result in cache-invalidation
    requests sent to parent directory. However that is not the case
    currently due to a bug while processing these requests in the
    upcall xlator. We need to do invalidation checks on parent inode.
    
    Fixed the same. Also fixed an issue with null client entries while
    sending upcall notifications.
    
    Change-Id: I3da7c79091291ba36fd8f8ebcfebcd77a192f250
    BUG: 1235542
    Signed-off-by: Soumya Koduri <skoduri>
    Reviewed-on: http://review.gluster.org/11387
    Reviewed-by: Niels de Vos <ndevos>
    Reviewed-by: Meghana M <mmadhusu>
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Kaleb KEITHLEY <kkeithle>

--- Additional comment from Anand Avati on 2015-06-26 21:15:03 EDT ---

COMMIT: http://review.gluster.org/11411 committed in master by Kaleb KEITHLEY (kkeithle) 
------
commit 14cf2bbe77fbbaee8ee3211ec841a4f1ef3a8380
Author: Soumya Koduri <skoduri>
Date:   Thu Jun 25 19:49:59 2015 +0530

    protocol/server: Include a check to validate xprt->client
    
    rpc_transport entries(xprt) are added to the conf->xprt_list
    during client connection with the server. But the client object is created
    and assigned to that transport object only during GF_HANDSK_SETVOLUME. Hence
    till that period, there could be xprt entries in the xprt_list without client
    associated with it. Added a check to validate the client object during upcall
    notify.
    
    Change-Id: I11e2fcd8b0a67e35302ede478b777b72d1973456
    BUG: 1235542
    Signed-off-by: Soumya Koduri <skoduri>
    Reviewed-on: http://review.gluster.org/11411
    Reviewed-by: Krishnan Parthasarathi <kparthas>
    Tested-by: NetBSD Build System <jenkins.org>
    Reviewed-by: Kaleb KEITHLEY <kkeithle>

--- Additional comment from Anand Avati on 2015-06-27 02:43:10 EDT ---

REVIEW: http://review.gluster.org/11440 (Upcall: Fix an issue with invalidating parent entries) posted (#1) for review on release-3.7 by soumya k (skoduri)

Comment 1 Anand Avati 2015-06-27 06:45:55 UTC
REVIEW: http://review.gluster.org/11440 (Upcall: Fix an issue with invalidating parent entries) posted (#2) for review on release-3.7 by soumya k (skoduri)

Comment 2 Anand Avati 2015-06-27 06:48:22 UTC
REVIEW: http://review.gluster.org/11441 (protocol/server: Include a check to validate xprt->client) posted (#1) for review on release-3.7 by soumya k (skoduri)

Comment 3 Anand Avati 2015-06-27 09:55:26 UTC
COMMIT: http://review.gluster.org/11441 committed in release-3.7 by Kaleb KEITHLEY (kkeithle) 
------
commit 0cde678bd1b77839339a6b3fd6947ef99531c450
Author: Soumya Koduri <skoduri>
Date:   Thu Jun 25 19:49:59 2015 +0530

    protocol/server: Include a check to validate xprt->client
    
    rpc_transport entries(xprt) are added to the conf->xprt_list
    during client connection with the server. But the client object is created
    and assigned to that transport object only during GF_HANDSK_SETVOLUME. Hence
    till that period, there could be xprt entries in the xprt_list without client
    associated with it. Added a check to validate the client object during upcall
    notify.
    
    This is a backport of the below fix -
    http://review.gluster.org/#/c/11411/
    
    BUG: 1236274
    
    Change-Id: I00b9a140d6ee76e44c49146e90c20b3a87dc2de8
    Signed-off-by: Soumya Koduri <skoduri>
    Reviewed-on: http://review.gluster.org/11411
    Reviewed-by: Krishnan Parthasarathi <kparthas>
    Reviewed-by: Kaleb KEITHLEY <kkeithle>
    Reviewed-on: http://review.gluster.org/11441
    Tested-by: NetBSD Build System <jenkins.org>

Comment 4 Kaushal 2015-07-30 09:50:49 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.3, please open a new bug report.

glusterfs-3.7.3 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/12078
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 5 Kaushal 2015-07-30 09:51:59 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.3, please open a new bug report.

glusterfs-3.7.3 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/12078
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user


Note You need to log in before you can comment on or make changes to this bug.