Bug 1238183 - opencv 3.0 compatibility, replace deprecated functions
Summary: opencv 3.0 compatibility, replace deprecated functions
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: player
Version: 23
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Rich Mattes
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: opencv3
TreeView+ depends on / blocked
 
Reported: 2015-07-01 11:25 UTC by Jozef Mlich
Modified: 2015-08-21 00:23 UTC (History)
6 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-08-21 00:23:15 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
replacing deprecated opencv functions (3.31 KB, application/mbox)
2015-07-01 11:25 UTC, Jozef Mlich
no flags Details

Description Jozef Mlich 2015-07-01 11:25:43 UTC
Created attachment 1044982 [details]
replacing deprecated opencv functions

Description of problem:

We would like to update OpenCV in fedora to 3.0.0 (See #1230078). In OpenCV 3.0.0 some deprecated functions was removed (they were formerly in compat.hpp). Here is a list of functions and it appropriate replacements.

cvCvtPixToPlane -> cvSplit
cvCvtPlaneToPix -> cvMerge
cvQueryHistValue_1D -> cvGetReal1D

For more details please inspect attached patch. I would like to ask you for its review. 

You can use my copr repository for testing.
https://copr.fedoraproject.org/coprs/jmlich/opencv3/build/101958/

It seems, the upstream bug tracking system is not working 
http://sourceforge.net/tracker/?group_id=42445

Comment 1 Rich Mattes 2015-07-01 13:00:29 UTC
Thanks, this looks pretty straightforward. I will test it and apply it to rawhide and to upstream.  These functions are included in opencv 2 as well, so there's no need for #ifdefs based on the opencv version, correct?

The upstream tracker is at http://sourceforge.net/p/playerstage/patches/, but we're in the process of migrating to github at the moment so don't worry about reporting it there.  I'll make sure it gets taken care of.

Comment 2 Sergio Basto 2015-07-01 16:02:51 UTC
https://sourceforge.net/p/playerstage/svn/9142/log/?path=

shows some activity on development of  player

Comment 3 Jozef Mlich 2015-07-02 07:24:19 UTC
That is correct. Those function should be available in opencv 2 as well. 

The incorrect link "Bugs" is at http://playerstage.sourceforge.net/

Comment 4 Jan Kurik 2015-07-15 13:52:27 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 23 development cycle.
Changing version to '23'.

(As we did not run this process for some time, it could affect also pre-Fedora 23 development
cycle bugs. We are very sorry. It will help us with cleanup during Fedora 23 End Of Life. Thank you.)

More information and reason for this action is here:
https://fedoraproject.org/wiki/BugZappers/HouseKeeping/Fedora23

Comment 6 Rich Mattes 2015-08-21 00:23:15 UTC
Thanks. The fix is in fedora, and I've pushed the fix upstream.  I'll make sure to update the bug URL to point to the right place.


Note You need to log in before you can comment on or make changes to this bug.