Bug 1238721 - Getting an error in the UI when moving an unsaved element in a service dialog
Summary: Getting an error in the UI when moving an unsaved element in a service dialog
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat CloudForms Management Engine
Classification: Red Hat
Component: UI - OPS
Version: 5.4.0
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: GA
: 5.6.0
Assignee: Jozef Zigmund
QA Contact: Shveta
URL:
Whiteboard: retest:service:dialog
Depends On:
Blocks: 1291859
TreeView+ depends on / blocked
 
Reported: 2015-07-02 13:13 UTC by Martin Welk
Modified: 2019-11-14 06:47 UTC (History)
9 users (show)

Fixed In Version: 5.6.0.1
Doc Type: Bug Fix
Doc Text:
Cause: Service dialog elements cannot be reordered in 5.5 Consequence: Getting an error in the UI when moving an unsaved element in a service dialog Fix: Use item order number instead of record ID (unsaved element doesn't have ID) Result:
Clone Of:
: 1291859 (view as bug list)
Environment:
Last Closed: 2016-06-29 14:57:59 UTC
Category: ---
Cloudforms Team: ---
Target Upstream Version:
Embargoed:
sshveta: automate_bug-


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2016:1348 0 normal SHIPPED_LIVE CFME 5.6.0 bug fixes and enhancement update 2016-06-29 18:50:04 UTC

Description Martin Welk 2015-07-02 13:13:23 UTC
Description of problem:

I am working in the CFME web UI, in Automate -> Customization. I edit an existing service dialog, and try to move a newly created element inside the box where I places it. This leads to an error message.

Version-Release number of selected component (if applicable):
5.4.0.5

How reproducible:


Steps to Reproduce:
1. Open an existing service dialog
2. Go to an existing box
3. Add an element
4. Do not explicitely save now.
5. In the left bar, go to the box containing the element
6. Try to move the new but unsaved element
7. Watch the error message

Actual results:
Error message "undefined method `[]' for nil:NilClass [miq_ae_customization/dialog_res_reorder]"


Expected results:
Object is moved. I could accept that I cannot move while not saved, too.

Additional info:

Comment 3 Shveta 2016-01-11 23:54:37 UTC
Service dialog elements cannot be reordered in 5.5 .
Issue can be seen in 5.4

Comment 6 CFME Bot 2016-04-05 20:16:20 UTC
New commit detected on ManageIQ/manageiq/master:
https://github.com/ManageIQ/manageiq/commit/040c343747524160aa9e82dddd19aa0435e6520a

commit 040c343747524160aa9e82dddd19aa0435e6520a
Author:     Jozef Zigmund <jzigmund>
AuthorDate: Wed Mar 23 16:15:08 2016 +0100
Commit:     Jozef Zigmund <jzigmund>
CommitDate: Mon Apr 4 15:57:23 2016 +0200

    Fix the error when user reorders an unsaved element in a service dialog
    
    Use item order number instead of record ID (unsaved element doesn't have ID)
    https://bugzilla.redhat.com/show_bug.cgi?id=1238721

 app/assets/javascripts/miq_application.js            | 11 +++++++++++
 .../miq_ae_customization_controller/dialogs.rb       | 20 ++++++++++++++++----
 2 files changed, 27 insertions(+), 4 deletions(-)

Comment 8 Shveta 2016-04-19 01:16:29 UTC
Fixed.
Verified in 5.6.0.1-beta2.20160413141124_e25ac0e

Comment 9 CFME Bot 2016-04-21 17:47:03 UTC
New commit detected on cfme/5.5.z:
https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=47b5bd63a52df0532b83a29f8c6103d7c46a1245

commit 47b5bd63a52df0532b83a29f8c6103d7c46a1245
Author:     Jozef Zigmund <jzigmund>
AuthorDate: Wed Mar 23 16:15:08 2016 +0100
Commit:     Jozef Zigmund <jzigmund>
CommitDate: Mon Apr 18 15:03:52 2016 +0200

    Fix the error when user reorders an unsaved element in a service dialog
    
    Use item order number instead of record ID (unsaved element doesn't have ID)
    https://bugzilla.redhat.com/show_bug.cgi?id=1238721

 app/assets/javascripts/miq_application.js            | 11 +++++++++++
 .../miq_ae_customization_controller/dialogs.rb       | 20 ++++++++++++++++----
 2 files changed, 27 insertions(+), 4 deletions(-)

Comment 11 errata-xmlrpc 2016-06-29 14:57:59 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2016:1348


Note You need to log in before you can comment on or make changes to this bug.