Spec URL: https://gil.fedorapeople.org/mysema-apt-maven-plugin.spec SRPM URL: https://gil.fedorapeople.org/mysema-apt-maven-plugin-1.1.3-1.fc20.src.rpm Description: This plugin provides provides Maven integration of the Java 6 APT functionality. Fedora Account System Username: gil Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=10294132
Spec URL: https://gil.fedorapeople.org/mysema-apt-maven-plugin.spec SRPM URL: https://gil.fedorapeople.org/mysema-apt-maven-plugin-1.1.3-1.fc22.src.rpm
gil's scratch build of mysema-apt-maven-plugin-1.1.3-1.fc22.src.rpm for rawhide failed http://koji.fedoraproject.org/koji/taskinfo?taskID=11494774
(In reply to Upstream Release Monitoring from comment #2) > gil's scratch build of mysema-apt-maven-plugin-1.1.3-1.fc22.src.rpm for > rawhide failed http://koji.fedoraproject.org/koji/taskinfo?taskID=11494774 added org.apache.maven.shared:maven-verifier
gil's scratch build of mysema-apt-maven-plugin-1.1.3-1.fc22.src.rpm for rawhide failed http://koji.fedoraproject.org/koji/taskinfo?taskID=11494797
(In reply to Upstream Release Monitoring from comment #4) > gil's scratch build of mysema-apt-maven-plugin-1.1.3-1.fc22.src.rpm for > rawhide failed http://koji.fedoraproject.org/koji/taskinfo?taskID=11494797 added org.apache.maven.plugins:maven-clean-plugin
gil's scratch build of mysema-apt-maven-plugin-1.1.3-1.fc22.src.rpm for rawhide failed http://koji.fedoraproject.org/koji/taskinfo?taskID=11494818
gil's scratch build of mysema-apt-maven-plugin-1.1.3-1.fc22.src.rpm for rawhide completed http://koji.fedoraproject.org/koji/taskinfo?taskID=11494838
Spec URL: https://gil.fedorapeople.org/mysema-apt-maven-plugin.spec SRPM URL: https://gil.fedorapeople.org/mysema-apt-maven-plugin-1.1.3-1.fc23.src.rpm
gil's scratch build of mysema-apt-maven-plugin-1.1.3-1.fc23.src.rpm for rawhide completed http://koji.fedoraproject.org/koji/taskinfo?taskID=11742947
Taken. :) Informal advice first before an official review process: - Please remove one 'provides' from %description. - You could shorten Source0: value with usage of the %{url} placeholder. - Please explain the following command line, what is native2ascii (comment!) and what package contains that command? Is it about conversion of line feeds? https://fedoraproject.org/wiki/Common_Rpmlint_issues#wrong-file-end-of-line-encoding > native2ascii -encoding UTF8 src/main/java/com/mysema/maven/apt/FileSync.java \ src/main/java/com/mysema/maven/apt/FileSync.java - How to run the dedicated tests in src/test folder?
(In reply to Raphael Groner from comment #10) > Taken. :) > > Informal advice first before an official review process: > > - Please remove one 'provides' from %description. Done > - You could shorten Source0: value with usage of the %{url} placeholder. Sorry, I'd rather not > - Please explain the following command line, what is native2ascii (comment!) > and what package contains that command? Is it about conversion of line > feeds? Done > https://fedoraproject.org/wiki/Common_Rpmlint_issues#wrong-file-end-of-line- > encoding > > native2ascii -encoding UTF8 src/main/java/com/mysema/maven/apt/FileSync.java \ > src/main/java/com/mysema/maven/apt/FileSync.java Add comment, native2ascii is a JDK tool I use to convert non non ASCII chars > - How to run the dedicated tests in src/test folder? Sorry, I dont understand the question. Maven build stile is different from Ant test suite are runnig in the same "place", %%check section is unnecessary. Spec URL: https://gil.fedorapeople.org/mysema-apt-maven-plugin.spec SRPM URL: https://gil.fedorapeople.org/mysema-apt-maven-plugin-1.1.3-1.fc23.src.rpm
gil's scratch build of mysema-apt-maven-plugin-1.1.3-1.fc23.src.rpm for rawhide failed http://koji.fedoraproject.org/koji/taskinfo?taskID=11820827
(In reply to Upstream Release Monitoring from comment #12) > gil's scratch build of mysema-apt-maven-plugin-1.1.3-1.fc23.src.rpm for > rawhide failed http://koji.fedoraproject.org/koji/taskinfo?taskID=11820827 seem a problem with newer maven release (3.3.9) http://pkgs.fedoraproject.org/cgit/maven.git/commit/
gil's scratch build of mysema-apt-maven-plugin-1.1.3-1.fc23.src.rpm for rawhide failed http://koji.fedoraproject.org/koji/taskinfo?taskID=11821225
raphgro's scratch build of mysema-apt-maven-plugin-1.1.3-1.fc23.src.rpm for f23 completed http://koji.fedoraproject.org/koji/taskinfo?taskID=11822708
What does mysema stand for in the package name mysema-apt-maven-plugin?
(In reply to Raphael Groner from comment #16) > What does mysema stand for in the package name mysema-apt-maven-plugin? http://mysema.com https://github.com/mysema
(In reply to gil cattaneo from comment #17) > (In reply to Raphael Groner from comment #16) > > What does mysema stand for in the package name mysema-apt-maven-plugin? > > http://mysema.com > https://github.com/mysema <groupId>com.mysema.maven</groupId> <artifactId>apt-maven-plugin</artifactId>
Well, mysema is not upstream here but querydsl. Please notice also that apt-maven-plugin is retired in PkgDB, maybe you can overtake that name. > URL: https://github.com/querydsl/apt-maven-plugin
(In reply to Raphael Groner from comment #19) > Well, mysema is not upstream here but querydsl. Please notice also that > apt-maven-plugin is retired in PkgDB, maybe you can overtake that name. > > > URL: https://github.com/querydsl/apt-maven-plugin No thanks, for avoid confusion, with the older codehaus project i prefer use this name. Reminder also the groupId ... The http://pkgs.fedoraproject.org/cgit/apt-maven-plugin.git use jdk apt (Annotation Processing Tool). mysema-apt-maven-plugin use a different approach, It can not be used as an alternative to many of the projects that used the plugin Codehaus.
raphgro's scratch build of mysema-apt-maven-plugin-1.1.3-1.fc23.src.rpm for rawhide completed http://koji.fedoraproject.org/koji/taskinfo?taskID=11839029
APPROVED Hint: Please note in the Release tag that you package from a snapshot. Upstream marks 1_1_3 based on commit hash 9835134 but you use the newer hash 7b58ac8. Alternatively, you could use the commit a87a23f as marked with '1.1.4.BUILD-SNAPSHOT'. https://fedoraproject.org/wiki/Packaging:NamingGuidelines?rd=Packaging/NamingGuidelines#Release_Tag Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 21 files have unknown license. Detailed output of licensecheck in /home/builder/fedora-review/1240122-mysema- apt-maven-plugin/licensecheck.txt => General license is ASL 2.0 as in LICENSE.txt file. [x]: License file installed when any subpackage combination is installed. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: No rpmlint messages. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Java: [x]: Bundled jar/class files should be removed before build [x]: Packages have proper BuildRequires/Requires on jpackage-utils Note: Maven packages do not need to (Build)Require jpackage-utils. It is pulled in by maven-local [x]: Javadoc documentation files are generated and included in -javadoc subpackage [x]: Javadoc subpackages should not have Requires: jpackage-utils [x]: Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink) Maven: [x]: If package contains pom.xml files install it (including metadata) even when building with ant [x]: POM files have correct Maven mapping [x]: Maven packages should use new style packaging [x]: Old add_to_maven_depmap macro is not being used [x]: Packages DO NOT have Requires(post) and Requires(postun) on jpackage- utils for %update_maven_depmap macro [x]: Package DOES NOT use %update_maven_depmap in %post/%postun [x]: Packages use .mfiles file list instead of %{_datadir}/maven2/poms ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in mysema- apt-maven-plugin-javadoc => Ignore, optional documentation. [?]: Package functions as described. [!]: Latest version is packaged. => Please note in the Release tag that you package from a snapshot. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. Java: [x]: Package uses upstream build method (ant/maven/etc.) [x]: Packages are noarch unless they use JNI ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: mysema-apt-maven-plugin-1.1.3-1.fc24.noarch.rpm mysema-apt-maven-plugin-javadoc-1.1.3-1.fc24.noarch.rpm mysema-apt-maven-plugin-1.1.3-1.fc24.src.rpm 3 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- sh: /usr/bin/python: Datei oder Verzeichnis nicht gefunden 2 packages and 0 specfiles checked; 0 errors, 0 warnings. Requires -------- mysema-apt-maven-plugin-javadoc (rpmlib, GLIBC filtered): jpackage-utils mysema-apt-maven-plugin (rpmlib, GLIBC filtered): java-headless jpackage-utils mvn(com.google.guava:guava) mvn(commons-io:commons-io) mvn(org.apache.maven:maven-core) mvn(org.apache.maven:maven-model) mvn(org.apache.maven:maven-plugin-api) mvn(org.codehaus.plexus:plexus-utils) mvn(org.sonatype.plexus:plexus-build-api) Provides -------- mysema-apt-maven-plugin-javadoc: mysema-apt-maven-plugin-javadoc mysema-apt-maven-plugin: mvn(com.mysema.maven:apt-maven-plugin) mvn(com.mysema.maven:apt-maven-plugin:pom:) mysema-apt-maven-plugin Source checksums ---------------- https://github.com/querydsl/apt-maven-plugin/archive/7b58ac8778dfbff19672914f7e165d9ef9e28271/apt-maven-plugin-7b58ac8778dfbff19672914f7e165d9ef9e28271.tar.gz : CHECKSUM(SHA256) this package : b8c4f3eec27f677e87352b7ba96d21e1824d13dbd166cb177c8b9f48bf968354 CHECKSUM(SHA256) upstream package : b8c4f3eec27f677e87352b7ba96d21e1824d13dbd166cb177c8b9f48bf968354 Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20 Command line :/usr/bin/fedora-review -v -m fedora-rawhide-x86_64 -b 1240122 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, Java Disabled plugins: C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
(In reply to Raphael Groner from comment #22) > APPROVED > > Hint: Please note in the Release tag that you package from a snapshot. > Upstream marks 1_1_3 based on commit hash 9835134 but you use the newer hash > 7b58ac8. Alternatively, you could use the commit a87a23f as marked with > '1.1.4.BUILD-SNAPSHOT'. > https://fedoraproject.org/wiki/Packaging:NamingGuidelines?rd=Packaging/ > NamingGuidelines#Release_Tag > [!]: Latest version is packaged. > => Please note in the Release tag that you package from a snapshot. Latest release is 1_1_3, I packaged a87a23f because fix only the license file: https://github.com/querydsl/apt-maven-plugin/issues/37 https://github.com/querydsl/apt-maven-plugin/pull/41 I do not want to import, unless absolutely required by other projects, a pre release
To avoid any confusion with the git tarball as Source0, you could apply the additional license file as a patch. Patch0: https://github.com/querydsl/apt-maven-plugin/commit/7d890eb13a971300a2229e7c0912a1f4bd4d4df8.patch
(In reply to Raphael Groner from comment #24) > To avoid any confusion with the git tarball as Source0, you could apply the > additional license file as a patch. > Patch0: > https://github.com/querydsl/apt-maven-plugin/commit/ > 7d890eb13a971300a2229e7c0912a1f4bd4d4df8.patch Done. Spec URL: https://gil.fedorapeople.org/mysema-apt-maven-plugin.spec SRPM URL: https://gil.fedorapeople.org/mysema-apt-maven-plugin-1.1.3-1.fc23.src.rpm Thanks! Request for new package: https://admin.fedoraproject.org/pkgdb/package/requests/1643 https://admin.fedoraproject.org/pkgdb/package/requests/1644
Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=11888419
gil's scratch build of mysema-apt-maven-plugin-1.1.3-1.fc23.src.rpm for rawhide completed http://koji.fedoraproject.org/koji/taskinfo?taskID=11888419
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/mysema-apt-maven-plugin
mysema-apt-maven-plugin-1.1.3-1.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2015-9e34b0eaf6
My suggestion was more like the following but it's up to you. You may not want to use a snapshot tarball if official version is propagated with Version and Release tags. > %global artifactId apt-maven-plugin > %global srcversion %(echo %{version} |tr . _) … > URL: https://github.com/querydsl/%{artifactId} > Source0: %{url}/archive/%{srcversion}.tar.gz#/%{name}-%{version}.tar.gz > # Add license file fix https://github.com/querydsl/apt-maven-plugin/issues/37 > Patch0: %{url}/commit/7d890eb13a971300a2229e7c0912a1f4bd4d4df8.patch … > %prep > %setup -q -n %{artifactId}-%{srcversion} > %patch0 -p1 …
(In reply to Raphael Groner from comment #30) > My suggestion was more like the following but it's up to you. You may not > want to use a snapshot tarball if official version is propagated with > Version and Release tags. No thanks, for me is useless
mysema-apt-maven-plugin-1.1.3-1.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with $ su -c 'dnf --enablerepo=updates-testing update mysema-apt-maven-plugin' You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-9e34b0eaf6
mysema-apt-maven-plugin-1.1.3-1.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.