Spec URL: https://gil.fedorapeople.org/springframework-data-jpa.spec SRPM URL: https://gil.fedorapeople.org/springframework-data-jpa-1.6.6-1.fc20.src.rpm Description: Spring Data JPA, part of the larger Spring Data family, makes it easy to easily implement JPA based repositories. This module deals with enhanced support for JPA based data access layers. It makes it easier to build Spring powered applications that use data access technologies. Fedora Account System Username: gil
Spec URL: https://gil.fedorapeople.org/springframework-data-jpa.spec SRPM URL: https://gil.fedorapeople.org/springframework-data-jpa-1.6.6-1.fc22.src.rpm
Spec URL: https://gil.fedorapeople.org/springframework-data-jpa.spec SRPM URL: https://gil.fedorapeople.org/springframework-data-jpa-1.6.6-1.fc23.src.rpm
gil's scratch build of springframework-data-jpa-1.6.6-1.fc23.src.rpm for rawhide failed http://koji.fedoraproject.org/koji/taskinfo?taskID=11906530
gil's scratch build of springframework-data-jpa-1.6.6-1.fc23.src.rpm for rawhide failed http://koji.fedoraproject.org/koji/taskinfo?taskID=11906618
gil's scratch build of springframework-data-jpa-1.6.6-1.fc23.src.rpm for rawhide completed http://koji.fedoraproject.org/koji/taskinfo?taskID=11906868
Looks good. The main issue is that the latest version should be packaged. You've got 1.6.6 but 1.9.1 is the current. Please uprev. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. [x]: License file installed when any subpackage combination is installed. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 61440 bytes in 3 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: No rpmlint messages. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Java: [x]: Bundled jar/class files should be removed before build [x]: Packages have proper BuildRequires/Requires on jpackage-utils Note: Maven packages do not need to (Build)Require jpackage-utils. It is pulled in by maven-local [x]: Javadoc documentation files are generated and included in -javadoc subpackage [x]: Javadoc subpackages should not have Requires: jpackage-utils [x]: Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink) Maven: [x]: If package contains pom.xml files install it (including metadata) even when building with ant [x]: POM files have correct Maven mapping [x]: Maven packages should use new style packaging [x]: Old add_to_maven_depmap macro is not being used [x]: Packages DO NOT have Requires(post) and Requires(postun) on jpackage- utils for %update_maven_depmap macro [x]: Package DOES NOT use %update_maven_depmap in %post/%postun [x]: Packages use .mfiles file list instead of %{_datadir}/maven2/poms ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in springframework-data-jpa-javadoc [x]: Package functions as described. [!]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [-]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. Java: [x]: Package uses upstream build method (ant/maven/etc.) [x]: Packages are noarch unless they use JNI ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: springframework-data-jpa-1.6.6-1.fc23.noarch.rpm springframework-data-jpa-javadoc-1.6.6-1.fc23.noarch.rpm springframework-data-jpa-1.6.6-1.fc23.src.rpm 3 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- sh: /usr/bin/python: No such file or directory 2 packages and 0 specfiles checked; 0 errors, 0 warnings. Requires -------- springframework-data-jpa (rpmlib, GLIBC filtered): java-headless jpackage-utils mvn(org.hibernate.javax.persistence:hibernate-jpa-2.1-api) mvn(org.springframework.data:spring-data-commons) mvn(org.springframework:spring-aop) mvn(org.springframework:spring-beans) mvn(org.springframework:spring-context) mvn(org.springframework:spring-core) mvn(org.springframework:spring-orm) mvn(org.springframework:spring-tx) springframework-data-jpa-javadoc (rpmlib, GLIBC filtered): jpackage-utils Provides -------- springframework-data-jpa: mvn(org.springframework.data:spring-data-jpa) mvn(org.springframework.data:spring-data-jpa:pom:) osgi(org.springframework.data.jpa) springframework-data-jpa springframework-data-jpa-javadoc: springframework-data-jpa-javadoc Source checksums ---------------- https://github.com/spring-projects/spring-data-jpa/archive/1.6.6.RELEASE.tar.gz : CHECKSUM(SHA256) this package : a67a21c6c01d02f23bb3dd0cbbddac1cdecdb595aa6a2214c98c17bdb4872225 CHECKSUM(SHA256) upstream package : a67a21c6c01d02f23bb3dd0cbbddac1cdecdb595aa6a2214c98c17bdb4872225 Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20 Command line :/usr/bin/fedora-review -b 1240126 Buildroot used: fedora-23-x86_64 Active plugins: Generic, Shell-api, Java Disabled plugins: C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
(In reply to Adam Goode from comment #6) > Looks good. The main issue is that the latest version should be packaged. > You've got 1.6.6 but 1.9.1 is the current. Please uprev. > [!]: Latest version is packaged. As i wrote in the header of the spec file "Newer release require springframework >= 4.0.7.RELEASE" and we have the SF 3.x serie in rawhide. It is not updatable, at the moment, cause broken compatibility with a lot of packages.
All good then!
Thanks! Request for new package: https://admin.fedoraproject.org/pkgdb/package/requests/1933
Sorry for the noise, can you set "Status" field as "ASSIGNED" ? Thanks in advance
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/springframework-data-jpa
Thanks for all. Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=12015757