Description of problem: When running: engine-backup --file=f1 --mode=backup it should fail, saying: --log is missing When running: engine-backup --file=f1 --mode=backup --log=l1 --db-user=u1 it should fail, saying: Please use --change-db-credentials to change engine db credentials In both of them it enters instead an endless loop (while trying to notify the engine). Version-Release number of selected component (if applicable): Current master How reproducible: Always Steps to Reproduce: 1. See above 2. 3. Actual results: Endless loop Expected results: output message and exit Additional info:
Reported by Roman Mohr, who also suggested to change USAGE to something like: /usr/bin/engine-backup --mode=restore [--scope=SCOPE] /usr/bin/engine-backup --mode=backup [--scope=SCOPE] --file=FILE --log=FILE
Since there's a command line change involved, moved to 4.0
(In reply to Sandro Bonazzola from comment #2) > Since there's a command line change involved, moved to 4.0 Is there really a command line change? When I ran into these problems my impression was that only the check for the required arguments failed. They are required anyway.
(In reply to Roman Mohr from comment #3) > (In reply to Sandro Bonazzola from comment #2) > > Since there's a command line change involved, moved to 4.0 Roman suggested a change in the usage text, not to the parsing. Not really related to this bug. > > Is there really a command line change? When I ran into these problems my > impression was that only the check for the required arguments failed. They > are required anyway. Indeed. The bug is caused by the work to notify the engine about backup failure/success, but 1188143. Not sure about the best fix, but it does not involve iiuc any change in ui etc. I'd suggest to move to 3.6.1.
I get the same endless loop when setting [1] before running the engine-backup. [1] export PGPASSWORD=wrongpass export BACKUP_ENV_CLEAN=1
Target release should be placed once a package build is known to fix a issue. Since this bug is not modified, the target version has been reset. Please use target milestone to plan a fix for a oVirt release.
*** Bug 1255418 has been marked as a duplicate of this bug. ***
Still failing with endless loop. Verified with: ovirt-engine-3.6.2-0.0.master.20151124181807.git6d4897e.fc22.noarch # engine-backup --file=f1 --mode=backup FATAL: --log is missing readlink: missing operand Try 'readlink --help' for more information. /usr/bin/engine-backup: line 1405: : No such file or directory Notifying engine /usr/bin/engine-backup: line 1472: : No such file or directory /usr/bin/engine-backup: line 1405: : No such file or directory readlink: missing operand Try 'readlink --help' for more information. /usr/bin/engine-backup: line 1405: : No such file or directory Notifying engine /usr/bin/engine-backup: line 1472: : No such file or directory /usr/bin/engine-backup: line 1405: : No such file or directory readlink: missing operand ... ...
Sorry, some patches were not backported to 3.6.
oVirt 3.6.2 RC1 has been released for testing, moving to ON_QA
Verified with: ovirt-engine-3.6.3-0.0.master.20160105173810.git7421257.el6.noarch # engine-backup --file=f1 --mode=backup FATAL: --log is missing readlink: missing operand Try `readlink --help' for more information. /usr/bin/engine-backup: line 1405: : No such file or directory Notifying engine /usr/bin/engine-backup: line 1472: : No such file or directory /usr/bin/engine-backup: line 1405: : No such file or directory FATAL: Failed notifying engine No more endless loop.