Spec URL: https://jchaloup.fedorapeople.org/reviews/go-srpm-macros/go-srpm-macros.spec SRPM URL: https://jchaloup.fedorapeople.org/reviews/go-srpm-macros/go-srpm-macros-1-1.fc20.src.rpm Description: RPM macros for building Golang packages for various architectures Fedora Account System Username: jchaloup Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=10324221
Updated Koji build. - add BuildRequires: coreutils - use %{macro} in %go_arches instead of %macro Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=10327161
The spec file is fairly straightforward -> reviewed.
New Package SCM Request ======================= Package Name: go-srpm-macros.spec Short Description: RPM macros for building Golang packages for various architectures Owners: jchaloup vbatts jcajka Branches: f23 f22 f21 InitialCC: golang-sig
New Package SCM Request ======================= Package Name: go-srpm-macros Short Description: RPM macros for building Golang packages for various architectures Owners: jchaloup vbatts jcajka Branches: f23 f22 f21 InitialCC: golang-sig
Attaching review: Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: License field in the package spec file matches the actual license. [x]: Package must own all directories that it creates. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM.
Git done (by process-git-requests).
go-srpm-macros-1-1.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/go-srpm-macros-1-1.fc22
go-srpm-macros-1-1.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/go-srpm-macros-1-1.fc21
go-srpm-macros-1-1.fc22 has been pushed to the Fedora 22 testing repository.
go-srpm-macros-1-1.fc22 has been pushed to the Fedora 22 stable repository.
go-srpm-macros-1-1.fc21 has been pushed to the Fedora 21 stable repository.