Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1241487

Summary:	quota/marker: lk_owner is null while acquiring inodelk in rename operation
Product:	[Community] GlusterFS	Reporter:	Vijaikumar Mallikarjuna <vmallika>
Component:	quota	Assignee:	Vijaikumar Mallikarjuna <vmallika>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	3.7.2	CC:	bugs, gluster-bugs, rgowdapp, smohan
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.7.3	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:	1240598	Environment:
Last Closed:	2015-07-30 09:51:23 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1240598
Bug Blocks:	1241048

Description Vijaikumar Mallikarjuna 2015-07-09 10:24:54 UTC

+++ This bug was initially created as a clone of Bug #1240598 +++

Before doing a rename operation marker takes inode lock on the file parent,
here lk_owner is NULL and this can cause accounting problem with multiple rename on the same directory

--- Additional comment from Anand Avati on 2015-07-07 06:41:14 EDT ---

REVIEW: http://review.gluster.org/11561 (quota/marker: set lk_owner when taking lock on parent in rename) posted (#1) for review on master by Vijaikumar Mallikarjuna (vmallika)

--- Additional comment from Anand Avati on 2015-07-07 08:57:01 EDT ---

REVIEW: http://review.gluster.org/11561 (quota/marker: set lk_owner when taking lock on parent in rename) posted (#2) for review on master by Vijaikumar Mallikarjuna (vmallika)

Comment 1 Anand Avati 2015-07-09 10:25:59 UTC

REVIEW: http://review.gluster.org/11601 (quota/marker: set lk_owner when taking lock on parent in rename) posted (#1) for review on release-3.7 by Vijaikumar Mallikarjuna (vmallika)

Comment 2 Anand Avati 2015-07-13 06:41:33 UTC

COMMIT: http://review.gluster.org/11601 committed in release-3.7 by Raghavendra G (rgowdapp) 
------
commit 4cd60d5456c2ff0fe0455c8d1d534776bb8269c4
Author: vmallika <vmallika>
Date:   Tue Jul 7 16:03:26 2015 +0530

    quota/marker: set lk_owner when taking lock on parent in rename
    
    This is a backport of http://review.gluster.org/#/c/11561/
    
    Before doing a rename operation marker takes inode lock on the file
    parent,
    here lk_owner is NULL and this can cause accounting problem with
    multiple rename on the same directory
    
    This patch fix the problem by setting lk_owner
    
    > Change-Id: Ibb789e39b2833e425d0a5fca85282ff1465206cb
    > BUG: 1240598
    > Signed-off-by: vmallika <vmallika>
    
    Change-Id: Ibd3abaee2dd5d132906a79a518fbcedcdefc4552
    BUG: 1241487
    Signed-off-by: vmallika <vmallika>
    Reviewed-on: http://review.gluster.org/11601
    Tested-by: Gluster Build System <jenkins.com>
    Tested-by: NetBSD Build System <jenkins.org>
    Reviewed-by: Raghavendra G <rgowdapp>

Comment 3 Kaushal 2015-07-30 09:51:23 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.3, please open a new bug report.

glusterfs-3.7.3 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/12078
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user