Spec URL: https://toulevey.web.cern.ch/toulevey/fedora/keystoneauth/keystoneauth.spec SRPM URL: https://toulevey.web.cern.ch/toulevey/fedora/keystoneauth/keystoneauth.spec Description: Keystoneauth provides a standard way to do authentication and service requests within the OpenStack ecosystem. It is designed for use in conjunction with the existing OpenStack clients and for simplifying the process of writing new clients. Fedora Account System Username: alphacc
SRPM URL: https://toulevey.web.cern.ch/toulevey/fedora/keystoneauth/keystoneauth-0.2.0-1.fc22.src.rpm
Few things: * a typo in download url https://pypi.python.org/packages/source/k/keystoneauth/keystoneauth-0.2.0.tar.gz * naming guidelines require that python libraries package name to be prefixed by "python-" * no upper bounds on requirements => python-requests < 2.4.0 is responsible of failing the package installation as we have newer one. In this case, it's not a problem having a newer requests. * lower bounds are rarely updated so I advise to use them when necessary (python-six and python-requests requires them for instance) * Group: Documentation could be dropped, it's not used anymore (even on EL7) * I recommend using %license LICENSE to declare license files in %files * wrap description text in 80 columns * rdopkg reqquery -r test-requirements.txt shows that all dependencies for running tests are present, could you run them in %check As a prerequisite for the sponsorship process, could you do two informal reviews among those ones? https://bugzilla.redhat.com/show_bug.cgi?id=1241808 https://bugzilla.redhat.com/show_bug.cgi?id=1233168 https://bugzilla.redhat.com/show_bug.cgi?id=1241088 I plan to review all liberty deps after F23 is branched (next week).
Thanks for the feedback ; second try with all mentioned changes included : Spec URL: https://toulevey.web.cern.ch/toulevey/fedora/python-keystoneauth/python-keystoneauth.spec SRPM URL: https://toulevey.web.cern.ch/toulevey/fedora/python-keystoneauth/python-keystoneauth-0.2.0-2.fc22.src.rpm
FYI I'm importing python-keystoneauth to Delorean Trunk[*] @Thomas I didn't find public git with your spec, so I'll import from SRPM. [*] https://www.rdoproject.org/packaging/rdo-packaging.html#_how_to_add_a_new_package_to_rdo_master_packaging
Hi, I didn't the ack to upload to the SCM, should I go ahead ? Or I missed something ? -- Thomas
I meant git for draft spec while under review, e.g. in your github As discussed on IRC, this will be update to include upstream rename: https://github.com/openstack/keystoneauth/commit/a0000e4e9a4a2d59b1156e7dde04d19eafae05c8 But looking at that commit, it's unclear if upstream will provide multiple pypi packages from a single repo??
> But looking at that commit, it's unclear if upstream will provide multiple > pypi packages from a single repo?? And if so, should we have single SRPM building multiple subpackages? It's unclear when and where from keystoneauth2 will come.
Asking upstream for clarification https://review.openstack.org/#/c/191003/3//COMMIT_MSG
Fun fact: on pypi, empty projects up to https://pypi.python.org/pypi/keystoneauth7 have been created.
git with spec under review: https://github.com/alphacc/python-keystoneauth1 I'll test it and import to Delorean Trunk if it works.
Pushed rpm-master to https://github.com/openstack-packages/python-keystoneauth1/commits/rpm-master. I'll send rdoinfo PR after testing with local Delorean.
@Alan: I does not work for me. I'm investigating why, but first, python-keystoneauth1 was not installed (I had to install it with pip...) and even when installed, it failed.
@Emilien yep, that's why I didn't merge rdoinfo PR And once we have keystoneauth1 in Delorean Trunk, os-client-config needs to add Requires: python-keystoneauth or pyton-keystoneauth1 (see previous comments for unanswered questions about keystoneN story...) Debugging thread started on rdolist: https://www.redhat.com/archives/rdo-list/2015-September/msg00162.html
> I'll send rdoinfo PR after testing with local Delorean. https://github.com/redhat-openstack/rdoinfo/pull/92 is open until reported issue with osc is resolved!
Update following new naming and guidelines : Spec URL: https://toulevey.web.cern.ch/toulevey/fedora/python-keystoneauth/python-keystoneauth1.spec SRPM URL: https://toulevey.web.cern.ch/toulevey/fedora/python-keystoneauth/python-keystoneauth1-1.0.0-1.fc22.src.rpm
Thank you Thomas and Alan for your work. I hereby approve this package into Fedora Packages Collection, please submit a SCM request. Please wait we fix the os-config-client issue before building this package. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. No licenses found. Please check the source files for licenses manually. [x]: License file installed when any subpackage combination is installed. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python2-keystoneauth1 , python3-keystoneauth1 , python- keystoneauth1-doc [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python2-keystoneauth1-1.0.0-1.fc24.noarch.rpm python3-keystoneauth1-1.0.0-1.fc24.noarch.rpm python-keystoneauth1-doc-1.0.0-1.fc24.noarch.rpm python-keystoneauth1-1.0.0-1.fc24.src.rpm python2-keystoneauth1.noarch: W: spelling-error %description -l en_US Keystoneauth -> Keystone python3-keystoneauth1.noarch: W: spelling-error %description -l en_US Keystoneauth -> Keystone python-keystoneauth1.src: W: spelling-error %description -l en_US Keystoneauth -> Keystone 4 packages and 0 specfiles checked; 0 errors, 3 warnings. Rpmlint (installed packages) ---------------------------- 3 packages and 0 specfiles checked; 0 errors, 0 warnings. Requires -------- python3-keystoneauth1 (rpmlib, GLIBC filtered): python(abi) python3-iso8601 python3-oslo-config python3-requests python3-six python3-stevedore python2-keystoneauth1 (rpmlib, GLIBC filtered): python(abi) python-iso8601 python-oslo-config python-requests python-six python-stevedore python-keystoneauth1-doc (rpmlib, GLIBC filtered): Provides -------- python3-keystoneauth1: python3-keystoneauth python3-keystoneauth1 python2-keystoneauth1: python-keystoneauth python-keystoneauth1 python2-keystoneauth1 python-keystoneauth1-doc: python-keystoneauth1-doc Source checksums ---------------- http://pypi.python.org/packages/source/k/keystoneauth1/keystoneauth1-1.0.0.tar.gz : CHECKSUM(SHA256) this package : 1d73ee1bf0ea4ec92959314c5026d1909f9bd389f4e9d9d5555c472bb8c17a3e CHECKSUM(SHA256) upstream package : 1d73ee1bf0ea4ec92959314c5026d1909f9bd389f4e9d9d5555c472bb8c17a3e Generated by fedora-review 0.5.3 (bcf15e3) last change: 2015-05-04 Command line :/usr/bin/fedora-review -b 1241812 -m fedora-rawhide-x86_64 Buildroot used: fedora-rawhide-x86_64 Active plugins: Python, Generic, Shell-api Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
New Package SCM Request ======================= Package Name: python-keystoneauth1 Short Description: Authentication Library for OpenStack Clients Upstream URL: http://pypi.python.org/pypi/keystonauth1 Owners: alphacc, apevec Branches: f23 InitialCC: hguemar
Git done (by process-git-requests).